Skip to content

fix: remove-duplicated-alerts #31695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 8, 2025
Merged

Conversation

GustavoRSSilva
Copy link
Contributor

@GustavoRSSilva GustavoRSSilva commented Apr 8, 2025

Description

At the mometn we have the token alerts ducplicated

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to swap page, swap solana token
  2. select a token with a token alert

Screenshots/Recordings

Before

Screenshot 2025-04-08 at 11 06 52

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@GustavoRSSilva GustavoRSSilva requested a review from a team as a code owner April 8, 2025 10:08
Copy link
Contributor

github-actions bot commented Apr 8, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-swaps-and-bridge For issues with Swaps or Bridging label Apr 8, 2025
@metamaskbot
Copy link
Collaborator

✨ Files requiring CODEOWNER review ✨

🔄 @MetaMask/swaps-engineers

  • ui/pages/bridge/prepare/prepare-bridge-page.tsx

@metamaskbot
Copy link
Collaborator

Builds ready [dc8d193]
UI Startup Metrics (1244 ± 68 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1244112014166812971364
load10959851264641161985
domContentLoaded10899811252641170997
domInteractive17136561628
firstPaint819811261419188274
backgroundConnect107354910
firstReactRender20154562138
getState144811179
initialActions001001
loadScripts83072097759869938
setupStore8420379
WebpackHomeuiStartup21491717266317622662368
load16701243209915317521945
domContentLoaded16641239209515317461940
domInteractive171272111556
firstPaint160643186329486
backgroundConnect3811412603457
firstReactRender186523621165696
getState1643343679
initialActions317145
loadScripts16551234209115117401917
setupStore2062542569
FirefoxBrowserifyHomeuiStartup14121211196215914701773
load12591072179714513061596
domContentLoaded12591071179614513061595
domInteractive10243186309097
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2517103102639
firstReactRender23206052331
getState8442479
initialActions001001
loadScripts12361051176314312831569
setupStore1042032767
WebpackHomeuiStartup15111343204016115821957
load13041160180415313741752
domContentLoaded13031159180415313741752
domInteractive9346195239097
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect25165372842
firstReactRender35285053848
getState9465889
initialActions001011
loadScripts12811131178215213501719
setupStore8530489
Bundle size diffs
  • background: 0 Bytes (0%)
  • ui: -337 Bytes (0%)
  • common: 0 Bytes (0%)

@GustavoRSSilva GustavoRSSilva added this pull request to the merge queue Apr 8, 2025
Merged via the queue into main with commit 0e36ec7 Apr 8, 2025
164 checks passed
@GustavoRSSilva GustavoRSSilva deleted the fix/remove-duplicated-alerts branch April 8, 2025 18:35
@github-actions github-actions bot locked and limited conversation to collaborators Apr 8, 2025
@metamaskbot metamaskbot added the release-12.17.0 Issue or pull request that will be included in release 12.17.0 label Apr 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.17.0 Issue or pull request that will be included in release 12.17.0 team-swaps-and-bridge For issues with Swaps or Bridging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants