Skip to content

style: Update carousel styling and images #31687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 14, 2025
Merged

Conversation

amandaye0h
Copy link
Contributor

@amandaye0h amandaye0h commented Apr 7, 2025

Description

This updates the styling of the carousel component so it looks visually cohesive with the new brand and buttons.

Figma design.

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Open MetaMask

Screenshots/Recordings

Before

Screen.Recording.2025-04-08.at.7.53.39.AM.mov

After

Screen.Recording.2025-04-08.at.7.57.59.AM.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

github-actions bot commented Apr 7, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

✨ Files requiring CODEOWNER review ✨

🖥️ @MetaMask/wallet-ux

  • ui/components/multichain/carousel/carousel.tsx
  • ui/components/multichain/carousel/constants.ts
  • ui/components/multichain/carousel/index.scss

@metamaskbot
Copy link
Collaborator

Builds ready [8703d46]
UI Startup Metrics (1227 ± 63 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1227109714016312721350
load10759731202591151988
domContentLoaded10699701191601179986
domInteractive17136391530
firstPaint7791551202413234990
backgroundConnect106364910
firstReactRender19154451931
getState13532778
initialActions001001
loadScripts81972093557864917
setupStore7417278
WebpackHomeuiStartup21751762261820523182465
load16961355204415617901989
domContentLoaded16901350203915517851964
domInteractive171258101449
firstPaint169684447128295
backgroundConnect36113964439659
firstReactRender186563621106190
getState12462979
initialActions317145
loadScripts16781344201315117751938
setupStore21625525349
FirefoxBrowserifyHomeuiStartup13891206195115514521725
load12411062181114613131566
domContentLoaded12411061181114613131566
domInteractive10338307438896
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect251693102547
firstReactRender23194742430
getState1141892179
initialActions002001
loadScripts12171039178814612941537
setupStore6421367
WebpackHomeuiStartup15471347208415616001889
load13301152189314513701648
domContentLoaded13301152189314513701647
domInteractive9639175249097
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect26188492747
firstReactRender35296763846
getState10438789
initialActions002111
loadScripts13071131187514413451625
setupStore1152972989
Bundle size diffs
  • background: 0 Bytes (0%)
  • ui: 20 Bytes (0%)
  • common: 0 Bytes (0%)

@amandaye0h amandaye0h marked this pull request as ready for review April 8, 2025 01:51
@amandaye0h amandaye0h requested a review from a team as a code owner April 8, 2025 01:51
@amandaye0h amandaye0h added area-design Design bug (previously known as papercuts - ask Hilary for more detail) type-enhancement labels Apr 8, 2025
Copy link
Contributor

@vinnyhoward vinnyhoward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good!

@amandaye0h amandaye0h added this pull request to the merge queue Apr 8, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 8, 2025
@amandaye0h amandaye0h added this pull request to the merge queue Apr 9, 2025
@amandaye0h amandaye0h removed this pull request from the merge queue due to a manual request Apr 9, 2025
@amandaye0h amandaye0h added this pull request to the merge queue Apr 9, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Apr 9, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [170cea3]
UI Startup Metrics (1190 ± 50 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1190108013095012231289
load1029943117245965993
domContentLoaded1023940116844962988
domInteractive17133961631
firstPaint7261471132391278991
backgroundConnect6421279
firstReactRender20155052030
getState14545879
initialActions001001
loadScripts78771391943814872
setupStore7515278
WebpackHomeuiStartup21151710252817922592322
load16271304188013417311811
domContentLoaded16201300187513317231805
domInteractive15115691343
firstPaint174693906223992
backgroundConnect289344383061
firstReactRender181543721115995
getState11327579
initialActions318135
loadScripts16161299187313417211803
setupStore26630447298
FirefoxBrowserifyHomeuiStartup13581183171510114191570
load12081040156710612791409
domContentLoaded12081040156710612791408
domInteractive10738281358698
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2113110122030
firstReactRender22193832327
getState7413189
initialActions001001
loadScripts11891026155110612631393
setupStore6436467
WebpackHomeuiStartup15031343200312015871685
load12911150175510813621459
domContentLoaded12911150175510813621458
domInteractive8252192277190
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect22154462438
firstReactRender34295043642
getState8429389
initialActions002111
loadScripts12721134172410813441442
setupStore8538588

@amandaye0h amandaye0h added this pull request to the merge queue Apr 14, 2025
Merged via the queue into main with commit e7b5fdf Apr 14, 2025
166 checks passed
@amandaye0h amandaye0h deleted the carousel-styling-update branch April 14, 2025 18:40
@github-actions github-actions bot locked and limited conversation to collaborators Apr 14, 2025
@metamaskbot metamaskbot added the release-12.18.0 Issue or pull request that will be included in release 12.18.0 label Apr 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-design Design bug (previously known as papercuts - ask Hilary for more detail) release-12.18.0 Issue or pull request that will be included in release 12.18.0 team-assets type-enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants