Skip to content

style: Update Sepolia background color #31680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 22, 2025
Merged

Conversation

amandaye0h
Copy link
Contributor

@amandaye0h amandaye0h commented Apr 7, 2025

Description

This updates the background color of Sepolia so that it looks more cohesive with other network logos in the network menu.

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Open MetaMask
  2. Click on network selector

Screenshots/Recordings

Before

Screenshot 2025-04-08 at 4 40 18 AM

After

Screenshot 2025-04-08 at 4 43 13 AM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

github-actions bot commented Apr 7, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

✨ Files requiring CODEOWNER review ✨

🖥️ @MetaMask/wallet-ux

  • ui/css/utilities/colors.scss

@amandaye0h amandaye0h force-pushed the sepolia-color-update branch from e39273a to d4850c1 Compare April 7, 2025 21:05
@amandaye0h amandaye0h changed the title Update Sepolia background color style: Update Sepolia background color Apr 7, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [7f24ce3]
UI Startup Metrics (1223 ± 54 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1223109913855412571311
load10739671205471123991
domContentLoaded10669631194481117987
domInteractive17136381633
firstPaint852761200385182988
backgroundConnect106314910
firstReactRender19145661929
getState13542978
initialActions001000
loadScripts81771992645844883
setupStore7520278
WebpackHomeuiStartup21371701254717222502362
load16731293205315017561947
domContentLoaded16681289204914917511940
domInteractive171262111450
firstPaint163643636024983
backgroundConnect3311418433453
firstReactRender182524361145989
getState1442303079
initialActions316135
loadScripts16561252204615317421916
setupStore22628937359
FirefoxBrowserifyHomeuiStartup14091219187815914621816
load12571078173015113101651
domContentLoaded12571077173015113101651
domInteractive10438431459098
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2817125142952
firstReactRender24197072432
getState1041811979
initialActions001011
loadScripts12311054171114912861598
setupStore7449568
WebpackHomeuiStartup15481332217316516031964
load13341146193515513971705
domContentLoaded13341146193515513961705
domInteractive9636176239098
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect24176172539
firstReactRender36277073850
getState9431679
initialActions102111
loadScripts13121127191315513781676
setupStore8439579
Bundle size diffs
  • background: 0 Bytes (0%)
  • ui: 0 Bytes (0%)
  • common: 0 Bytes (0%)

@metamaskbot
Copy link
Collaborator

Builds ready [5571766]
UI Startup Metrics (1206 ± 52 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1206109713665212321321
load10579471195501106986
domContentLoaded10519401191501108987
domInteractive17135961629
firstPaint748781194409234988
backgroundConnect116607910
firstReactRender20155752029
getState13433769
initialActions001001
loadScripts80068393450825919
setupStore851031078
WebpackHomeuiStartup22711736286723324242701
load17861354253722319232135
domContentLoaded17801350253222219082127
domInteractive181275101747
firstPaint178663937327383
backgroundConnect4011421514166
firstReactRender170563701106694
getState1642192369
initialActions318145
loadScripts17661346252821418932076
setupStore28635151369
FirefoxBrowserifyHomeuiStartup13491149192516013721768
load12041025174914412261615
domContentLoaded12041025174814412261615
domInteractive10137388449198
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2616126152550
firstReactRender22195052230
getState941591678
initialActions001001
loadScripts11801006171014411961594
setupStore842052067
WebpackHomeuiStartup15741360209715416481966
load13531178190015014281738
domContentLoaded13521177190015014281737
domInteractive9770186218896
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect27196072941
firstReactRender38295964251
getState10430689
initialActions102111
loadScripts13281153187614913911711
setupStore9535589
Bundle size diffs
  • background: 0 Bytes (0%)
  • ui: 0 Bytes (0%)
  • common: 0 Bytes (0%)

@amandaye0h amandaye0h requested review from salimtb, georgewrmarshall and vinnyhoward and removed request for salimtb April 7, 2025 23:59
@amandaye0h amandaye0h marked this pull request as ready for review April 8, 2025 00:00
@amandaye0h amandaye0h requested a review from a team as a code owner April 8, 2025 00:00
@amandaye0h amandaye0h added area-design Design bug (previously known as papercuts - ask Hilary for more detail) type-enhancement labels Apr 8, 2025
@georgewrmarshall georgewrmarshall added this pull request to the merge queue Apr 22, 2025
@@ -12,7 +12,7 @@ Before adding a color here make sure that there isn't a design token available.
// DEPRECATED
// These third party network colors have been deprecated and should be removed once they are no longer in use. We should be using images to represent these networks instead.
--color-network-goerli-default: #1098fc;
--color-network-sepolia-default: #cfb5f0;
--color-network-sepolia-default: #c65cf2;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merged via the queue into main with commit db9cd7f Apr 22, 2025
167 checks passed
@georgewrmarshall georgewrmarshall deleted the sepolia-color-update branch April 22, 2025 02:36
@github-actions github-actions bot locked and limited conversation to collaborators Apr 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-design Design bug (previously known as papercuts - ask Hilary for more detail) team-assets type-enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants