Skip to content

fix: switch-ethereun-chain not passing rejectApprovalRequestsForOrigin hook correctly #31672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 8, 2025

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Apr 7, 2025

Description

switch-ethereun-chain not passing rejectApprovalRequestsForOrigin hook correctly

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/4604

Manual testing steps

NA

Screenshots/Recordings

NA

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jpuri jpuri added the team-confirmations Push issues to confirmations team label Apr 7, 2025
@jpuri jpuri enabled auto-merge April 7, 2025 16:14
Copy link
Contributor

github-actions bot commented Apr 7, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [6a63d7f]
UI Startup Metrics (1233 ± 68 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1233108714126812881349
load10809361254691177985
domContentLoaded10749291245681178992
domInteractive17136071628
firstPaint815791251406227985
backgroundConnect106334910
firstReactRender19143032026
getState12533778
initialActions001001
loadScripts82669097867880935
setupStore8524378
WebpackHomeuiStartup21731716267017722992404
load17141312210114917862009
domContentLoaded17081308207014717802002
domInteractive171263101447
firstPaint152653285727286
backgroundConnect281078133457
firstReactRender182533631145888
getState123631069
initialActions315144
loadScripts17001301206014317721979
setupStore22631939299
FirefoxBrowserifyHomeuiStartup14031184189714914581778
load12491059174613912781601
domContentLoaded12481059174613912781601
domInteractive9739192258997
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect28186393052
firstReactRender23194142430
getState8429389
initialActions002001
loadScripts12221041172313812531578
setupStore1242092967
WebpackHomeuiStartup15651313216416416391897
load13531138191615114201657
domContentLoaded13531137191515114201656
domInteractive9963188209195
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect3018319392636
firstReactRender35295053948
getState9434689
initialActions102111
loadScripts13251119189415013881634
setupStore8528489
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 103 Bytes (0%)
  • ui: 0 Bytes (0%)
  • common: 0 Bytes (0%)

@jpuri jpuri added this pull request to the merge queue Apr 8, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 8, 2025
@jpuri jpuri added this pull request to the merge queue Apr 8, 2025
Merged via the queue into main with commit 441d246 Apr 8, 2025
169 checks passed
@jpuri jpuri deleted the switch_eth_chain_hook_fix branch April 8, 2025 06:23
@github-actions github-actions bot locked and limited conversation to collaborators Apr 8, 2025
@metamaskbot metamaskbot added the release-12.17.0 Issue or pull request that will be included in release 12.17.0 label Apr 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.17.0 Issue or pull request that will be included in release 12.17.0 team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants