fix: import srp error handling and style #31662
Merged
+177
−78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
✨ Files requiring CODEOWNER review ✨🖥️ @MetaMask/wallet-ux
|
montelaidev
changed the title
vinnyhoward
requested changes
Apr 8, 2025
darioAnongba
previously approved these changes
Apr 9, 2025
Builds ready [59fba05]
UI Startup Metrics (1217 ± 58 ms)
|
darioAnongba
previously approved these changes
Apr 9, 2025
vinnyhoward
reviewed
Apr 9, 2025
| width={BlockSize.Full} | ||
| marginTop={4} | ||
| paddingBottom={6} | ||
| backgroundColor={ |
There was a problem hiding this comment.
Nice! Can we add padding at the top of the button as well?
| Current | Example |
|---|---|
 |
 |
darioAnongba
approved these changes
Apr 9, 2025
Builds ready [dbae5ab]
UI Startup Metrics (1250 ± 61 ms)
|
Teng-Web3
pushed a commit
to Teng-Web3/metamask-extension-Teng
that referenced
this pull request
Apr 9, 2025
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** This PR fixes the following: 1. The import button is now floating 2. Importing a 12 word srp when 24 word is selected is now blocked. 3. Add 12 word srp option. <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 4. What is the improvement/solution? --> [](https://codespaces.new/MetaMask/metamask-extension/pull/31662?quickstart=1) ## **Related issues** Fixes: https://consensyssoftware.atlassian.net/browse/MMMULTISRP-151?atlOrigin=eyJpIjoiY2E4MzA0ZTg4NjlkNDExY2IyZDAyODFjNzIzNTk5MjYiLCJwIjoiaiJ9 Fixes: https://consensyssoftware.atlassian.net/browse/MMMULTISRP-147?atlOrigin=eyJpIjoiMjFhOWYxOTc1MTM5NGMwMmE0ZjBiYTk5YTQxNjAyNDEiLCJwIjoiaiJ9 Fixes:https://consensyssoftware.atlassian.net/browse/MMMULTISRP-146?atlOrigin=eyJpIjoiYjQyNDdhYjRmODgxNGQwMjhkNzRiOTgwNzAyY2U1Y2IiLCJwIjoiaiJ9 ## **Manual testing steps** 1. Go to account menu 2. Click on `Secret Recovery Phrase` 3. See that the import button is always visible 4. Click on 24 word option 5. Fill in a 12 word srp and see that the import button is still disabled 6. See that there is a button to change back to 12 word srp. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
](https://codespaces.new/MetaMask/metamask-extension/pull/31662?quickstart=1){kind=link}
metamaskbot
added
the
release-12.17.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the following:
Related issues
Fixes: https://consensyssoftware.atlassian.net/browse/MMMULTISRP-151?atlOrigin=eyJpIjoiY2E4MzA0ZTg4NjlkNDExY2IyZDAyODFjNzIzNTk5MjYiLCJwIjoiaiJ9
Fixes: https://consensyssoftware.atlassian.net/browse/MMMULTISRP-147?atlOrigin=eyJpIjoiMjFhOWYxOTc1MTM5NGMwMmE0ZjBiYTk5YTQxNjAyNDEiLCJwIjoiaiJ9
Fixes:https://consensyssoftware.atlassian.net/browse/MMMULTISRP-146?atlOrigin=eyJpIjoiYjQyNDdhYjRmODgxNGQwMjhkNzRiOTgwNzAyY2U1Y2IiLCJwIjoiaiJ9
Manual testing steps
Secret Recovery PhraseScreenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist