fix: dark mode styling and spacing #31661

montelaidev · 2025-04-07T14:33:39Z

Description

This PR fixes the dark mode styling of the scroll bar in the reveal srp page and spacing.

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/MMMULTISRP-155?atlOrigin=eyJpIjoiMmM0MmQ2ZTEzMWY4NGMzZmIwMWQ0NjBmMDdiNmM0NzEiLCJwIjoiaiJ9

Fixes: https://consensyssoftware.atlassian.net/browse/MMMULTISRP-154?atlOrigin=eyJpIjoiOGU4N2JkYzk0MWNkNGFhMTgyMDgxZDQ3NWY3ZmJhZjYiLCJwIjoiaiJ9

Manual testing steps

Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2025-04-07T14:36:10Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2025-04-07T14:37:44Z

✨ Files requiring CODEOWNER review ✨

🖥️ @MetaMask/wallet-ux

ui/components/multichain/multi-srp/select-srp/select-srp.tsx
ui/components/multichain/multi-srp/srp-list/index.scss

metamaskbot · 2025-04-08T11:02:24Z

Builds ready [36200fa]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1207 ± 52 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1207	1115	1440	52	1240	1288
			load	1058	969	1265	48	1111	992
			domContentLoaded	1053	964	1262	48	1111	992
			domInteractive	17	13	72	10	16	30
			firstPaint	779	73	1145	405	232	977
			backgroundConnect	9	6	31	3	9	10
			firstReactRender	19	15	38	4	20	27
			getState	13	5	33	7	7	9
			initialActions	0	0	1	0	0	1
			loadScripts	803	714	1005	45	834	860
			setupStore	7	5	32	3	7	8
	Webpack	Home	uiStartup	2129	1702	2538	196	2279	2437
			load	1669	1318	2095	163	1763	1957
			domContentLoaded	1663	1315	2091	162	1758	1934
			domInteractive	17	11	63	11	14	48
			firstPaint	150	62	382	58	255	84
			backgroundConnect	34	11	406	46	34	61
			firstReactRender	174	53	353	110	57	94
			getState	10	4	39	6	6	9
			initialActions	3	1	7	1	4	5
			loadScripts	1654	1312	2088	160	1751	1908
			setupStore	20	6	318	31	34	9
Firefox	Browserify	Home	uiStartup	1384	1198	1941	165	1429	1782
			load	1241	1049	1779	156	1298	1585
			domContentLoaded	1241	1049	1779	156	1297	1585
			domInteractive	108	36	262	41	92	97
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	26	17	96	12	26	53
			firstReactRender	23	19	39	3	24	29
			getState	9	4	161	16	7	9
			initialActions	0	0	1	0	0	1
			loadScripts	1217	1031	1751	153	1280	1546
			setupStore	6	4	25	3	6	7
	Webpack	Home	uiStartup	1508	1324	2072	151	1577	1871
			load	1298	1138	1877	143	1348	1621
			domContentLoaded	1297	1138	1877	143	1348	1621
			domInteractive	93	40	170	21	91	96
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	26	17	84	10	27	46
			firstReactRender	36	28	53	6	40	47
			getState	9	4	30	5	8	9
			initialActions	1	0	4	1	1	1
			loadScripts	1274	1121	1858	142	1326	1597
			setupStore	8	4	36	5	7	9

Bundle size diffs

background: 0 Bytes (0%)
ui: 0 Bytes (0%)
common: 0 Bytes (0%)

metamaskbot · 2025-04-09T12:39:10Z

❌ API Spec Test Failed. View the report here.

metamaskbot · 2025-04-09T13:03:03Z

❌ API Spec Test Failed. View the report here.

metamaskbot · 2025-04-09T13:21:52Z

Builds ready [30e8173]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

UI Startup Metrics (1231 ± 66 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1231	1113	1471	66	1266	1368
			load	1083	976	1249	61	1142	993
			domContentLoaded	1077	967	1242	60	1141	990
			domInteractive	16	13	34	4	16	28
			firstPaint	757	163	1223	419	237	994
			backgroundConnect	10	6	32	4	9	10
			firstReactRender	18	15	42	4	19	28
			getState	13	5	45	8	7	8
			initialActions	0	0	1	0	0	0
			loadScripts	826	725	995	59	860	959
			setupStore	7	4	13	2	7	8
	Webpack	Home	uiStartup	2162	1726	2409	153	2275	2365
			load	1690	1340	2040	130	1757	1955
			domContentLoaded	1685	1330	2034	130	1753	1949
			domInteractive	17	12	68	11	14	50
			firstPaint	170	65	501	74	292	91
			backgroundConnect	31	11	208	28	37	50
			firstReactRender	178	53	364	107	56	91
			getState	12	4	40	6	7	9
			initialActions	3	1	5	1	3	5
			loadScripts	1676	1326	2009	128	1748	1927
			setupStore	19	6	181	18	33	9
Firefox	Browserify	Home	uiStartup	1361	1147	1703	114	1414	1637
			load	1221	1027	1566	115	1285	1485
			domContentLoaded	1221	1027	1565	115	1284	1485
			domInteractive	95	37	146	24	89	97
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	25	16	59	8	26	44
			firstReactRender	22	18	50	4	22	27
			getState	7	4	36	4	7	9
			initialActions	0	0	2	0	0	1
			loadScripts	1198	998	1543	114	1263	1462
			setupStore	6	3	35	3	6	6
	Webpack	Home	uiStartup	1553	1378	1919	115	1616	1808
			load	1341	1195	1672	109	1413	1574
			domContentLoaded	1341	1195	1672	109	1413	1574
			domInteractive	93	63	176	20	87	92
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	24	18	43	4	26	32
			firstReactRender	35	28	53	5	38	46
			getState	8	4	31	4	8	9
			initialActions	0	0	1	0	1	1
			loadScripts	1318	1175	1649	109	1391	1551
			setupStore	8	5	30	4	8	9

montelaidev added 2 commits April 7, 2025 19:49

fix: dark mode styling

9b417e7

fix: mmmultisrp-154 fix spacing

81816fa

metamaskbot added the team-accounts label Apr 7, 2025

montelaidev changed the title ~~Fix/mmmultisrp 155~~ fix: dark mode styling and spacing Apr 8, 2025

montelaidev marked this pull request as ready for review April 8, 2025 10:23

Merge branch 'main' into fix/mmmultisrp-155

36200fa

montelaidev requested a review from a team as a code owner April 8, 2025 10:23

vinnyhoward approved these changes Apr 8, 2025

View reviewed changes

darioAnongba approved these changes Apr 9, 2025

View reviewed changes

montelaidev added this pull request to the merge queue Apr 9, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 9, 2025

montelaidev added this pull request to the merge queue Apr 9, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 9, 2025

montelaidev added this pull request to the merge queue Apr 9, 2025

montelaidev removed this pull request from the merge queue due to a manual request Apr 9, 2025

Merge branch 'main' into fix/mmmultisrp-155

30e8173

montelaidev enabled auto-merge April 9, 2025 12:22

montelaidev added this pull request to the merge queue Apr 9, 2025

Merged via the queue into main with commit 01b666d Apr 9, 2025
167 checks passed

montelaidev deleted the fix/mmmultisrp-155 branch April 9, 2025 14:09

github-actions bot locked and limited conversation to collaborators Apr 9, 2025

metamaskbot added the release-12.17.0 Issue or pull request that will be included in release 12.17.0 label Apr 9, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: dark mode styling and spacing #31661

fix: dark mode styling and spacing #31661

montelaidev commented Apr 7, 2025 •

edited

Loading

github-actions bot commented Apr 7, 2025

metamaskbot commented Apr 7, 2025

metamaskbot commented Apr 8, 2025

metamaskbot commented Apr 9, 2025

metamaskbot commented Apr 9, 2025

metamaskbot commented Apr 9, 2025

fix: dark mode styling and spacing #31661

fix: dark mode styling and spacing #31661

Conversation

montelaidev commented Apr 7, 2025 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Apr 7, 2025

metamaskbot commented Apr 7, 2025

✨ Files requiring CODEOWNER review ✨

metamaskbot commented Apr 8, 2025

metamaskbot commented Apr 9, 2025

metamaskbot commented Apr 9, 2025

metamaskbot commented Apr 9, 2025

montelaidev commented Apr 7, 2025 •

edited

Loading