Skip to content

fix: add solana modal title #31660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 8, 2025
Merged

fix: add solana modal title #31660

merged 2 commits into from
Apr 8, 2025

Conversation

PatrykLucka
Copy link
Contributor

@PatrykLucka PatrykLucka commented Apr 7, 2025

Description

This PR updates Add accounts modal titles to specify what kind of account is being added.

Related issues

Fixes:

Manual testing steps

  1. Open account menu
  2. Click add account
  3. Click Ethereum Account or Solana Account
  4. Titles should be different for above options

Screenshots/Recordings

Before

Screenshot 2025-04-08 at 12 47 06

After

Screenshot 2025-04-08 at 12 49 06 Screenshot 2025-04-08 at 12 49 12

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@PatrykLucka PatrykLucka self-assigned this Apr 7, 2025
Copy link
Contributor

github-actions bot commented Apr 7, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-mmi PRs from the MMI team label Apr 7, 2025
@metamaskbot
Copy link
Collaborator

metamaskbot commented Apr 7, 2025

✨ Files requiring CODEOWNER review ✨

🖥️ @MetaMask/wallet-ux

  • ui/components/multichain/account-list-menu/account-list-menu.test.tsx
  • ui/components/multichain/account-list-menu/account-list-menu.tsx

@PatrykLucka PatrykLucka force-pushed the fix-add-solana-modal-title branch from 2f532d9 to a32c210 Compare April 7, 2025 15:14
@PatrykLucka PatrykLucka force-pushed the fix-add-solana-modal-title branch from a32c210 to e15cf15 Compare April 7, 2025 15:24
@metamaskbot
Copy link
Collaborator

Builds ready [e15cf15]
UI Startup Metrics (1239 ± 58 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1239113413995812801337
load10819271192641154963
domContentLoaded10749201186641158992
domInteractive17136261630
firstPaint71883119443623983
backgroundConnect106314910
firstReactRender2215155152035
getState13545868
initialActions001000
loadScripts82167993862868917
setupStore8528478
WebpackHomeuiStartup23791812281118425072638
load18741423225418819972189
domContentLoaded18661419224118519912175
domInteractive181368101649
firstPaint177664607126282
backgroundConnect6013323664887
firstReactRender160583661046782
getState2642444459
initialActions328136
loadScripts18541415223618019642158
setupStore27736847419
FirefoxBrowserifyHomeuiStartup13301159190815413481676
load11911042175914412341511
domContentLoaded11911042175814412321511
domInteractive9538229309096
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2616206212647
firstReactRender21194732226
getState941851878
initialActions001001
loadScripts11651025173314212171485
setupStore7428567
WebpackHomeuiStartup15521343209715516151934
load13351170185814713731718
domContentLoaded13351170185814713731717
domInteractive9665179228897
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect26195162738
firstReactRender36287483853
getState1242882889
initialActions102111
loadScripts13111151183314713491694
setupStore9562779
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: -27 Bytes (0%)
  • ui: 67 Bytes (0%)
  • common: 347 Bytes (0%)

@metamaskbot
Copy link
Collaborator

Builds ready [6485b14]
UI Startup Metrics (1240 ± 61 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1240111513726112881344
load10899811193571150992
domContentLoaded10839761188561149996
domInteractive17136081635
firstPaint843961190406172268
backgroundConnect107232910
firstReactRender21145072237
getState12564878
initialActions001001
loadScripts83173193953876914
setupStore8527379
WebpackHomeuiStartup20811604256718422022287
load16111219199116417071889
domContentLoaded16061214196516317031879
domInteractive161263111450
firstPaint164673146326085
backgroundConnect3010433423247
firstReactRender169533761136390
getState1743965189
initialActions316135
loadScripts15981208194016116981854
setupStore31635258309
FirefoxBrowserifyHomeuiStartup13521169186815713871791
load12121021172414912541626
domContentLoaded12111021172314912541626
domInteractive9939233328997
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect251679102745
firstReactRender22195652328
getState7442478
initialActions001001
loadScripts11881005169214612341596
setupStore841991967
WebpackHomeuiStartup15431337215615316221819
load13371138195614914041626
domContentLoaded13361137195614814031625
domInteractive9738223269098
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect25178692641
firstReactRender36286373949
getState9430679
initialActions102111
loadScripts13141116193614813831604
setupStore9562789
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 2.73 KiB (0.04%)
  • ui: -3.89 KiB (-0.06%)
  • common: 2.01 KiB (0.02%)

@PatrykLucka PatrykLucka marked this pull request as ready for review April 8, 2025 11:51
@PatrykLucka PatrykLucka requested a review from a team as a code owner April 8, 2025 11:51
@PatrykLucka PatrykLucka enabled auto-merge April 8, 2025 16:28
@PatrykLucka PatrykLucka added this pull request to the merge queue Apr 8, 2025
@mustafacryptolife
Copy link

C

Merged via the queue into main with commit 82ee0c9 Apr 8, 2025
165 checks passed
@PatrykLucka PatrykLucka deleted the fix-add-solana-modal-title branch April 8, 2025 19:18
@github-actions github-actions bot locked and limited conversation to collaborators Apr 8, 2025
@metamaskbot metamaskbot added the release-12.17.0 Issue or pull request that will be included in release 12.17.0 label Apr 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.17.0 Issue or pull request that will be included in release 12.17.0 team-mmi PRs from the MMI team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants