-
Notifications
You must be signed in to change notification settings - Fork 5.2k
fix: wrap long asset names #31657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: wrap long asset names #31657
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
@@ -27,7 +27,7 @@ export const TokenCellTitle = React.memo( | |||
<Tooltip | |||
position="bottom" | |||
html={token.title} | |||
tooltipInnerClassName="multichain-token-list-item__tooltip" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The class multichain-token-list-item__tooltip
does not seem to exist.
Also, tooltipInnerClassName
does not look like a property of Tooltip
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice find!
white-space: nowrap; | ||
overflow: hidden; | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as mm-text--ellipsis
.
Nice fix! On the UI it looks like if we shorten it a bit more it would look better, the dots seem to be too close to the value |
Builds ready [e7f4699]
UI Startup Metrics (1251 ± 67 ms)
Bundle size diffs
|
Description
Very long asset titles overflow is not working, and it is hiding the token value.
Related issues
Fixes:
Manual testing steps
Option 1:
Option 2:
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist