fix: NFT Grid tooltip #31625
Merged
fix: NFT Grid tooltip #31625
+41
−36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
✨ Files requiring CODEOWNER review ✨✅ @MetaMask/confirmations
🖥️ @MetaMask/wallet-ux
|
| import Tooltip from '../../ui/tooltip/tooltip'; | ||
| import { ENVIRONMENT_TYPE_FULLSCREEN } from '../../../../shared/constants/app'; | ||
| // eslint-disable-next-line import/no-restricted-paths | ||
| import { getEnvironmentType } from '../../../../app/scripts/lib/util'; |
There was a problem hiding this comment.
Hmm this rule is meant to prevent the UI from requesting stuff from the background/scripts.
Is there another getEnvironmentType or utility we can use here?
There was a problem hiding this comment.
As far as I know, this is the only utility. We're using it in a few places already. Do you know of another one we can use instead?
There was a problem hiding this comment.
Aw damn. No I don't know of another one we can use.
Thats okay then 😄
There was a problem hiding this comment.
Looking at the implementation, I'm not sure why this can only be used in the background.
metamask-extension/app/scripts/lib/util.ts
Lines 55 to 56 in a4179bc
I think it can be moved to the shared folder in the future.
| ellipsis | ||
| > | ||
| {nft?.name} | ||
| </Text>{' '} |
There was a problem hiding this comment.
Is this whitespace needed?
There was a problem hiding this comment.
Good catch. Don't know where this came from, will remove
Builds ready [93facbd]
UI Startup Metrics (1214 ± 60 ms)
Bundle size diffs
|
Builds ready [0c55317]
UI Startup Metrics (1202 ± 65 ms)
Bundle size diffs
|
Prithpal-Sooriya
previously approved these changes
Apr 5, 2025
NidhiKJha
previously approved these changes
Apr 7, 2025
Builds ready [1155f70]
UI Startup Metrics (1252 ± 61 ms)
Bundle size diffs
|
digiwand
previously approved these changes
Apr 7, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
gambinish
dismissed stale reviews from digiwand, NidhiKJha, and Prithpal-Sooriya
via
b7a8af2
Builds ready [94b833f]
UI Startup Metrics (1197 ± 57 ms)
|
darkwing
approved these changes
Apr 14, 2025
digiwand
approved these changes
Apr 15, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Builds ready [4e2610b]
UI Startup Metrics (1225 ± 74 ms)
Bundle size diffs
|
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 15, 2025
## **Description** Adds tooltip to truncated NFT Grid titles. [](https://codespaces.new/MetaMask/metamask-extension/pull/31625?quickstart=1) ## **Related issues** Fixes: ## **Manual testing steps** Hover over NFT grid item that is truncated, if truncated it should tooltip, if the title is fully visible it should not tooltip ## **Screenshots/Recordings** https://github.com/user-attachments/assets/ea98bb55-1325-4c83-ba17-a830318f3ecf ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Prithpal-Sooriya
approved these changes
Apr 15, 2025
](https://codespaces.new/MetaMask/metamask-extension/pull/31625?quickstart=1){kind=link}
metamaskbot
added
the
release-12.18.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds tooltip to truncated NFT Grid titles.
Related issues
Fixes:
Manual testing steps
Hover over NFT grid item that is truncated, if truncated it should tooltip, if the title is fully visible it should not tooltip
Screenshots/Recordings
demo.mov
Pre-merge author checklist
Pre-merge reviewer checklist