Skip to content

style: Update font weights for balance, price and other headers #31624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 7, 2025

Conversation

amandaye0h
Copy link
Contributor

@amandaye0h amandaye0h commented Apr 4, 2025

Description

This updates the font weight for the headers on these pages: home, token details and NFT details. It refines the visual language of the product.

Link to relevant designs

Open in GitHub Codespaces

Related issues

Fixes: None

Manual testing steps

  1. Open MetaMask
  2. Go to token details
  3. Go to NFT details

Screenshots/Recordings

Before

Screenshot 2025-04-05 at 4 32 30 AM

After

Screenshot 2025-04-05 at 4 31 16 AM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

github-actions bot commented Apr 4, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [0feb860]
UI Startup Metrics (1200 ± 52 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1200111113815212331292
load10549611211481131993
domContentLoaded10489551206481206992
domInteractive16133351629
firstPaint8661321211358229993
backgroundConnect117809910
firstReactRender18144751831
getState11441767
initialActions001001
loadScripts79770793847830882
setupStore7523278
WebpackHomeuiStartup20701638248220022122307
load16061260200815517221811
domContentLoaded16011256199615417181806
domInteractive171266121455
firstPaint161653235723773
backgroundConnect3011351353359
firstReactRender180543501097891
getState10323489
initialActions512302334
loadScripts15921253197315317151794
setupStore28630357239
FirefoxBrowserifyHomeuiStartup14101171191616614721826
load12631054177015313221651
domContentLoaded12631054177015313221651
domInteractive9837172258896
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2616136152648
firstReactRender22183132528
getState8349579
initialActions001001
loadScripts12381037174615012991617
setupStore7421368
WebpackHomeuiStartup15121323194914915771868
load13041142174313913581646
domContentLoaded13041142174213913581645
domInteractive9136162239097
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect25175572646
firstReactRender36295363947
getState9330678
initialActions102111
loadScripts12811120171613813391621
setupStore8427389
Bundle size diffs
  • background: 0 Bytes (0%)
  • ui: 33 Bytes (0%)
  • common: 0 Bytes (0%)

@amandaye0h amandaye0h marked this pull request as ready for review April 4, 2025 21:24
Copy link
Contributor

@vinnyhoward vinnyhoward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@amandaye0h amandaye0h added this pull request to the merge queue Apr 7, 2025
@amandaye0h amandaye0h removed this pull request from the merge queue due to a manual request Apr 7, 2025
@amandaye0h amandaye0h added this pull request to the merge queue Apr 7, 2025
Merged via the queue into main with commit 8a52f49 Apr 7, 2025
169 checks passed
@amandaye0h amandaye0h deleted the balance-font-update branch April 7, 2025 21:43
@github-actions github-actions bot locked and limited conversation to collaborators Apr 7, 2025
@metamaskbot metamaskbot added the release-12.17.0 Issue or pull request that will be included in release 12.17.0 label Apr 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.17.0 Issue or pull request that will be included in release 12.17.0 team-assets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants