feat: add setting to dismiss prompt to enable smart contract #31609
+224
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Builds ready [2bed795]
UI Startup Metrics (1213 ± 58 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [bb98225]
UI Startup Metrics (1240 ± 66 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
matthewwalsh0
requested changes
Apr 8, 2025
|
|
||
| if (!isUpgradeTransaction) { | ||
| if (!isUpgradeTransaction || dismissSmartAccountSuggestionEnabled) { |
There was a problem hiding this comment.
Unfortunately we can't just hide the acknowledge checkbox as the transaction would still perform the upgrade once approved.
If we instead check this here:
Then the middleware would reject the request outright since the user has said they never want to upgrade.
Plus technically we should also check if the user is already upgraded and skip this check, but that can be done in a separate ticket as I have pending changes in the transaction controller to get that information.
There was a problem hiding this comment.
oh my bad, I fixed this
There was a problem hiding this comment.
Let me create task for
Plus technically we should also check if the user is already upgraded and skip this check, but that can be done in a separate ticket as I have pending changes in the transaction controller to get that information.
| @@ -200,6 +201,7 @@ export const getDefaultPreferencesControllerState = | |||
| showMultiRpcModal: false, | |||
| privacyMode: false, | |||
| shouldShowAggregatedBalancePopover: true, // by default user should see popover; | |||
| dismissSmartAccountSuggestionEnabled: false, | |||
There was a problem hiding this comment.
We already have the accountUpgradeDisabledChains also, should this be combined into that?
Do we also want to display those in the settings UI?
There was a problem hiding this comment.
yep I was also thinking about re-using this - and I think this will be more a user level thing and not account level, additionally it will reflect across the app
ui/selectors/selectors.js
Outdated
| @@ -1998,6 +1998,11 @@ export function getShouldShowAggregatedBalancePopover(state) { | |||
| return shouldShowAggregatedBalancePopover; | |||
| } | |||
|
|
|||
| export function getDismissSmartAccountSuggestionEnabled(state) { | |||
There was a problem hiding this comment.
Should we use ui/pages/confirmations/selectors/preferences.ts instead of adding to this huge file?
Builds ready [33a4883]
UI Startup Metrics (1272 ± 63 ms)
|
matthewwalsh0
previously approved these changes
Apr 9, 2025
| function validateUserPreference(dismissSmartAccountSuggestionEnabled: boolean) { | ||
| if (dismissSmartAccountSuggestionEnabled) { | ||
| throw rpcErrors.transactionRejected( | ||
| 'User does not want to update account to smart account.', |
There was a problem hiding this comment.
Could we combine this with the above to use the same error, as they're ultimately both preferences to not upgrade?
There was a problem hiding this comment.
Message for both will be bit different, as other will be address level now and this is more user level thing.
There was a problem hiding this comment.
Even so, from the perspective of the dApp, it's simply not supported for that chain and account. Plus I think we want to stick with methodNotSupported for now since the user hasn't technically rejected the transaction, but the act of upgrading.
There was a problem hiding this comment.
👍 I will implement code changes in following PR.
There was a problem hiding this comment.
I made these changes in PR while updating it to resolve conflicts
matthewwalsh0
approved these changes
Apr 9, 2025
vinistevam
approved these changes
Apr 9, 2025
Builds ready [79078c5]
UI Startup Metrics (1246 ± 65 ms)
|
metamaskbot
added
the
release-12.17.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We should add a toggle within Settings > Advanced to not be asked to update an account to a Smart Account again.
Related issues
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/4559
Manual testing steps
"Switch to Smart Account" suggestionScreenshots/Recordings
Pre-merge author checklist
Pre-merge reviewer checklist