fix: For batch transactions sum total of gas needed for all transactions in the batched should be check to show insufficient funds error #31555

jpuri · 2025-04-03T09:50:59Z

Description

For batch transactions sum total of gas needed for all transactions in the batched should be check to show insufficient funds error

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/4571

Manual testing steps

Submit a batched transaction with a simple send whose value is more than your balance
You should see insufficient fund alert

Screenshots/Recordings

TODO

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

…n the batched should be check to show insufficient funds error

github-actions · 2025-04-03T09:51:12Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2025-04-03T09:52:57Z

✨ Files requiring CODEOWNER review ✨

✅ @MetaMask/confirmations

ui/pages/confirmations/hooks/alerts/transactions/useInsufficientBalanceAlerts.test.ts
ui/pages/confirmations/hooks/alerts/transactions/useInsufficientBalanceAlerts.ts
ui/pages/confirmations/send/send.utils.js

metamaskbot · 2025-04-03T10:26:21Z

Builds ready [c4bdea2]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

UI Startup Metrics (1218 ± 62 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1218	1116	1441	62	1256	1334
			load	1064	964	1217	56	1145	989
			domContentLoaded	1058	960	1209	55	1179	985
			domInteractive	16	13	62	6	16	28
			firstPaint	748	83	1218	415	245	990
			backgroundConnect	10	6	56	7	9	10
			firstReactRender	18	15	32	3	19	23
			getState	10	4	29	6	6	8
			initialActions	0	0	1	0	0	1
			loadScripts	809	714	957	54	846	908
			setupStore	7	5	15	2	7	8
	Webpack	Home	uiStartup	2104	1652	2607	202	2189	2522
			load	1628	1307	2019	157	1718	1943
			domContentLoaded	1622	1303	1995	154	1714	1917
			domInteractive	17	12	67	11	14	49
			firstPaint	193	65	411	59	242	76
			backgroundConnect	26	14	80	15	27	69
			firstReactRender	213	56	367	119	77	91
			getState	11	3	274	27	8	9
			initialActions	3	1	6	1	3	4
			loadScripts	1614	1300	1969	150	1711	1892
			setupStore	24	6	286	49	24	9
Firefox	Browserify	Home	uiStartup	1384	1204	1991	160	1419	1819
			load	1244	1054	1846	151	1292	1652
			domContentLoaded	1244	1054	1846	151	1292	1651
			domInteractive	101	38	247	30	88	97
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	25	16	169	16	25	39
			firstReactRender	23	19	48	4	24	31
			getState	7	3	39	4	7	8
			initialActions	0	0	1	0	0	1
			loadScripts	1221	1037	1820	146	1262	1581
			setupStore	6	4	32	3	6	7
	Webpack	Home	uiStartup	1572	1346	2048	146	1635	1938
			load	1358	1169	1823	143	1424	1697
			domContentLoaded	1357	1168	1822	143	1423	1696
			domInteractive	102	43	177	23	91	97
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	25	18	62	7	27	43
			firstReactRender	36	28	108	9	38	46
			getState	8	3	32	5	7	9
			initialActions	1	0	2	1	1	1
			loadScripts	1335	1149	1800	142	1403	1675
			setupStore	8	5	27	3	8	9

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0%)
ui: 4.25 KiB (0.06%)
common: 290 Bytes (0%)

matthewwalsh0 · 2025-04-03T12:29:21Z

ui/pages/confirmations/hooks/alerts/transactions/useInsufficientBalanceAlerts.ts

+    amount: totalValue,
+    gasTotal: multiplyHexes(
+      hexMaximumTransactionFee as Hex,
+      decimalToHex(batchTransactionCount + 1) as Hex,


As these are EIP-7702 batches, there is only one transaction so one gas fee, so no need to multiply.

oh I see, let me fix this

PR is updated

metamaskbot · 2025-04-03T13:34:37Z

Builds ready [3f667b1]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

UI Startup Metrics (1261 ± 65 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1261	1146	1477	65	1309	1372
			load	1105	988	1331	63	1149	1292
			domContentLoaded	1099	981	1326	63	1143	1326
			domInteractive	17	13	38	5	16	29
			firstPaint	868	75	1336	403	172	287
			backgroundConnect	10	7	65	6	9	10
			firstReactRender	19	15	43	5	20	35
			getState	12	4	32	7	6	9
			initialActions	0	0	1	0	0	1
			loadScripts	844	730	1059	62	875	928
			setupStore	8	5	23	3	7	8
	Webpack	Home	uiStartup	2054	1675	2575	230	2194	2481
			load	1598	1303	1983	177	1719	1917
			domContentLoaded	1593	1300	1970	175	1716	1911
			domInteractive	17	12	69	12	14	52
			firstPaint	205	75	1719	166	250	77
			backgroundConnect	26	12	95	17	28	70
			firstReactRender	165	54	351	110	87	95
			getState	11	3	238	23	8	9
			initialActions	5	1	283	28	3	4
			loadScripts	1585	1297	1944	171	1710	1885
			setupStore	29	7	298	59	23	9
Firefox	Browserify	Home	uiStartup	1375	1192	2054	180	1381	1906
			load	1241	1078	1886	172	1251	1703
			domContentLoaded	1240	1078	1885	172	1251	1703
			domInteractive	109	45	180	25	88	98
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	25	16	150	18	24	33
			firstReactRender	21	19	29	2	21	26
			getState	6	4	17	2	7	8
			initialActions	0	0	2	0	0	1
			loadScripts	1217	1061	1866	169	1231	1672
			setupStore	6	4	20	2	6	7
	Webpack	Home	uiStartup	1526	1309	2038	162	1562	1949
			load	1321	1133	1808	149	1371	1711
			domContentLoaded	1320	1132	1808	149	1371	1711
			domInteractive	97	38	329	33	89	94
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	25	17	46	5	27	37
			firstReactRender	35	27	60	6	39	47
			getState	8	4	37	6	7	9
			initialActions	0	0	4	1	1	1
			loadScripts	1298	1114	1785	149	1348	1684
			setupStore	8	5	28	3	7	9

Bundle size diffs [🚀 Bundle size reduced!]

background: -472 Bytes (-0.01%)
ui: -1.92 KiB (-0.03%)
common: -580 Bytes (-0.01%)

mustafacryptolife

2+

For batch transactions sum total of gas needed for all transactions i…

c4bdea2

…n the batched should be check to show insufficient funds error

jpuri added the team-confirmations Push issues to confirmations team label Apr 3, 2025

jpuri requested a review from a team as a code owner April 3, 2025 09:50

pedronfigueiredo previously approved these changes Apr 3, 2025

View reviewed changes

matthewwalsh0 requested changes Apr 3, 2025

View reviewed changes

update

3f667b1

jpuri dismissed pedronfigueiredo’s stale review via 3f667b1 April 3, 2025 12:58

jpuri requested review from matthewwalsh0 and pedronfigueiredo April 3, 2025 12:59

pedronfigueiredo approved these changes Apr 3, 2025

View reviewed changes

matthewwalsh0 approved these changes Apr 3, 2025

View reviewed changes

jpuri added this pull request to the merge queue Apr 3, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 3, 2025

mustafacryptolife reviewed Apr 3, 2025

View reviewed changes

jpuri added this pull request to the merge queue Apr 3, 2025

Merged via the queue into main with commit 996034d Apr 3, 2025
164 checks passed

jpuri deleted the fnds_alert_fix branch April 3, 2025 15:22

github-actions bot locked and limited conversation to collaborators Apr 3, 2025

metamaskbot added the release-12.17.0 Issue or pull request that will be included in release 12.17.0 label Apr 3, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: For batch transactions sum total of gas needed for all transactions in the batched should be check to show insufficient funds error #31555

fix: For batch transactions sum total of gas needed for all transactions in the batched should be check to show insufficient funds error #31555

jpuri commented Apr 3, 2025

github-actions bot commented Apr 3, 2025

metamaskbot commented Apr 3, 2025

metamaskbot commented Apr 3, 2025

matthewwalsh0 Apr 3, 2025

jpuri Apr 3, 2025

jpuri Apr 3, 2025

metamaskbot commented Apr 3, 2025

mustafacryptolife left a comment

fix: For batch transactions sum total of gas needed for all transactions in the batched should be check to show insufficient funds error #31555

fix: For batch transactions sum total of gas needed for all transactions in the batched should be check to show insufficient funds error #31555

Conversation

jpuri commented Apr 3, 2025

Description

Related issues

Manual testing steps

Screenshots/Recordings

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Apr 3, 2025

metamaskbot commented Apr 3, 2025

✨ Files requiring CODEOWNER review ✨

metamaskbot commented Apr 3, 2025

matthewwalsh0 Apr 3, 2025

Choose a reason for hiding this comment

jpuri Apr 3, 2025

Choose a reason for hiding this comment

jpuri Apr 3, 2025

Choose a reason for hiding this comment

metamaskbot commented Apr 3, 2025

mustafacryptolife left a comment

Choose a reason for hiding this comment