fix: workaround for first party snap account name suggestion #31542
+49
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
✨ Files requiring CODEOWNER review ✨✅ @MetaMask/confirmations
🖥️ @MetaMask/wallet-ux
|
Builds ready [076bf65]
UI Startup Metrics (1165 ± 64 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [3c470fc]
UI Startup Metrics (1191 ± 63 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
OGPoyraz
previously approved these changes
Apr 3, 2025
Builds ready [53eeaff]
UI Startup Metrics (1193 ± 54 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
ccharly
reviewed
Apr 3, 2025
Comment on lines
74
to
93
| const removeParenthesesAndCapitalizeWordInParentheses = ( | ||
| text: string, | ||
| ): string => { | ||
| const match = text.match(/\((.*?)\)/u); | ||
| if (!match) { | ||
| return text; | ||
| } | ||
| const word = match[1]; | ||
| return word.charAt(0).toUpperCase() + word.slice(1); | ||
| }; | ||
|
|
||
| const networkNickname = MULTICHAIN_NETWORK_TO_NICKNAME[chainId] ?? ''; | ||
| const firstPartyAccountName = | ||
| removeParenthesesAndCapitalizeWordInParentheses(networkNickname); | ||
|
|
||
| switch (clientType) { | ||
| case WalletClientType.Bitcoin: | ||
| case WalletClientType.Solana: { | ||
| return `${firstPartyAccountName} Account ${accountNumber}`; | ||
| } |
There was a problem hiding this comment.
Given that it's temporary, we could maybe use a simpler solution like:
Suggested change
| const removeParenthesesAndCapitalizeWordInParentheses = ( | |
| text: string, | |
| ): string => { | |
| const match = text.match(/\((.*?)\)/u); | |
| if (!match) { | |
| return text; | |
| } | |
| const word = match[1]; | |
| return word.charAt(0).toUpperCase() + word.slice(1); | |
| }; | |
| const networkNickname = MULTICHAIN_NETWORK_TO_NICKNAME[chainId] ?? ''; | |
| const firstPartyAccountName = | |
| removeParenthesesAndCapitalizeWordInParentheses(networkNickname); | |
| switch (clientType) { | |
| case WalletClientType.Bitcoin: | |
| case WalletClientType.Solana: { | |
| return `${firstPartyAccountName} Account ${accountNumber}`; | |
| } | |
| switch (clientType) { | |
| case WalletClientType.Bitcoin: | |
| return `Bitcoin Account ${accountNumber}`; | |
| case WalletClientType.Solana: { | |
| return `Solana Account ${accountNumber}`; | |
| } |
And yes, this does not work for testnets, but we don't support them for now, and we can always extend the logic a bit like:
switch (clientType) {
case WalletClientType.Bitcoin: {
if (chainId === MultichainNetworks.BITCOIN_TESTNET) {
return `Bitcoin Testnet Account ${accountNumber}`;
}
return `Bitcoin Account ${accountNumber}`;
}
...
}WDYT?
ccharly
reviewed
Apr 3, 2025
ui/components/multichain/create-snap-account/create-snap-account.tsx
Outdated
Show resolved
Hide resolved
…nt.tsx Co-authored-by: Charly Chevalier <[email protected]>
OGPoyraz
previously approved these changes
Apr 3, 2025
Builds ready [9f33348]
UI Startup Metrics (1223 ± 68 ms)
Bundle size diffs
|
OGPoyraz
approved these changes
Apr 4, 2025
ccharly
approved these changes
Apr 4, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
metamaskbot
added
the
release-12.17.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR temporarily changes the default suggested name of a first party snap account to reflect the network.
Related issues
Fixes:
Manual testing steps
Solana Account 1Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist