Skip to content

fix(swap/bridge): move to activity tab before transaction #31505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 10, 2025

Conversation

aganglada
Copy link
Contributor

@aganglada aganglada commented Apr 2, 2025

Description

Fixes: Move to activity tab before submitting a non-evm transaction.

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Start from token list tab
  2. Go to swap
  3. Choose a pair
  4. Click on Submit
  5. Cancel the transaction on the confirmation page
  6. You should now be in activity

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@aganglada aganglada self-assigned this Apr 2, 2025
@aganglada aganglada requested a review from a team as a code owner April 2, 2025 07:58
Copy link
Contributor

github-actions bot commented Apr 2, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

✨ Files requiring CODEOWNER review ✨

🔄 @MetaMask/swaps-engineers

  • ui/pages/bridge/hooks/useHandleTx.ts

@metamaskbot
Copy link
Collaborator

Builds ready [00114bf]
UI Startup Metrics (1240 ± 66 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1240110314216612811362
load10799601270641138984
domContentLoaded10729401264641161990
domInteractive18144751729
firstPaint7811381270417214980
backgroundConnect116568910
firstReactRender21155672139
getState11537879
initialActions003001
loadScripts853733105163889975
setupStore8524378
WebpackHomeuiStartup21501735272423423022572
load16811340218319318101992
domContentLoaded16731336217819018031981
domInteractive181269121455
firstPaint190684166424971
backgroundConnect3214266303063
firstReactRender188543591138595
getState1232622689
initialActions315134
loadScripts16631333205818217911955
setupStore296284592588
FirefoxBrowserifyHomeuiStartup13691162183614213901799
load12341044168113512671637
domContentLoaded12341043168113512671637
domInteractive9839193269098
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect22165362431
firstReactRender22196952328
getState7337478
initialActions001001
loadScripts12131029166113212471599
setupStore6413267
WebpackHomeuiStartup15421368222418215881964
load13261178200915613421687
domContentLoaded13251177200915613421687
domInteractive9439168238996
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect26185772644
firstReactRender35285863847
getState8433589
initialActions002111
loadScripts13021155198315413201659
setupStore8550678
Bundle size diffs
  • background: 0 Bytes (0%)
  • ui: 55 Bytes (0%)
  • common: 0 Bytes (0%)

@chaoticgoodpanda
Copy link

@GustavoRSSilva @ghgoodreau pls review this PR

@aganglada aganglada added the team-solana PRs from the Solana snap team label Apr 3, 2025
@GustavoRSSilva GustavoRSSilva added the team-swaps-and-bridge For issues with Swaps or Bridging label Apr 3, 2025
@aganglada aganglada enabled auto-merge April 10, 2025 10:09
@aganglada aganglada added this pull request to the merge queue Apr 10, 2025
@aganglada aganglada removed this pull request from the merge queue due to a manual request Apr 10, 2025
@aganglada aganglada enabled auto-merge April 10, 2025 10:35
@aganglada aganglada added this pull request to the merge queue Apr 10, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [b362312]
UI Startup Metrics (1243 ± 55 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1243114813745512831342
load109198312125411381206
domContentLoaded10859791205531136994
domInteractive18146071729
firstPaint7371301208432211279
backgroundConnect7411279
firstReactRender18153331924
getState13529679
initialActions001000
loadScripts83973297252879917
setupStore8523278
WebpackHomeuiStartup21861708257918022982449
load17251326218914317752012
domContentLoaded17181323218514117721984
domInteractive161258101445
firstPaint163633366225481
backgroundConnect369254463985
firstReactRender168523651105685
getState1542812869
initialActions319146
loadScripts17131321218313917701954
setupStore2963435668
FirefoxBrowserifyHomeuiStartup13371157197512913761620
load11971033180912912471492
domContentLoaded11971033180912912461492
domInteractive10439285388695
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect201293112047
firstReactRender22184952234
getState7336578
initialActions002001
loadScripts11781017179513012331476
setupStore6434467
WebpackHomeuiStartup15301387204913215941853
load13171169178611613761545
domContentLoaded13171168178611613761545
domInteractive9459177228893
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2315104102436
firstReactRender36286663848
getState9432589
initialActions002111
loadScripts12971147176311513401521
setupStore8540479

auto-merge was automatically disabled April 10, 2025 11:17

Pull Request is not mergeable

Merged via the queue into main with commit 8c177b8 Apr 10, 2025
166 checks passed
@aganglada aganglada deleted the fix/move-to-activity-before-tx branch April 10, 2025 11:42
@github-actions github-actions bot locked and limited conversation to collaborators Apr 10, 2025
@metamaskbot metamaskbot added the release-12.17.0 Issue or pull request that will be included in release 12.17.0 label Apr 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.17.0 Issue or pull request that will be included in release 12.17.0 team-solana PRs from the Solana snap team team-swaps-and-bridge For issues with Swaps or Bridging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants