test: removing some entries from live request allowlist by adding missing mocks #31504

seaona · 2025-04-02T07:37:35Z

Description

Removing some entries from the live server allow list from our e2e, and adding their corresponding global mocks.

Related issues

Fixes:

Manual testing steps

All specs should continue to work normally

Screenshots/Recordings

n/a

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2025-04-02T07:37:47Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2025-04-02T07:39:59Z

✨ Files requiring CODEOWNER review ✨

👨‍🔧 @MetaMask/extension-platform

test/e2e/mock-e2e-allowlist.js

metamaskbot · 2025-04-02T08:29:01Z

Builds ready [3262d48]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

UI Startup Metrics (1164 ± 63 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1164	1052	1381	63	1211	1277
			load	1021	926	1206	62	957	995
			domContentLoaded	1015	921	1198	61	967	995
			domInteractive	16	12	46	6	15	33
			firstPaint	789	77	1203	378	79	987
			backgroundConnect	10	6	54	7	9	9
			firstReactRender	18	15	39	4	19	27
			getState	10	4	31	6	6	8
			initialActions	0	0	1	0	0	1
			loadScripts	806	700	974	60	858	916
			setupStore	7	5	16	2	7	8
	Webpack	Home	uiStartup	2140	1746	2652	166	2233	2362
			load	1667	1353	2083	144	1762	1909
			domContentLoaded	1660	1350	2077	144	1757	1900
			domInteractive	16	12	66	10	14	45
			firstPaint	224	80	1800	170	242	415
			backgroundConnect	27	13	86	13	30	61
			firstReactRender	205	53	373	119	84	96
			getState	9	3	24	4	8	9
			initialActions	5	1	264	26	3	4
			loadScripts	1652	1346	2054	143	1747	1890
			setupStore	18	6	244	28	21	9
Firefox	Browserify	Home	uiStartup	1394	1186	1902	142	1437	1735
			load	1253	1065	1728	138	1294	1573
			domContentLoaded	1252	1065	1728	138	1294	1573
			domInteractive	99	37	182	29	87	96
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	26	17	118	16	25	43
			firstReactRender	23	19	50	4	25	27
			getState	6	4	12	1	7	8
			initialActions	0	0	1	0	0	1
			loadScripts	1227	1049	1694	137	1274	1543
			setupStore	6	4	17	2	6	7
	Webpack	Home	uiStartup	1522	1332	2079	154	1576	1890
			load	1316	1152	1808	142	1370	1643
			domContentLoaded	1315	1152	1807	142	1370	1643
			domInteractive	94	37	172	24	89	95
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	23	18	47	5	25	31
			firstReactRender	34	28	44	4	35	42
			getState	8	4	30	5	8	9
			initialActions	1	0	2	1	1	1
			loadScripts	1294	1133	1781	142	1348	1625
			setupStore	7	5	27	2	8	9

Bundle size diffs

background: 0 Bytes (0%)
ui: 0 Bytes (0%)
common: 0 Bytes (0%)

seaona · 2025-04-02T14:41:58Z

test/e2e/mock-e2e-allowlist.js

-  'https://www.4byte.directory/api/v1/signatures/?hex_signature=0x39509351',
-  'https://www.4byte.directory/api/v1/signatures/?hex_signature=0x5f575529',
-  'https://www.4byte.directory/api/v1/signatures/?hex_signature=0x60806040',
-  'https://www.4byte.directory/api/v1/signatures/?hex_signature=0xd0e30db0',


ℹ️ removed because we already have a mock for any signature in the mock-e2e file

seaona · 2025-04-02T14:42:42Z

test/e2e/mock-e2e-allowlist.js

-  'https://static.cx.metamask.io/api/v1/tokenIcons/1337/0xa0b86991c6218b36c1d19d4a2e9eb0ce3606eb48.png',
-  'https://static.cx.metamask.io/api/v1/tokenIcons/1337/0xc6bdb96e29c38dc43f014eed44de4106a6a8eb5f.png',
-  'https://static.cx.metamask.io/api/v1/tokenIcons/56/0x0d8775f648430679a709e98d2b0cb6250d2887ef.png',
-  'https://static.cx.metamask.io/api/v1/tokenIcons/56/0x6b175474e89094c44da98b954eedeac495271d0f.png',


ℹ️ 1 mock added for all the tokenIcons entries which returns a 200

seaona · 2025-04-02T14:43:23Z

test/e2e/mock-e2e-allowlist.js

-  'https://on-ramp.api.cx.metamask.io/eligibility/mm-card?id=0x01a92b9df8ce522a8f98161a97378bfdb2cce64f2d4293657e7eefe818d9ffbc',
-  'https://on-ramp.api.cx.metamask.io/eligibility/mm-card?id=0xb1b1aa3036452bf32c1159266d1886279e4890ba907ed275e39fbc56906a8be2',
-  'https://on-ramp.api.cx.metamask.io/eligibility/mm-card?id=7ea301c0-6a98-11ef-a19e-f3acaa606eca',
-  'https://on-ramp.api.cx.metamask.io/eligibility/mm-card?id=8af26790-6a98-11ef-bee7-5553e37c0097',


ℹ️ 1 mock added for all the eligibility requests, no matter which id used

hjetpoluru

LGTM

racitores · 2025-04-03T07:26:33Z

test/e2e/mock-response-data/bridge-get-all-feature-flags.json

+    "59144": 1
+  },
+  "blocked-wallets": [
+    "0x106311b0651fd123d02B4c999CCA810712bb347B",


Do we actually need this huge list of addresses for a mock in a test?

it's a good point, possibly not. This data matches the exact real response we have now, so we get the closest to the prod environment, but happy to reduce it to a minimal data set, and it can always be expanded in the future, if needed. wdyt?

I've reduced it to a minimal data set. Let's see if something breaks or if we can go on with this version

okay some specs failed, so I had to add the required entries in the networks metadata. Now everything seems to work with the current data. There was 1 flaky test, but it seems unrelated to the changes (you can see older instances of this error in ci). I've run all jobs one more time and things are green.

I've set up another branch just to be sure, and run x5 that specific test and I could also see it failing intermittently with the same error:

https://github.com/MetaMask/metamask-extension/actions/runs/14240914690/job/39911085234?pr=31556

it seems to me some miss-configuration with the injected fixtures data, it can be tackled on a separate PR

test/e2e/mock-response-data/accounts-api-tokens.json

test/e2e/mock-response-data/client-side-detection-blocklist.json

racitores

LGTM!

metamaskbot · 2025-04-03T10:53:34Z

Builds ready [47e15fe]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

UI Startup Metrics (1192 ± 60 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1192	1062	1436	60	1225	1283
			load	1046	931	1259	55	1121	971
			domContentLoaded	1040	926	1249	56	1121	967
			domInteractive	16	13	32	4	16	28
			firstPaint	760	129	1142	398	231	971
			backgroundConnect	10	6	36	5	8	10
			firstReactRender	20	14	44	6	19	34
			getState	11	4	31	6	6	9
			initialActions	0	0	1	0	0	1
			loadScripts	826	718	1038	56	864	905
			setupStore	7	5	13	2	7	8
	Webpack	Home	uiStartup	2194	1710	2490	192	2349	2429
			load	1708	1253	2105	170	1831	1961
			domContentLoaded	1701	1248	2101	170	1824	1951
			domInteractive	17	13	100	11	15	28
			firstPaint	183	67	1532	150	245	78
			backgroundConnect	33	11	255	27	38	65
			firstReactRender	181	54	352	110	61	94
			getState	14	3	413	40	7	9
			initialActions	6	1	265	26	4	6
			loadScripts	1689	1242	1994	165	1815	1936
			setupStore	37	6	279	61	272	8
Firefox	Browserify	Home	uiStartup	1391	1170	2007	166	1442	1792
			load	1247	1046	1857	161	1306	1634
			domContentLoaded	1247	1046	1857	161	1306	1634
			domInteractive	100	42	192	26	88	97
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	24	16	52	8	24	49
			firstReactRender	22	19	29	2	22	27
			getState	7	4	27	3	7	8
			initialActions	0	0	1	0	0	1
			loadScripts	1225	1030	1835	161	1284	1606
			setupStore	6	4	19	3	6	7
	Webpack	Home	uiStartup	1477	1274	2040	143	1533	1812
			load	1277	1098	1788	130	1321	1563
			domContentLoaded	1277	1098	1787	130	1321	1563
			domInteractive	90	36	158	24	91	97
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	24	17	130	12	24	32
			firstReactRender	33	27	44	4	35	41
			getState	7	4	29	4	7	8
			initialActions	0	0	1	0	1	1
			loadScripts	1255	1081	1696	125	1299	1541
			setupStore	8	5	32	5	7	9

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 351 Bytes (0.01%)
ui: 12.34 KiB (0.18%)
common: 63 Bytes (0%)

mocks

d127f4d

seaona requested a review from a team as a code owner April 2, 2025 07:37

metamaskbot added the team-qa QA team label Apr 2, 2025

more mocks

3262d48

seaona self-assigned this Apr 2, 2025

seaona added team-extension-platform Extension Platform team flaky tests labels Apr 2, 2025

seaona commented Apr 2, 2025

View reviewed changes

hjetpoluru previously approved these changes Apr 2, 2025

View reviewed changes

seaona mentioned this pull request Apr 2, 2025

fix: flaky test MetaMask onboarding should not prevent network requests to basic functionality endpoints when the basic functionality toggle is on #31521

Merged

7 tasks

pnarayanaswamy previously approved these changes Apr 3, 2025

View reviewed changes

seaona added this pull request to the merge queue Apr 3, 2025

racitores reviewed Apr 3, 2025

View reviewed changes

seaona removed this pull request from the merge queue due to a manual request Apr 3, 2025

racitores previously approved these changes Apr 3, 2025

View reviewed changes

remove data

3b3fb06

seaona dismissed stale reviews from racitores, pnarayanaswamy, and hjetpoluru via 3b3fb06 April 3, 2025 08:06

seaona added 2 commits April 3, 2025 10:43

add needed chains

647bd49

more data entries needed

47e15fe

racitores approved these changes Apr 3, 2025

View reviewed changes

hjetpoluru self-requested a review April 3, 2025 12:39

hjetpoluru approved these changes Apr 3, 2025

View reviewed changes

seaona added this pull request to the merge queue Apr 3, 2025

Merged via the queue into main with commit e96f851 Apr 3, 2025
165 checks passed

seaona deleted the e2e-mocks-addition-1 branch April 3, 2025 13:30

github-actions bot locked and limited conversation to collaborators Apr 3, 2025

metamaskbot added the release-12.17.0 Issue or pull request that will be included in release 12.17.0 label Apr 3, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: removing some entries from live request allowlist by adding missing mocks #31504

test: removing some entries from live request allowlist by adding missing mocks #31504

seaona commented Apr 2, 2025 •

edited

Loading

github-actions bot commented Apr 2, 2025

metamaskbot commented Apr 2, 2025

metamaskbot commented Apr 2, 2025

seaona Apr 2, 2025

seaona Apr 2, 2025

seaona Apr 2, 2025

hjetpoluru left a comment

racitores Apr 3, 2025

seaona Apr 3, 2025

seaona Apr 3, 2025

seaona Apr 3, 2025 •

edited

Loading

racitores left a comment

metamaskbot commented Apr 3, 2025

test: removing some entries from live request allowlist by adding missing mocks #31504

test: removing some entries from live request allowlist by adding missing mocks #31504

Conversation

seaona commented Apr 2, 2025 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Apr 2, 2025

metamaskbot commented Apr 2, 2025

✨ Files requiring CODEOWNER review ✨

metamaskbot commented Apr 2, 2025

seaona Apr 2, 2025

Choose a reason for hiding this comment

seaona Apr 2, 2025

Choose a reason for hiding this comment

seaona Apr 2, 2025

Choose a reason for hiding this comment

hjetpoluru left a comment

Choose a reason for hiding this comment

racitores Apr 3, 2025

Choose a reason for hiding this comment

seaona Apr 3, 2025

Choose a reason for hiding this comment

seaona Apr 3, 2025

Choose a reason for hiding this comment

seaona Apr 3, 2025 • edited Loading

Choose a reason for hiding this comment

racitores left a comment

Choose a reason for hiding this comment

metamaskbot commented Apr 3, 2025

seaona commented Apr 2, 2025 •

edited

Loading

seaona Apr 3, 2025 •

edited

Loading