Skip to content

fix: should not show NonContractAddressAlert for auth request #31503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 3, 2025

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Apr 2, 2025

Description

Fix the issue that currently we're showing the "Potential mistake" warning of sending call data for the batch transaction since the user is sending call data to themselves to enable.

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/4522

Manual testing steps

  1. Go to test dapp
  2. Submit EIP-5792 Send Call for first time
  3. Ensure that "Potential mistake" alert is not visible

Screenshots/Recordings

Screenshot 2025-04-02 at 11 37 57 AM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jpuri jpuri added the team-confirmations Push issues to confirmations team label Apr 2, 2025
@jpuri jpuri requested a review from a team as a code owner April 2, 2025 06:10
Copy link
Contributor

github-actions bot commented Apr 2, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

✨ Files requiring CODEOWNER review ✨

✅ @MetaMask/confirmations

  • ui/pages/confirmations/hooks/alerts/transactions/useNonContractAddressAlerts.test.ts
  • ui/pages/confirmations/hooks/alerts/transactions/useNonContractAddressAlerts.ts

@metamaskbot
Copy link
Collaborator

Builds ready [922286a]
UI Startup Metrics (1196 ± 67 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1196106614576712311309
load10449501208581208989
domContentLoaded1039945120457946988
domInteractive17134461630
firstPaint8261301186365264985
backgroundConnect107435910
firstReactRender20154562036
getState10427768
initialActions001001
loadScripts82471597957856944
setupStore8518278
WebpackHomeuiStartup20991675258321522172478
load16261312199416717321950
domContentLoaded16191309198716617251922
domInteractive171266111456
firstPaint203664027025270
backgroundConnect261078142866
firstReactRender194633551178797
getState8320389
initialActions314133
loadScripts16111305196516317201897
setupStore23726949198
FirefoxBrowserifyHomeuiStartup13341132194913113671616
load11991012179212412451465
domContentLoaded11981012179112412451465
domInteractive10543246328895
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect23177172337
firstReactRender22195452332
getState6326378
initialActions002001
loadScripts1177996175412312291468
setupStore6413267
WebpackHomeuiStartup15601360214817815912068
load13531176191716613871802
domContentLoaded13531176191716613861802
domInteractive10039172279297
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect25195062643
firstReactRender35295963648
getState8432589
initialActions102111
loadScripts13301153189216613661775
setupStore7520289
Bundle size diffs
  • background: 0 Bytes (0%)
  • ui: 178 Bytes (0%)
  • common: 0 Bytes (0%)

@jpuri jpuri requested a review from matthewwalsh0 April 2, 2025 10:43
@jpuri jpuri enabled auto-merge April 2, 2025 10:49
@metamaskbot
Copy link
Collaborator

Builds ready [5c80708]
UI Startup Metrics (1210 ± 62 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1210107013876212451327
load10559461210591159979
domContentLoaded10499411198591171976
domInteractive16133751630
firstPaint7981491209392250970
backgroundConnect106657910
firstReactRender21144872037
getState11432768
initialActions001001
loadScripts83572699259867954
setupStore8521378
WebpackHomeuiStartup21201700260221822562537
load16531322200017617681962
domContentLoaded16461319198817517651951
domInteractive171281121456
firstPaint21366138813725674
backgroundConnect291584163271
firstReactRender182543611098897
getState9324489
initialActions512672634
loadScripts16381316197817217611924
setupStore26729251208
FirefoxBrowserifyHomeuiStartup13521189180413713901751
load12151068164412912661545
domContentLoaded12151068164412912651544
domInteractive9940194248897
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2316106122331
firstReactRender23196062432
getState7440578
initialActions001001
loadScripts11921042161812712381509
setupStore6418267
WebpackHomeuiStartup15601354205115216341915
load13451180181414014031677
domContentLoaded13451180181414014031676
domInteractive9841283318896
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect26185262842
firstReactRender36285763851
getState8432689
initialActions001011
loadScripts13221162179213913831648
setupStore8529489
Bundle size diffs
  • background: 0 Bytes (0%)
  • ui: 243 Bytes (0%)
  • common: 0 Bytes (0%)

@jpuri jpuri added this pull request to the merge queue Apr 3, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 3, 2025
@jpuri jpuri added this pull request to the merge queue Apr 3, 2025
Merged via the queue into main with commit 80dde72 Apr 3, 2025
163 of 164 checks passed
@jpuri jpuri deleted the auth_alert_fix branch April 3, 2025 12:10
@github-actions github-actions bot locked and limited conversation to collaborators Apr 3, 2025
@metamaskbot metamaskbot added the release-12.17.0 Issue or pull request that will be included in release 12.17.0 label Apr 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.17.0 Issue or pull request that will be included in release 12.17.0 team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants