-
Notifications
You must be signed in to change notification settings - Fork 5.2k
fix: should not show NonContractAddressAlert for auth request #31503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+52
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
✨ Files requiring CODEOWNER review ✨✅ @MetaMask/confirmations
|
Builds ready [922286a]
UI Startup Metrics (1196 ± 67 ms)
Bundle size diffs
|
matthewwalsh0
requested changes
Apr 2, 2025
ui/pages/confirmations/hooks/alerts/transactions/useNonContractAddressAlerts.ts
Show resolved
Hide resolved
ui/pages/confirmations/hooks/alerts/transactions/useNonContractAddressAlerts.test.ts
Show resolved
Hide resolved
matthewwalsh0
approved these changes
Apr 2, 2025
Builds ready [5c80708]
UI Startup Metrics (1210 ± 62 ms)
Bundle size diffs
|
pedronfigueiredo
approved these changes
Apr 3, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
release-12.17.0
Issue or pull request that will be included in release 12.17.0
team-confirmations
Push issues to confirmations team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix the issue that currently we're showing the "Potential mistake" warning of sending call data for the batch transaction since the user is sending call data to themselves to enable.
Related issues
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/4522
Manual testing steps
Screenshots/Recordings
Pre-merge author checklist
Pre-merge reviewer checklist