Skip to content

feat: (MMS-2106) supports copying block explorer link in bridge page #31498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 7, 2025

Conversation

ghgoodreau
Copy link
Contributor

@ghgoodreau ghgoodreau commented Apr 1, 2025

Description

Adds support for copying the token block explorer link in the address text under the token icon of the bridge page. Also displays a toast to let the user know this link has been copied.

Open in GitHub Codespaces

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/MMS-2106

Manual testing steps

  1. Go to the bridge page.
  2. Select a toToken that is not a native token.
  3. Click the address under the token icon.
  4. Observe the toast and verify the link is correct.

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

github-actions bot commented Apr 1, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-swaps-and-bridge For issues with Swaps or Bridging label Apr 1, 2025
@metamaskbot
Copy link
Collaborator

metamaskbot commented Apr 1, 2025

✨ Files requiring CODEOWNER review ✨

🔄 @MetaMask/swaps-engineers

  • ui/pages/bridge/__snapshots__/index.test.tsx.snap
  • ui/pages/bridge/prepare/__snapshots__/prepare-bridge-page.test.tsx.snap
  • ui/pages/bridge/prepare/bridge-input-group.tsx
  • ui/pages/bridge/prepare/prepare-bridge-page.tsx

@metamaskbot
Copy link
Collaborator

Builds ready [396710f]
UI Startup Metrics (1189 ± 73 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1189106014797312231334
load1039932134571943989
domContentLoaded1033923133771942986
domInteractive16133141626
firstPaint751711343399264977
backgroundConnect106506910
firstReactRender19153442031
getState10427668
initialActions001001
loadScripts822700112471838959
setupStore7521378
WebpackHomeuiStartup977680117684957983
load82551694380884923
domContentLoaded81949394081880919
domInteractive15113661335
firstPaint33354936311814936
backgroundConnect17135381739
firstReactRender16123041625
getState5320356
initialActions001000
loadScripts81749193881879918
setupStore7414289
FirefoxBrowserifyHomeuiStartup13761181193315114291784
load12391054179014812971610
domContentLoaded12381054178914812961610
domInteractive10038220309095
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect25175682751
firstReactRender22193832326
getState6313278
initialActions001001
loadScripts12151036176614712801584
setupStore6442467
WebpackHomeuiStartup10128571466146915969
load8837541271128822959
domContentLoaded8827541270128822959
domInteractive113342062815195
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect231484132464
firstReactRender19162722025
getState9572989
initialActions001001
loadScripts8657391238124812980
setupStore9565989
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0%)
  • ui: 1.76 KiB (0.03%)
  • common: 70 Bytes (0%)

@ghgoodreau ghgoodreau marked this pull request as ready for review April 2, 2025 15:32
@ghgoodreau ghgoodreau requested a review from a team as a code owner April 2, 2025 15:32
GustavoRSSilva
GustavoRSSilva previously approved these changes Apr 2, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [73f421e]
UI Startup Metrics (1191 ± 63 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1191109515006312171303
load1040904136369913993
domContentLoaded1034898135769908988
domInteractive16134751528
firstPaint813861362379225964
backgroundConnect97263910
firstReactRender221561102149
getState10433668
initialActions001001
loadScripts786658108868816879
setupStore9436579
WebpackHomeuiStartup21031709264219322452324
load16331330199114117341821
domContentLoaded16271327196914017291815
domInteractive171267121458
firstPaint171674927024685
backgroundConnect301184153662
firstReactRender176533561127594
getState1333012989
initialActions612872844
loadScripts16181324194313917231798
setupStore446378822968
FirefoxBrowserifyHomeuiStartup13791187192515414181791
load12361052177814512841625
domContentLoaded12361051177714512841625
domInteractive9938204278697
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect24164962535
firstReactRender22193232328
getState7325378
initialActions001001
loadScripts12141030174914312571596
setupStore6420267
WebpackHomeuiStartup15011299205916215481935
load13021130183615213421692
domContentLoaded13021130183615213421692
domInteractive9537240328997
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect24184762443
firstReactRender33294943540
getState6324378
initialActions102111
loadScripts12811112181315113211673
setupStore7523279
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0%)
  • ui: 2.59 KiB (0.04%)
  • common: 70 Bytes (0%)

@metamaskbot
Copy link
Collaborator

Builds ready [58f4d66]
UI Startup Metrics (1243 ± 82 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1243110415908213001385
load10929661443781180987
domContentLoaded10869601436781191994
domInteractive18137091630
firstPaint748851280437207970
backgroundConnect106476910
firstReactRender21157582040
getState10427668
initialActions001001
loadScripts831706101968870943
setupStore8521378
WebpackHomeuiStartup20591665246820022052302
load16091306190015517341818
domContentLoaded16031300187115417291814
domInteractive171263111451
firstPaint171653425824082
backgroundConnect271181142959
firstReactRender160533441058495
getState1132572589
initialActions315134
loadScripts15951295184515417211809
setupStore23630545258
FirefoxBrowserifyHomeuiStartup13451168195215313711789
load12071049180814512301630
domContentLoaded12071049180814512301629
domInteractive9837191238897
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2616279262534
firstReactRender22184942229
getState6327378
initialActions001001
loadScripts11821031177713912101599
setupStore6318267
WebpackHomeuiStartup15781365216316916552031
load13601176197416214101777
domContentLoaded13601175197416214091777
domInteractive9737177249297
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect25186672643
firstReactRender36305563950
getState8532479
initialActions102111
loadScripts13371154195016113811749
setupStore8549589
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 1.51 KiB (0.03%)
  • ui: 3.23 KiB (0.05%)
  • common: 285 Bytes (0%)

@ghgoodreau ghgoodreau enabled auto-merge April 7, 2025 18:09
@ghgoodreau ghgoodreau added this pull request to the merge queue Apr 7, 2025
Merged via the queue into main with commit 405e1ea Apr 7, 2025
170 checks passed
@ghgoodreau ghgoodreau deleted the feat-MMS-2106-outlink-to-block-explorer branch April 7, 2025 22:30
@github-actions github-actions bot locked and limited conversation to collaborators Apr 7, 2025
@metamaskbot metamaskbot added the release-12.17.0 Issue or pull request that will be included in release 12.17.0 label Apr 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.17.0 Issue or pull request that will be included in release 12.17.0 team-swaps-and-bridge For issues with Swaps or Bridging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants