Skip to content

fix: hide balance alert if selected gas fee token #31497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

matthewwalsh0
Copy link
Member

@matthewwalsh0 matthewwalsh0 commented Apr 1, 2025

Description

Hide insufficient balance alert if gas fee token is selected.

Open in GitHub Codespaces

Related issues

Fixes #4532

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@matthewwalsh0 matthewwalsh0 requested a review from a team as a code owner April 1, 2025 19:00
@matthewwalsh0 matthewwalsh0 added the team-confirmations Push issues to confirmations team label Apr 1, 2025
@metamaskbot
Copy link
Collaborator

✨ Files requiring CODEOWNER review ✨

✅ @MetaMask/confirmations

  • ui/pages/confirmations/hooks/alerts/transactions/useInsufficientBalanceAlerts.test.ts
  • ui/pages/confirmations/hooks/alerts/transactions/useInsufficientBalanceAlerts.ts

@metamaskbot
Copy link
Collaborator

Builds ready [0665dc7]
UI Startup Metrics (1209 ± 64 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1209110014906412541304
load10539501322611142988
domContentLoaded10479461318601318992
domInteractive17133241730
firstPaint810811196393225975
backgroundConnect96354910
firstReactRender19144141927
getState12536868
initialActions001001
loadScripts832736107558874915
setupStore8526379
WebpackHomeuiStartup1035712128591856994
load86352999582904969
domContentLoaded85651599182899965
domInteractive16133761434
firstPaint3016096830076390
backgroundConnect19134781743
firstReactRender18133551731
getState6322456
initialActions001001
loadScripts85451398982897963
setupStore8419379
FirefoxBrowserifyHomeuiStartup13741178197916414301735
load12351060182515412901586
domContentLoaded12341060182415412901586
domInteractive10442211289097
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect241690102441
firstReactRender23197262531
getState7423278
initialActions001001
loadScripts12131045178515212661566
setupStore6435467
WebpackHomeuiStartup9547931373148873980
load8356961175131799904
domContentLoaded8346951174131799903
domInteractive11430197233098
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect19129192131
firstReactRender18164331822
getState8465789
initialActions001001
loadScripts8186831150127792955
setupStore8580878
Bundle size diffs
  • background: 0 Bytes (0%)
  • ui: 30 Bytes (0%)
  • common: 0 Bytes (0%)

@matthewwalsh0 matthewwalsh0 added this pull request to the merge queue Apr 2, 2025
Merged via the queue into main with commit 82f5b3e Apr 2, 2025
152 checks passed
@matthewwalsh0 matthewwalsh0 deleted the fix/hide-insufficient-balance-if-selected-gas-fee-token branch April 2, 2025 10:00
@github-actions github-actions bot locked and limited conversation to collaborators Apr 2, 2025
@metamaskbot metamaskbot added the release-12.17.0 Issue or pull request that will be included in release 12.17.0 label Apr 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.17.0 Issue or pull request that will be included in release 12.17.0 team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants