Skip to content

fix: Add enableTxParamsGasFeeUpdates to true in TransactionController config #31476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 1, 2025

Conversation

OGPoyraz
Copy link
Member

@OGPoyraz OGPoyraz commented Apr 1, 2025

Description

This PR aims to enable update of txParams gas updates on every GasFeeController update.

Open in GitHub Codespaces

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/4519
Might be related: #31176

Manual testing steps

N/A

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@OGPoyraz OGPoyraz requested a review from a team as a code owner April 1, 2025 10:38
@metamaskbot metamaskbot added the team-confirmations Push issues to confirmations team label Apr 1, 2025
@metamaskbot
Copy link
Collaborator

✨ Files requiring CODEOWNER review ✨

✅ @MetaMask/confirmations

  • app/scripts/controller-init/confirmations/transaction-controller-init.ts

@metamaskbot
Copy link
Collaborator

Builds ready [1cfd049]
UI Startup Metrics (1229 ± 70 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1229109914607012751351
load10719481284661175991
domContentLoaded10659411278661200991
domInteractive17133851628
firstPaint838861284394222982
backgroundConnect107656910
firstReactRender19144661934
getState11431679
initialActions001000
loadScripts846716102566882950
setupStore7415278
WebpackHomeuiStartup1010717125890928995
load843526101987887940
domContentLoaded836522101588881929
domInteractive16134371537
firstPaint32355942310747920
backgroundConnect19145381742
firstReactRender1913162151826
getState6318358
initialActions001001
loadScripts833521101388878928
setupStore8516379
FirefoxBrowserifyHomeuiStartup14391221192315614621824
load12901095177315013241655
domContentLoaded12901095177215013241654
domInteractive10441198308699
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect24175372537
firstReactRender24197062632
getState8347589
initialActions001001
loadScripts12671067174815013041637
setupStore7325368
WebpackHomeuiStartup9408041397141862985
load8267021200129803926
domContentLoaded8257021199129802925
domInteractive121802232214097
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect18124061931
firstReactRender18152721823
getState94851179
initialActions002001
loadScripts8106931175124788898
setupStore7560678
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 37 Bytes (0%)
  • ui: 608 Bytes (0.01%)
  • common: 66 Bytes (0%)

@OGPoyraz OGPoyraz added this pull request to the merge queue Apr 1, 2025
Merged via the queue into main with commit ea26a04 Apr 1, 2025
147 checks passed
@OGPoyraz OGPoyraz deleted the ogp/4519 branch April 1, 2025 20:31
@github-actions github-actions bot locked and limited conversation to collaborators Apr 1, 2025
@metamaskbot metamaskbot added the release-12.17.0 Issue or pull request that will be included in release 12.17.0 label Apr 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.17.0 Issue or pull request that will be included in release 12.17.0 team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants