fix: Update blockaid friction modal copy #31475

vinistevam · 2025-04-01T10:25:30Z

Description

This PR aims to update the friction modal copy depending on the response from the Security Alerts API.

Figma file

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/4502

Manual testing steps

Go to test dapp
Click on the Malicious Signature in the section PPOM - Malicious Transactions and Signatures
Check the Banner and confirm the friction modal should be (description) and (title)

Screenshots/Recordings

blockaid.webm

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2025-04-01T10:25:42Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2025-04-01T12:34:55Z

Builds ready [ae8a7ba]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

UI Startup Metrics (1187 ± 61 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1187	1055	1426	61	1223	1291
			load	1034	887	1201	56	949	997
			domContentLoaded	1028	881	1198	56	947	992
			domInteractive	16	13	78	7	16	26
			firstPaint	741	95	1170	400	254	993
			backgroundConnect	10	6	57	6	9	10
			firstReactRender	21	15	41	6	20	36
			getState	11	4	39	7	6	8
			initialActions	0	0	3	0	0	1
			loadScripts	813	670	963	54	841	910
			setupStore	8	5	18	2	7	8
	Webpack	Home	uiStartup	993	798	1234	81	967	991
			load	837	587	995	83	890	951
			domContentLoaded	831	580	990	83	880	947
			domInteractive	16	12	71	9	14	35
			firstPaint	305	54	959	310	815	944
			backgroundConnect	17	13	47	8	16	40
			firstReactRender	16	12	31	5	16	27
			getState	5	3	16	3	5	6
			initialActions	0	0	1	0	0	1
			loadScripts	829	570	989	84	879	940
			setupStore	7	4	16	2	7	9
Firefox	Browserify	Home	uiStartup	1349	1159	1805	136	1383	1707
			load	1217	1046	1666	130	1257	1543
			domContentLoaded	1216	1046	1666	130	1257	1542
			domInteractive	97	42	185	25	91	96
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	22	17	52	7	23	36
			firstReactRender	21	18	32	3	22	26
			getState	6	4	21	3	7	8
			initialActions	0	0	1	0	0	1
			loadScripts	1196	1029	1646	129	1236	1517
			setupStore	6	3	14	2	5	7
	Webpack	Home	uiStartup	964	801	1439	170	866	971
			load	845	701	1259	156	784	899
			domContentLoaded	845	701	1259	156	784	898
			domInteractive	115	55	171	20	171	98
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	20	12	83	12	22	32
			firstReactRender	18	16	25	2	19	23
			getState	8	4	67	7	7	9
			initialActions	0	0	1	0	0	1
			loadScripts	829	688	1234	151	771	880
			setupStore	8	5	82	9	7	8

Bundle size diffs [🚀 Bundle size reduced!]

background: 0 Bytes (0%)
ui: -25 Bytes (0%)
common: -120 Bytes (0%)

metamaskbot · 2025-04-07T12:42:50Z

Builds ready [d78c3dc]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1227 ± 70 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1227	1112	1436	70	1273	1352
			load	1078	952	1282	69	1142	989
			domContentLoaded	1071	935	1276	70	1184	995
			domInteractive	17	13	69	8	16	30
			firstPaint	828	146	1278	395	215	993
			backgroundConnect	10	7	32	5	9	10
			firstReactRender	20	15	90	8	20	31
			getState	12	4	51	8	6	9
			initialActions	0	0	1	0	0	0
			loadScripts	819	677	1032	69	848	931
			setupStore	7	4	17	2	7	8
	Webpack	Home	uiStartup	2064	1662	2347	190	2210	2298
			load	1608	1304	2034	148	1718	1818
			domContentLoaded	1602	1301	2031	148	1714	1810
			domInteractive	17	12	63	11	14	51
			firstPaint	156	63	343	55	240	78
			backgroundConnect	31	11	338	34	33	61
			firstReactRender	171	53	353	103	80	95
			getState	9	4	40	5	8	9
			initialActions	3	1	5	1	3	4
			loadScripts	1590	1298	2028	146	1700	1801
			setupStore	32	6	302	64	24	7
Firefox	Browserify	Home	uiStartup	1355	1146	1843	142	1388	1696
			load	1219	1028	1686	134	1257	1540
			domContentLoaded	1219	1028	1686	134	1257	1540
			domInteractive	101	37	211	31	90	98
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	24	16	66	8	25	46
			firstReactRender	23	19	54	5	24	28
			getState	6	4	10	1	7	8
			initialActions	0	0	1	0	0	1
			loadScripts	1197	1010	1653	132	1240	1517
			setupStore	6	3	11	1	6	7
	Webpack	Home	uiStartup	1572	1365	2092	161	1645	1984
			load	1352	1181	1882	155	1417	1761
			domContentLoaded	1352	1180	1882	155	1416	1761
			domInteractive	100	41	448	41	91	99
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	26	19	50	6	28	41
			firstReactRender	38	29	58	6	43	53
			getState	8	4	32	5	8	9
			initialActions	1	0	1	0	1	1
			loadScripts	1328	1162	1859	154	1391	1731
			setupStore	8	5	29	3	8	9

Bundle size diffs [🚀 Bundle size reduced!]

background: 0 Bytes (0%)
ui: -25 Bytes (0%)
common: -120 Bytes (0%)

digiwand · 2025-04-07T22:27:11Z

heads up, there is a lint test we want to fix here.

the related issue ticket also implies we want to update the banner alert title and description as well. I think this could be done in addition to this PR or as a separate PR

metamaskbot · 2025-04-08T06:17:29Z

Builds ready [1594ff3]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1249 ± 57 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1249	1112	1443	57	1290	1331
			load	1097	993	1241	53	1144	1198
			domContentLoaded	1090	989	1233	53	1137	1200
			domInteractive	17	13	64	7	16	31
			firstPaint	716	80	1210	440	228	311
			backgroundConnect	10	6	38	5	9	10
			firstReactRender	20	15	55	7	20	37
			getState	14	5	93	11	7	9
			initialActions	0	0	1	0	0	1
			loadScripts	837	742	968	51	877	917
			setupStore	8	5	29	4	7	8
	Webpack	Home	uiStartup	2160	1725	2598	179	2273	2423
			load	1678	1341	2008	136	1767	1893
			domContentLoaded	1672	1338	2002	135	1763	1888
			domInteractive	17	12	67	12	14	53
			firstPaint	150	65	347	55	233	77
			backgroundConnect	30	11	74	14	37	63
			firstReactRender	187	53	352	109	57	93
			getState	13	4	50	9	6	9
			initialActions	3	1	6	1	4	5
			loadScripts	1663	1335	1980	133	1755	1875
			setupStore	21	6	258	25	31	7
Firefox	Browserify	Home	uiStartup	1364	1171	1988	158	1389	1724
			load	1224	1036	1841	154	1248	1583
			domContentLoaded	1223	1036	1840	154	1248	1583
			domInteractive	100	35	278	33	87	97
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	24	16	57	8	25	49
			firstReactRender	22	18	31	3	23	29
			getState	7	4	16	2	8	9
			initialActions	0	0	1	0	0	1
			loadScripts	1200	1019	1808	154	1232	1561
			setupStore	6	4	21	3	6	7
	Webpack	Home	uiStartup	1510	1294	1957	145	1557	1859
			load	1306	1123	1733	134	1362	1630
			domContentLoaded	1306	1123	1733	134	1361	1630
			domInteractive	95	36	160	24	89	97
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	24	17	50	6	27	40
			firstReactRender	34	28	49	5	37	46
			getState	8	3	30	5	8	9
			initialActions	0	0	2	1	1	1
			loadScripts	1284	1105	1711	133	1341	1605
			setupStore	7	5	21	2	7	9

Bundle size diffs [🚀 Bundle size reduced!]

background: 0 Bytes (0%)
ui: -25 Bytes (0%)
common: -120 Bytes (0%)

metamaskbot · 2025-04-08T10:19:43Z

Builds ready [04e6609]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1209 ± 47 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1209	1095	1352	47	1240	1283
			load	1056	967	1172	44	1115	987
			domContentLoaded	1050	958	1167	44	1114	992
			domInteractive	17	13	59	9	16	32
			firstPaint	732	130	1149	412	230	983
			backgroundConnect	10	6	43	5	9	10
			firstReactRender	21	14	136	13	20	38
			getState	13	4	34	7	7	8
			initialActions	0	0	3	0	0	1
			loadScripts	801	697	914	43	831	874
			setupStore	7	4	17	2	7	8
	Webpack	Home	uiStartup	2185	1724	2500	190	2341	2436
			load	1725	1341	2151	171	1837	2000
			domContentLoaded	1717	1336	2068	167	1832	1990
			domInteractive	17	12	57	10	15	49
			firstPaint	168	71	305	49	218	89
			backgroundConnect	36	11	363	42	40	60
			firstReactRender	180	54	400	115	59	91
			getState	13	4	61	10	7	9
			initialActions	3	1	8	1	4	6
			loadScripts	1708	1328	2045	164	1819	1967
			setupStore	23	6	345	40	36	8
Firefox	Browserify	Home	uiStartup	1349	1183	1863	146	1367	1693
			load	1207	1035	1710	136	1232	1520
			domContentLoaded	1207	1035	1710	136	1231	1519
			domInteractive	96	37	279	31	91	97
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	25	16	114	14	24	50
			firstReactRender	22	19	49	4	22	30
			getState	8	4	75	8	7	9
			initialActions	0	0	1	0	0	1
			loadScripts	1183	1018	1684	134	1210	1494
			setupStore	6	4	34	3	6	8
	Webpack	Home	uiStartup	1516	1303	2082	163	1575	1964
			load	1310	1132	1837	154	1354	1726
			domContentLoaded	1310	1132	1837	155	1354	1726
			domInteractive	97	38	194	28	89	97
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	24	17	49	6	26	42
			firstReactRender	35	29	60	5	37	44
			getState	8	4	30	5	7	9
			initialActions	0	0	2	1	1	1
			loadScripts	1288	1113	1811	154	1327	1705
			setupStore	7	5	27	3	7	9

Bundle size diffs [🚀 Bundle size reduced!]

background: 0 Bytes (0%)
ui: -25 Bytes (0%)
common: -120 Bytes (0%)

fix: Update blockaid friction modal copy

541fe35

vinistevam added the team-confirmations Push issues to confirmations team label Apr 1, 2025

fix lint

f0dd3ac

vinistevam self-assigned this Apr 1, 2025

Merge branch 'main' into fix/blockaid-confirm-friction-modal-copy

ae8a7ba

vinistevam marked this pull request as ready for review April 1, 2025 11:59

jpuri previously approved these changes Apr 1, 2025

View reviewed changes

pedronfigueiredo previously approved these changes Apr 7, 2025

View reviewed changes

vinistevam added this pull request to the merge queue Apr 7, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 7, 2025

Merge branch 'main' into fix/blockaid-confirm-friction-modal-copy

d78c3dc

fix: locales

d8157f5

vinistevam dismissed stale reviews from jpuri and pedronfigueiredo via d8157f5 April 8, 2025 05:16

Merge branch 'main' into fix/blockaid-confirm-friction-modal-copy

1594ff3

jpuri approved these changes Apr 8, 2025

View reviewed changes

pedronfigueiredo approved these changes Apr 8, 2025

View reviewed changes

vinistevam added 2 commits April 8, 2025 10:00

Merge branch 'main' into fix/blockaid-confirm-friction-modal-copy

4deb06c

Merge branch 'main' into fix/blockaid-confirm-friction-modal-copy

04e6609

vinistevam added this pull request to the merge queue Apr 8, 2025

Merged via the queue into main with commit ae92326 Apr 8, 2025
164 checks passed

vinistevam deleted the fix/blockaid-confirm-friction-modal-copy branch April 8, 2025 11:04

github-actions bot locked and limited conversation to collaborators Apr 8, 2025

metamaskbot added the release-12.17.0 Issue or pull request that will be included in release 12.17.0 label Apr 8, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Update blockaid friction modal copy #31475

fix: Update blockaid friction modal copy #31475

vinistevam commented Apr 1, 2025 •

edited

Loading

github-actions bot commented Apr 1, 2025

metamaskbot commented Apr 1, 2025

metamaskbot commented Apr 7, 2025

digiwand commented Apr 7, 2025

metamaskbot commented Apr 8, 2025

metamaskbot commented Apr 8, 2025

fix: Update blockaid friction modal copy #31475

fix: Update blockaid friction modal copy #31475

Conversation

vinistevam commented Apr 1, 2025 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Apr 1, 2025

metamaskbot commented Apr 1, 2025

metamaskbot commented Apr 7, 2025

digiwand commented Apr 7, 2025

metamaskbot commented Apr 8, 2025

metamaskbot commented Apr 8, 2025

vinistevam commented Apr 1, 2025 •

edited

Loading