feat: updating popup width of extension from 357px to 400px #31443
+6
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgewrmarshall
added
the
team-design-system
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
| @@ -25,7 +25,7 @@ | |||
| * page may be a further UX improvement. | |||
| */ | |||
| html { | |||
| width: 357px; | |||
| width: 400px; | |||
There was a problem hiding this comment.
Updating the inline CSS and ensuring there are no remaining instances of 357 that affect the width of the extension.
after.mov
Comment on lines
+2
to
+10
| <html style="width:400px; height:600px;" dir="ltr"> | ||
| <head> | ||
| <meta charset="utf-8"> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1, user-scalable=no"> | ||
| <title>MetaMask</title> | ||
| <link rel="preload" href="/_locales/en/messages.json" as="fetch" crossorigin="anonymous" /> | ||
| <link rel="stylesheet" href="../ui/css/index.scss" /> | ||
| </head> | ||
| <body style="width:357px; height:600px;"> | ||
| <body style="width:400px; height:600px;"> |
There was a problem hiding this comment.
Updating other instances of 357px to 400px in the inline CSS
| @@ -86,7 +86,7 @@ const MODALS = { | |||
| }, | |||
| laptopModalStyle: { | |||
| width: | |||
| getEnvironmentType() === ENVIRONMENT_TYPE_POPUP ? '357px' : '449px', | |||
| getEnvironmentType() === ENVIRONMENT_TYPE_POPUP ? '400px' : '449px', | |||
There was a problem hiding this comment.
Updating modal CSS in the deprecated Modal component
| @@ -8,7 +8,7 @@ const animationEventEmitter = new EventEmitter(); | |||
|
|
|||
| const containerStyle = { | |||
| height: '600px', | |||
| width: '357px', | |||
| width: '400px', | |||
There was a problem hiding this comment.
Updating other instances of 357px that aren't part of the popup update. This one is in a Storybook story.
| @@ -6,7 +6,7 @@ | |||
| flex-direction: column; | |||
| justify-content: flex-start; | |||
| align-items: center; | |||
| width: 357px; | |||
| width: 400px; | |||
There was a problem hiding this comment.
Updating the unlock page CSS, although this shouldn't be necessary if the page is coded correctly. This will be removed in a future refactor of the unlock page during the onboarding redesign.
Builds ready [8c9dd7d]
UI Startup Metrics (1214 ± 62 ms)
Bundle size diffs
|
brianacnguyen
approved these changes
Mar 31, 2025
darkwing
approved these changes
Mar 31, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
metamaskbot
added
the
release-12.17.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR increases the default popup width of the MetaMask extension from
357pxto400pxin preparation for an upcoming change to increase the default font size from14pxto16px.Related issues
Fixes: #31444
Manual testing steps
Screenshots/Recordings
Before
Width:
357pxAfter
Width:
400pxPre-merge author checklist
Pre-merge reviewer checklist