refactor: multichain activity tab #31439

darioAnongba · 2025-03-31T16:17:39Z

Description

Align activity tab chain agnostic algorithm, aligned with expected transaction metadata from listAccountTransactions.

Use the to array for Send transactions amounts
Use a different decimal threshold per network
Aggregate amounts per token
Aggregate amounts to compute the Amount
Show a list of addresses in From field for Receive transactions
Remove search in transaction to compute amounts in Swaps.
Support for Redeposit transactions
Fixes Storybook

Related issues

Fixes: https://github.com/MetaMask/accounts-planning/issues/877

Manual testing steps

Create Solana or Bitcoin account
Send and receive transactions (can also send to yourself).
Display activity tab

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2025-03-31T16:17:51Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2025-03-31T17:16:09Z

Builds ready [2349821]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

UI Startup Metrics (1243 ± 67 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1243	1114	1515	67	1284	1347
			load	1086	970	1288	61	1150	986
			domContentLoaded	1080	965	1280	61	1155	989
			domInteractive	16	13	31	4	16	27
			firstPaint	758	78	1286	430	242	78
			backgroundConnect	10	6	25	3	9	10
			firstReactRender	21	15	46	7	20	39
			getState	11	5	37	7	6	9
			initialActions	0	0	1	0	0	1
			loadScripts	857	751	1038	60	901	942
			setupStore	8	4	31	3	7	9
	Webpack	Home	uiStartup	977	722	1459	97	975	992
			load	833	544	1126	76	868	925
			domContentLoaded	826	540	1113	75	861	921
			domInteractive	16	12	92	11	14	41
			firstPaint	530	71	952	345	857	895
			backgroundConnect	16	11	52	8	15	39
			firstReactRender	15	12	39	4	14	28
			getState	7	4	14	2	7	9
			initialActions	0	0	1	0	0	1
			loadScripts	824	530	1101	74	860	912
			setupStore	7	5	13	2	8	9
Firefox	Browserify	Home	uiStartup	1354	1143	1915	164	1364	1794
			load	1222	1026	1778	159	1244	1619
			domContentLoaded	1222	1026	1777	159	1244	1619
			domInteractive	97	36	204	28	90	98
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	21	16	40	4	23	31
			firstReactRender	22	19	28	3	24	27
			getState	7	4	36	4	7	8
			initialActions	0	0	1	0	0	1
			loadScripts	1201	1010	1756	157	1221	1596
			setupStore	6	3	28	4	6	7
	Webpack	Home	uiStartup	1001	854	1553	159	901	973
			load	877	744	1348	142	810	921
			domContentLoaded	876	744	1347	142	810	921
			domInteractive	115	36	200	27	145	95
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	21	13	76	11	24	39
			firstReactRender	19	16	26	2	19	24
			getState	9	4	62	10	8	9
			initialActions	0	0	1	0	0	1
			loadScripts	859	725	1318	138	797	954
			setupStore	9	5	65	9	7	8

Bundle size diffs [🚀 Bundle size reduced!]

background: -9.84 KiB (-0.17%)
ui: 167 Bytes (0%)
common: 9.54 KiB (0.1%)

metamaskbot · 2025-04-01T11:02:48Z

Builds ready [dbacb12]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

UI Startup Metrics (1214 ± 69 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1214	1077	1371	69	1266	1330
			load	1063	941	1205	67	1205	991
			domContentLoaded	1057	937	1199	67	937	987
			domInteractive	16	13	41	5	16	30
			firstPaint	816	93	1205	387	269	984
			backgroundConnect	9	7	28	2	9	10
			firstReactRender	19	13	44	5	19	30
			getState	11	4	43	8	6	8
			initialActions	0	0	1	0	0	1
			loadScripts	842	727	979	66	890	952
			setupStore	8	5	17	2	7	8
	Webpack	Home	uiStartup	1020	761	1288	91	966	996
			load	857	609	1096	87	918	963
			domContentLoaded	852	605	1092	87	914	960
			domInteractive	16	13	46	7	14	35
			firstPaint	344	59	973	328	834	96
			backgroundConnect	18	13	52	8	16	41
			firstReactRender	17	12	30	4	17	27
			getState	5	3	17	3	5	8
			initialActions	0	0	1	0	0	0
			loadScripts	849	596	1090	87	911	958
			setupStore	8	5	16	3	7	9
Firefox	Browserify	Home	uiStartup	1386	1183	1929	151	1410	1771
			load	1248	1063	1776	144	1283	1594
			domContentLoaded	1248	1063	1776	144	1282	1594
			domInteractive	108	38	207	32	85	98
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	24	16	127	13	24	40
			firstReactRender	23	19	41	4	25	30
			getState	7	4	23	3	7	8
			initialActions	0	0	1	0	0	1
			loadScripts	1225	1045	1742	142	1258	1570
			setupStore	5	4	12	2	6	7
	Webpack	Home	uiStartup	961	816	1405	163	870	982
			load	842	712	1216	147	774	887
			domContentLoaded	841	712	1215	147	773	887
			domInteractive	118	67	196	23	134	95
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	19	12	74	8	20	28
			firstReactRender	18	16	28	2	18	23
			getState	8	4	75	10	7	8
			initialActions	0	0	1	0	0	1
			loadScripts	825	699	1189	142	760	872
			setupStore	11	4	72	14	7	8

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0%)
ui: 58 Bytes (0%)
common: 313 Bytes (0%)

metamaskbot · 2025-04-01T12:02:23Z

Builds ready [4d50f36]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

UI Startup Metrics (1224 ± 55 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1224	1103	1431	55	1259	1311
			load	1065	938	1172	50	1135	987
			domContentLoaded	1057	931	1166	50	1137	986
			domInteractive	16	13	32	4	16	28
			firstPaint	806	156	1174	397	240	986
			backgroundConnect	11	6	70	9	9	10
			firstReactRender	20	15	45	5	20	34
			getState	11	4	30	7	6	8
			initialActions	0	0	1	0	0	0
			loadScripts	839	713	954	51	876	922
			setupStore	8	5	19	3	7	9
	Webpack	Home	uiStartup	1032	693	1562	102	971	995
			load	870	521	1098	71	898	959
			domContentLoaded	864	512	1092	71	896	970
			domInteractive	16	13	47	7	14	36
			firstPaint	326	56	1001	336	840	91
			backgroundConnect	18	13	62	9	17	42
			firstReactRender	16	12	32	5	17	28
			getState	6	3	19	4	5	6
			initialActions	0	0	1	0	0	1
			loadScripts	861	511	1075	70	894	960
			setupStore	8	5	25	3	7	9
Firefox	Browserify	Home	uiStartup	1383	1185	1824	139	1437	1721
			load	1246	1061	1675	132	1302	1540
			domContentLoaded	1245	1061	1675	132	1302	1540
			domInteractive	99	42	216	27	89	97
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	22	16	43	5	24	33
			firstReactRender	23	19	62	5	25	28
			getState	6	4	12	1	7	9
			initialActions	0	0	28	3	0	1
			loadScripts	1225	1045	1655	130	1285	1513
			setupStore	6	3	18	2	6	8
	Webpack	Home	uiStartup	960	813	1551	167	883	979
			load	842	706	1356	148	786	901
			domContentLoaded	841	706	1356	148	785	901
			domInteractive	124	77	190	22	141	77
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	20	12	84	10	20	34
			firstReactRender	18	16	30	2	18	24
			getState	10	4	72	13	70	9
			initialActions	0	0	1	0	0	1
			loadScripts	825	697	1335	144	772	887
			setupStore	8	5	92	9	7	8

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 6 Bytes (0%)
ui: 666 Bytes (0.01%)
common: 313 Bytes (0%)

ui/components/app/multichain-transaction-details-modal/multichain-transaction-details-modal.tsx

ui/components/app/transaction-list/transaction-list.component.js

zone-live

LGTM 💪🏼

metamaskbot · 2025-04-01T15:01:11Z

Builds ready [9325a79]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

UI Startup Metrics (1196 ± 72 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1196	1072	1458	72	1235	1319
			load	1041	933	1258	63	957	992
			domContentLoaded	1035	928	1250	63	953	992
			domInteractive	16	13	29	4	16	27
			firstPaint	775	146	1239	389	239	985
			backgroundConnect	11	6	76	8	9	10
			firstReactRender	19	15	39	4	20	27
			getState	11	5	34	7	6	8
			initialActions	0	0	1	0	0	1
			loadScripts	820	718	1024	62	847	922
			setupStore	8	5	20	2	7	8
	Webpack	Home	uiStartup	1020	834	1281	84	959	992
			load	857	612	991	67	904	948
			domContentLoaded	852	605	983	66	894	944
			domInteractive	16	12	41	6	14	33
			firstPaint	299	57	943	296	80	927
			backgroundConnect	18	13	42	7	16	40
			firstReactRender	16	12	31	4	17	27
			getState	6	2	20	3	5	8
			initialActions	0	0	1	0	0	1
			loadScripts	849	602	973	66	890	942
			setupStore	8	4	17	3	7	9
Firefox	Browserify	Home	uiStartup	1413	1196	1880	148	1441	1779
			load	1266	1075	1722	133	1293	1587
			domContentLoaded	1266	1075	1721	133	1293	1587
			domInteractive	103	41	198	28	87	97
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	24	17	74	8	25	32
			firstReactRender	23	19	35	3	23	28
			getState	7	4	37	4	7	9
			initialActions	0	0	1	0	0	1
			loadScripts	1243	1058	1698	132	1274	1562
			setupStore	6	4	12	2	6	8
	Webpack	Home	uiStartup	1001	832	1511	152	904	974
			load	873	727	1291	134	819	970
			domContentLoaded	873	727	1289	134	820	973
			domInteractive	116	33	192	25	146	97
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	22	13	116	14	25	41
			firstReactRender	19	16	34	3	19	25
			getState	10	4	76	11	8	9
			initialActions	0	0	1	0	0	1
			loadScripts	855	715	1272	130	813	979
			setupStore	9	4	51	8	8	9

Bundle size diffs [🚀 Bundle size reduced!]

background: 0 Bytes (0%)
ui: 61 Bytes (0%)
common: -3.94 KiB (-0.04%)

darioAnongba added 4 commits March 31, 2025 15:54

use network image

bac2823

Merge branch 'main' into refactor/activity-tab

259f139

logic done

308c016

lint

62eb189

darioAnongba added the team-accounts label Mar 31, 2025

darioAnongba self-assigned this Mar 31, 2025

darioAnongba marked this pull request as draft March 31, 2025 16:17

darioAnongba added 3 commits March 31, 2025 18:18

Merge branch 'main' into refactor/activity-tab

6490475

lint

1685040

revert test values

2349821

darioAnongba added 5 commits April 1, 2025 11:50

show what you receive in swaps

67f38d1

fix tests

5a6e59d

Merge branch 'main' into refactor/activity-tab

91d0f8c

fix decimals

db112b7

fix stories

dbacb12

storybook fixed

4d50f36

darioAnongba marked this pull request as ready for review April 1, 2025 11:42

darioAnongba requested review from aganglada and zone-live April 1, 2025 11:55

aganglada reviewed Apr 1, 2025

View reviewed changes

zone-live previously approved these changes Apr 1, 2025

View reviewed changes

darioAnongba added 2 commits April 1, 2025 15:17

Merge branch 'main' into refactor/activity-tab

97f2253

retrieve network from selector

d06e383

darioAnongba dismissed zone-live’s stale review via d06e383 April 1, 2025 13:59

darioAnongba added 2 commits April 1, 2025 16:13

already available

90705d2

lint

9325a79

aganglada approved these changes Apr 1, 2025

View reviewed changes

zone-live approved these changes Apr 1, 2025

View reviewed changes

darioAnongba added this pull request to the merge queue Apr 1, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 1, 2025

darioAnongba added this pull request to the merge queue Apr 1, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 1, 2025

darioAnongba added this pull request to the merge queue Apr 1, 2025

Merged via the queue into main with commit ebd5018 Apr 1, 2025
147 checks passed

darioAnongba deleted the refactor/activity-tab branch April 1, 2025 20:28

github-actions bot locked and limited conversation to collaborators Apr 1, 2025

metamaskbot added the release-12.17.0 Issue or pull request that will be included in release 12.17.0 label Apr 1, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: multichain activity tab #31439

refactor: multichain activity tab #31439

darioAnongba commented Mar 31, 2025 •

edited

Loading

github-actions bot commented Mar 31, 2025

metamaskbot commented Mar 31, 2025

metamaskbot commented Apr 1, 2025

metamaskbot commented Apr 1, 2025

zone-live left a comment

metamaskbot commented Apr 1, 2025

refactor: multichain activity tab #31439

refactor: multichain activity tab #31439

Conversation

darioAnongba commented Mar 31, 2025 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Mar 31, 2025

metamaskbot commented Mar 31, 2025

metamaskbot commented Apr 1, 2025

metamaskbot commented Apr 1, 2025

zone-live left a comment

Choose a reason for hiding this comment

metamaskbot commented Apr 1, 2025

darioAnongba commented Mar 31, 2025 •

edited

Loading