fix: improve fetching nft details for custom contracts #31432

sahar-fehri · 2025-03-31T13:14:45Z

Description

This PR adds fetching NFT image and name from tokenURI and fallsback to the fetched values when they are undefined from NFT-API.

Related issues

Fixes: #29471

Manual testing steps

Go to this page...

Screenshots/Recordings

Before

I was not able to repro exact behavior in issue but i added fallbacks for the behavior i saw on main for the custom contract

Screen.Recording.2025-03-31.at.20.27.50.mov

After

Screen.Recording.2025-03-31.at.15.36.29.mov

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2025-03-31T13:14:59Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2025-03-31T14:15:42Z

Builds ready [9b3aab5]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

UI Startup Metrics (1260 ± 67 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1260	1105	1432	67	1310	1376
			load	1094	990	1241	61	1149	1241
			domContentLoaded	1088	982	1237	60	1146	986
			domInteractive	18	14	59	6	18	31
			firstPaint	782	134	1256	426	212	296
			backgroundConnect	11	6	64	8	9	10
			firstReactRender	20	14	38	5	21	32
			getState	12	4	34	7	7	9
			initialActions	0	0	1	0	0	1
			loadScripts	860	760	1012	58	894	956
			setupStore	8	5	21	3	8	9
	Webpack	Home	uiStartup	961	768	1260	78	966	985
			load	816	598	978	67	850	920
			domContentLoaded	810	591	964	68	846	908
			domInteractive	16	13	44	6	14	32
			firstPaint	530	59	968	346	836	911
			backgroundConnect	17	11	56	9	15	39
			firstReactRender	14	12	29	4	14	27
			getState	7	4	13	2	7	8
			initialActions	0	0	1	0	0	0
			loadScripts	807	580	954	67	843	899
			setupStore	7	5	16	2	8	9
Firefox	Browserify	Home	uiStartup	1411	1217	1925	147	1457	1776
			load	1268	1096	1757	141	1315	1623
			domContentLoaded	1268	1095	1757	141	1315	1623
			domInteractive	113	41	227	32	74	98
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	25	16	80	10	27	46
			firstReactRender	23	19	56	5	25	30
			getState	7	4	14	2	7	9
			initialActions	0	0	1	0	0	1
			loadScripts	1244	1061	1734	140	1296	1595
			setupStore	6	4	35	3	6	8
	Webpack	Home	uiStartup	1053	895	1552	154	938	992
			load	917	771	1383	138	848	918
			domContentLoaded	917	771	1382	138	848	917
			domInteractive	119	36	199	27	140	42
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	21	14	79	7	24	31
			firstReactRender	20	17	33	3	20	26
			getState	10	4	90	10	8	9
			initialActions	0	0	1	0	0	1
			loadScripts	898	755	1359	135	838	926
			setupStore	13	5	69	16	8	9

Bundle size diffs

background: 0 Bytes (0%)
ui: 1.51 KiB (0.02%)
common: 0 Bytes (0%)

metamaskbot · 2025-03-31T14:23:44Z

✨ Files requiring CODEOWNER review ✨

✅ @MetaMask/confirmations

ui/pages/confirmations/components/confirm/info/shared/nft-send-heading/nft-send-heading.tsx
ui/pages/confirmations/hooks/useAssetDetails.js

🖥️ @MetaMask/wallet-ux

ui/components/multichain/nft-item/nft-item.tsx

metamaskbot · 2025-03-31T19:04:55Z

Builds ready [802413a]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

UI Startup Metrics (1184 ± 61 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1184	1090	1393	61	1220	1295
			load	1033	938	1172	58	954	995
			domContentLoaded	1027	934	1167	58	952	993
			domInteractive	16	13	31	4	16	27
			firstPaint	741	79	1178	401	275	994
			backgroundConnect	11	6	145	15	9	10
			firstReactRender	19	13	48	5	19	28
			getState	10	4	30	7	6	8
			initialActions	0	0	1	0	0	1
			loadScripts	809	696	947	59	847	919
			setupStore	7	5	13	2	7	8
	Webpack	Home	uiStartup	1011	805	1207	79	980	997
			load	853	594	976	72	898	954
			domContentLoaded	847	587	965	72	888	948
			domInteractive	16	12	50	7	14	34
			firstPaint	307	56	969	315	827	925
			backgroundConnect	18	13	44	7	16	38
			firstReactRender	16	12	30	4	17	27
			getState	5	3	19	3	5	8
			initialActions	0	0	1	0	0	0
			loadScripts	845	584	963	72	885	946
			setupStore	8	4	15	2	7	9
Firefox	Browserify	Home	uiStartup	1342	1168	2064	157	1364	1680
			load	1204	1032	1898	147	1234	1499
			domContentLoaded	1203	1032	1898	147	1234	1499
			domInteractive	97	36	212	27	88	97
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	24	16	162	15	24	41
			firstReactRender	22	19	54	5	24	28
			getState	6	3	24	2	7	8
			initialActions	0	0	1	0	0	1
			loadScripts	1180	1012	1871	141	1210	1477
			setupStore	6	4	30	3	6	8
	Webpack	Home	uiStartup	1000	844	1599	172	906	958
			load	875	738	1389	154	809	916
			domContentLoaded	875	738	1388	154	809	915
			domInteractive	119	39	206	27	154	96
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	19	12	82	8	22	30
			firstReactRender	19	17	27	2	19	24
			getState	11	4	91	15	8	9
			initialActions	0	0	1	0	0	1
			loadScripts	858	725	1366	151	797	951
			setupStore	7	4	58	5	7	9

Bundle size diffs [🚀 Bundle size reduced!]

background: -560.45 KiB (-9.57%)
ui: 61.5 KiB (0.91%)
common: -94.6 KiB (-1%)

…contracts

metamaskbot · 2025-03-31T20:42:07Z

Builds ready [995e50c]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1183 ± 68 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1183	1051	1543	68	1210	1283
			load	1035	942	1353	62	948	997
			domContentLoaded	1028	934	1344	62	941	994
			domInteractive	16	13	34	5	16	27
			firstPaint	695	89	1351	414	259	984
			backgroundConnect	10	6	73	7	9	10
			firstReactRender	20	14	51	8	20	40
			getState	10	4	34	7	6	7
			initialActions	0	0	1	0	0	1
			loadScripts	814	711	1104	61	837	886
			setupStore	8	4	19	2	7	9
	Webpack	Home	uiStartup	995	778	1209	83	976	994
			load	835	600	980	75	870	947
			domContentLoaded	829	581	976	75	865	943
			domInteractive	15	12	35	6	14	35
			firstPaint	310	59	954	310	79	907
			backgroundConnect	18	13	52	8	16	41
			firstReactRender	17	12	40	5	17	28
			getState	5	3	20	3	5	6
			initialActions	0	0	1	0	0	1
			loadScripts	826	571	975	75	864	941
			setupStore	8	4	24	3	8	9
Firefox	Browserify	Home	uiStartup	1378	1176	1864	143	1398	1739
			load	1242	1058	1712	137	1276	1583
			domContentLoaded	1242	1058	1712	137	1276	1583
			domInteractive	108	38	195	30	82	98
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	23	16	97	8	24	32
			firstReactRender	23	19	47	5	25	32
			getState	6	4	17	2	7	8
			initialActions	0	0	1	0	0	1
			loadScripts	1220	1041	1689	135	1256	1557
			setupStore	6	4	11	2	6	7
	Webpack	Home	uiStartup	983	823	1612	180	890	984
			load	858	721	1401	157	798	899
			domContentLoaded	858	721	1400	157	798	899
			domInteractive	114	51	241	25	158	94
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	21	14	109	14	23	33
			firstReactRender	18	16	26	2	19	23
			getState	11	4	78	14	7	9
			initialActions	0	0	1	0	0	1
			loadScripts	841	707	1378	154	785	879
			setupStore	8	5	73	7	7	8

Bundle size diffs

background: 0 Bytes (0%)
ui: 1.66 KiB (0.02%)
common: 0 Bytes (0%)

metamaskbot · 2025-04-07T15:12:05Z

Builds ready [204df7f]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1225 ± 51 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1225	1120	1395	51	1255	1320
			load	1076	973	1204	45	1110	986
			domContentLoaded	1069	952	1198	46	1112	993
			domInteractive	17	13	66	9	16	36
			firstPaint	820	140	1204	401	169	291
			backgroundConnect	10	6	35	4	9	10
			firstReactRender	19	14	54	5	19	25
			getState	13	5	30	7	6	8
			initialActions	0	0	1	0	0	1
			loadScripts	817	717	932	44	842	885
			setupStore	7	4	14	2	7	8
	Webpack	Home	uiStartup	2201	1741	2696	189	2306	2507
			load	1722	1350	2207	158	1795	2042
			domContentLoaded	1715	1345	2202	156	1790	2027
			domInteractive	17	12	63	11	14	50
			firstPaint	162	66	357	57	222	83
			backgroundConnect	35	11	311	37	36	69
			firstReactRender	188	54	368	120	56	91
			getState	13	4	58	9	6	9
			initialActions	3	1	8	1	3	6
			loadScripts	1704	1342	2197	148	1782	1990
			setupStore	23	6	299	38	37	7
Firefox	Browserify	Home	uiStartup	1384	1176	1801	132	1440	1706
			load	1242	1057	1602	123	1311	1527
			domContentLoaded	1242	1057	1602	123	1311	1527
			domInteractive	100	37	260	37	87	97
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	27	16	220	22	25	52
			firstReactRender	22	19	32	3	22	29
			getState	7	4	15	2	8	8
			initialActions	0	0	1	0	0	1
			loadScripts	1218	1041	1538	119	1294	1502
			setupStore	6	4	12	2	6	7
	Webpack	Home	uiStartup	1567	1343	2202	186	1636	2020
			load	1352	1116	2004	176	1414	1775
			domContentLoaded	1351	1116	2004	176	1414	1775
			domInteractive	100	37	301	34	91	96
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	25	17	52	6	26	40
			firstReactRender	35	29	55	5	37	46
			getState	11	5	254	25	8	9
			initialActions	0	0	2	1	1	1
			loadScripts	1329	1097	1979	175	1395	1749
			setupStore	10	5	205	20	8	9

Bundle size diffs

background: 0 Bytes (0%)
ui: 1.63 KiB (0.02%)
common: 0 Bytes (0%)

ui/components/app/assets/nfts/nft-grid/nft-grid.tsx

ui/hooks/useFetchNftDetailsFromTokenURI.ts

gambinish

Approving, but before we merge could you take a look at my comments, and lmk what you think? Neither need to block.

metamaskbot · 2025-04-07T21:02:25Z

Builds ready [de99685]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1232 ± 54 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1232	1121	1400	54	1262	1332
			load	1077	951	1266	56	1124	983
			domContentLoaded	1070	938	1255	57	1136	994
			domInteractive	18	13	64	9	16	33
			firstPaint	810	138	1264	400	216	968
			backgroundConnect	10	7	45	5	9	10
			firstReactRender	22	14	136	15	20	27
			getState	12	5	34	7	7	9
			initialActions	0	0	3	0	0	0
			loadScripts	818	686	952	55	849	908
			setupStore	8	4	22	3	7	9
	Webpack	Home	uiStartup	2178	1749	2576	189	2297	2419
			load	1705	1322	2052	150	1785	1963
			domContentLoaded	1695	1317	2041	150	1774	1946
			domInteractive	17	12	83	13	14	56
			firstPaint	158	64	346	61	268	86
			backgroundConnect	36	11	388	45	41	61
			firstReactRender	201	53	453	120	57	92
			getState	12	3	51	9	7	9
			initialActions	3	1	8	1	3	5
			loadScripts	1687	1307	2018	146	1764	1924
			setupStore	21	6	273	31	45	9
Firefox	Browserify	Home	uiStartup	1406	1229	1937	149	1440	1784
			load	1261	1075	1794	146	1289	1611
			domContentLoaded	1261	1074	1794	146	1288	1611
			domInteractive	105	39	206	33	87	96
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	27	17	111	14	27	43
			firstReactRender	23	19	57	4	23	29
			getState	8	4	46	5	8	9
			initialActions	0	0	1	0	0	1
			loadScripts	1235	1054	1774	145	1269	1586
			setupStore	6	4	24	3	6	7
	Webpack	Home	uiStartup	1600	1352	2247	163	1661	1968
			load	1377	1166	1976	151	1440	1727
			domContentLoaded	1377	1166	1976	151	1440	1727
			domInteractive	104	44	251	29	89	98
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	26	18	49	6	28	42
			firstReactRender	36	28	63	5	39	48
			getState	10	4	35	7	8	9
			initialActions	0	0	1	0	1	1
			loadScripts	1354	1145	1952	150	1420	1698
			setupStore	9	5	40	5	8	9

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 1.51 KiB (0.02%)
ui: -6.65 KiB (-0.1%)
common: -125 Bytes (0%)

OGPoyraz

Confirmation changes LGTM

…contracts

metamaskbot · 2025-04-08T08:52:38Z

Builds ready [f9fd8be]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1230 ± 71 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1230	1102	1416	71	1282	1354
			load	1076	972	1250	67	1195	993
			domContentLoaded	1070	967	1246	67	1217	988
			domInteractive	17	13	60	8	16	32
			firstPaint	755	132	1250	433	224	991
			backgroundConnect	11	6	57	9	9	10
			firstReactRender	21	15	46	6	21	35
			getState	13	5	43	9	7	8
			initialActions	0	0	1	0	0	1
			loadScripts	820	716	981	67	871	931
			setupStore	8	4	35	5	7	8
	Webpack	Home	uiStartup	2161	1696	2655	169	2291	2407
			load	1680	1307	2013	148	1768	1959
			domContentLoaded	1675	1300	2006	147	1764	1951
			domInteractive	17	12	65	11	14	53
			firstPaint	158	65	368	66	246	77
			backgroundConnect	35	10	273	36	37	61
			firstReactRender	182	53	381	113	57	89
			getState	14	4	225	22	6	9
			initialActions	3	1	8	1	4	5
			loadScripts	1666	1295	1984	145	1758	1947
			setupStore	27	6	411	56	41	8
Firefox	Browserify	Home	uiStartup	1377	1195	1890	143	1427	1704
			load	1235	1039	1733	138	1288	1535
			domContentLoaded	1235	1039	1732	138	1288	1535
			domInteractive	102	40	264	35	89	97
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	26	17	103	16	24	49
			firstReactRender	23	19	48	4	23	29
			getState	8	3	63	6	8	9
			initialActions	0	0	2	0	0	1
			loadScripts	1210	1022	1709	137	1263	1515
			setupStore	7	4	89	9	6	7
	Webpack	Home	uiStartup	1557	1377	2081	146	1644	1846
			load	1339	1181	1881	139	1417	1642
			domContentLoaded	1338	1181	1880	139	1416	1642
			domInteractive	95	40	292	27	88	96
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	27	18	88	9	29	48
			firstReactRender	38	29	62	6	41	48
			getState	10	4	38	7	8	9
			initialActions	0	0	2	1	1	1
			loadScripts	1315	1159	1859	139	1392	1619
			setupStore	9	6	32	5	8	9

Bundle size diffs

background: 0 Bytes (0%)
ui: 1.46 KiB (0.02%)
common: 0 Bytes (0%)

fix: improve fetching nft details for custom contracts

6169301

fix: conflicts

9b3aab5

fix: add fallback for image and name on tx review page

60d177c

sahar-fehri added 3 commits March 31, 2025 16:50

fix: add test

29028bf

fix: update snapshot

6358a9d

fix: fix

802413a

Merge branch 'main' into fix/fix-display-nft-details-for-custom-test-…

995e50c

…contracts

sahar-fehri added the needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. label Mar 31, 2025

sahar-fehri requested a review from seaona March 31, 2025 20:36

sahar-fehri marked this pull request as ready for review March 31, 2025 20:37

sahar-fehri requested review from a team as code owners March 31, 2025 20:37

fix: fix conflicts

204df7f

sahar-fehri added the team-assets label Apr 7, 2025

gambinish reviewed Apr 7, 2025

View reviewed changes

ui/components/app/assets/nfts/nft-grid/nft-grid.tsx Outdated Show resolved Hide resolved

gambinish reviewed Apr 7, 2025

View reviewed changes

ui/hooks/useFetchNftDetailsFromTokenURI.ts Outdated Show resolved Hide resolved

gambinish previously approved these changes Apr 7, 2025

View reviewed changes

fix: rename fct

ac558c3

sahar-fehri dismissed gambinish’s stale review via ac558c3 April 7, 2025 20:20

fix: use isWebUrl

de99685

gambinish approved these changes Apr 7, 2025

View reviewed changes

Prithpal-Sooriya approved these changes Apr 7, 2025

View reviewed changes

sahar-fehri enabled auto-merge April 7, 2025 20:35

OGPoyraz approved these changes Apr 8, 2025

View reviewed changes

Merge branch 'main' into fix/fix-display-nft-details-for-custom-test-…

f9fd8be

…contracts

GustavoRSSilva approved these changes Apr 8, 2025

View reviewed changes

NidhiKJha approved these changes Apr 8, 2025

View reviewed changes

sahar-fehri added this pull request to the merge queue Apr 8, 2025

Merged via the queue into main with commit ea0b60c Apr 8, 2025
164 checks passed

sahar-fehri deleted the fix/fix-display-nft-details-for-custom-test-contracts branch April 8, 2025 09:40

github-actions bot locked and limited conversation to collaborators Apr 8, 2025

metamaskbot added the release-12.17.0 Issue or pull request that will be included in release 12.17.0 label Apr 8, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: improve fetching nft details for custom contracts #31432

fix: improve fetching nft details for custom contracts #31432

sahar-fehri commented Mar 31, 2025 •

edited

Loading

github-actions bot commented Mar 31, 2025

metamaskbot commented Mar 31, 2025

metamaskbot commented Mar 31, 2025

metamaskbot commented Mar 31, 2025

metamaskbot commented Mar 31, 2025

metamaskbot commented Apr 7, 2025

gambinish left a comment

metamaskbot commented Apr 7, 2025

OGPoyraz left a comment

metamaskbot commented Apr 8, 2025

fix: improve fetching nft details for custom contracts #31432

fix: improve fetching nft details for custom contracts #31432

Conversation

sahar-fehri commented Mar 31, 2025 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Mar 31, 2025

metamaskbot commented Mar 31, 2025

metamaskbot commented Mar 31, 2025

✨ Files requiring CODEOWNER review ✨

metamaskbot commented Mar 31, 2025

metamaskbot commented Mar 31, 2025

metamaskbot commented Apr 7, 2025

gambinish left a comment

Choose a reason for hiding this comment

metamaskbot commented Apr 7, 2025

OGPoyraz left a comment

Choose a reason for hiding this comment

metamaskbot commented Apr 8, 2025

sahar-fehri commented Mar 31, 2025 •

edited

Loading