-
Notifications
You must be signed in to change notification settings - Fork 5.2k
fix: token name sort #31302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
fix: token name sort #31302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Builds ready [7595325]
Page Load Metrics (2939 ± 1323 ms)
Bundle size diffs
|
Prithpal-Sooriya
approved these changes
Mar 25, 2025
Tested Firefox, Chrome; Flask and Main. |
Tested solana accounts, happy with this change |
bergarces
reviewed
Mar 27, 2025
bergarces
approved these changes
Mar 27, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We recently decided that we wanted to sort by token name, rather than symbol. The problem is that native tokens for several chains display
Ethereum
when in actuality the name we get from the token API is something likeLinea
. This would cause native tokens on some EVM chains to be miscategorized in sort.This PR overrides the token name for this scenario. It also consolidates the
name
andtitle
fields to support both EVM and nonEVM chains.Related issues
Fixes: #31235
Manual testing steps
Screenshots/Recordings
Before
Before scenarios in bug ticket linked.
After
Chrome:
Firefox:
Pre-merge author checklist
Pre-merge reviewer checklist