chore: remove preference to enable incoming transaction polling for networks

[jpuri]

Description

Remove preference to enable incoming transaction polling for networks. Use Basic Functionality toggle to enable transaction polling.

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/4500

Manual testing steps

1. Go to extension security and privacy settings
2. Ensure that there is no option to enable incoming transaction for networks

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[metamaskbot]

✨ Files requiring CODEOWNER review ✨

✅ @MetaMask/confirmations

• app/scripts/controller-init/confirmations/transaction-controller-init.test.ts
• app/scripts/controller-init/confirmations/transaction-controller-init.ts

[metamaskbot]

❌ API Spec Test Failed. View the report here.

[metamaskbot]

Builds ready [5bc7b26]

• builds: chrome, firefox
• builds (flask): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• bundle size: Bundle Size Stats
• user-actions-benchmark: User Actions Stats
• storybook: Storybook
• typescript migration: Dashboard
• all CircleCI artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7, 8
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
  • ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
  • content-script: 0
  • offscreen: 0

UI Startup Metrics (1189 ± 67 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1189	1073	1652	67	1225	1264
			load	1034	908	1415	60	938	988
			domContentLoaded	1028	902	1404	59	944	986
			domInteractive	16	13	33	4	16	26
			firstPaint	799	169	1120	367	256	989
			backgroundConnect	9	7	26	3	9	10
			firstReactRender	19	15	37	4	19	32
			getState	11	4	28	7	6	8
			initialActions	0	0	1	0	0	0
			loadScripts	814	696	1128	55	840	884
			setupStore	7	5	17	2	7	9
	Webpack	Home	uiStartup	936	812	1170	74	942	978
			load	796	599	897	61	830	879
			domContentLoaded	789	580	893	62	825	868
			domInteractive	15	12	42	6	14	32
			firstPaint	465	69	897	328	813	866
			backgroundConnect	16	11	52	8	15	35
			firstReactRender	14	12	32	4	13	28
			getState	6	3	15	2	7	8
			initialActions	0	0	1	0	0	0
			loadScripts	787	570	891	61	824	865
			setupStore	7	5	16	2	7	9
Firefox	Browserify	Home	uiStartup	1383	1206	1984	171	1405	1812
			load	1244	1051	1812	159	1275	1626
			domContentLoaded	1244	1051	1812	159	1275	1626
			domInteractive	99	37	175	28	86	97
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	23	16	71	6	25	32
			firstReactRender	23	18	52	5	24	30
			getState	6	3	20	2	7	8
			initialActions	0	0	1	0	0	1
			loadScripts	1223	1034	1786	158	1257	1596
			setupStore	6	4	30	4	6	7
	Webpack	Home	uiStartup	1003	834	1531	175	898	954
			load	874	723	1340	152	809	916
			domContentLoaded	874	723	1339	152	808	916
			domInteractive	114	31	224	26	151	94
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	23	14	102	16	25	72
			firstReactRender	19	16	38	4	19	26
			getState	11	4	74	14	8	9
			initialActions	0	0	1	0	0	1
			loadScripts	856	709	1320	149	795	965
			setupStore	7	4	52	5	8	9

Bundle size diffs [🚀 Bundle size reduced!]

• background: -456 Bytes (-0.01%)
• ui: -7.27 KiB (-0.11%)
• common: -858 Bytes (-0.01%)