Skip to content

chore: disable buttons for non-evm account #31193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Mar 25, 2025

Conversation

zone-live
Copy link
Contributor

@zone-live zone-live commented Mar 21, 2025

Description

When basic functionality is off and the account is non-evm we want to also disable the Send and Bridge buttons.

Screenshot 2025-03-21 at 10 07 23

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-solana PRs from the Solana snap team label Mar 21, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [86e77a8]
Page Load Metrics (2738 ± 1047 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint163511503261121731043
domContentLoaded144211105235721161016
load163311624273821811047
domInteractive24389717737
backgroundConnect7775234315775
firstReactRender23111762411
getState2341519210149
initialActions01000
loadScripts1058957717451856891
setupStore112521057637
uiStartup185213896419324841193
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 42 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@zone-live zone-live requested a review from sahar-fehri March 24, 2025 13:11
@metamaskbot
Copy link
Collaborator

Builds ready [50f490e]
Page Load Metrics (2876 ± 1282 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint44413037255025931245
domContentLoaded153511793248822561083
load161513843287626701282
domInteractive27251595928
backgroundConnect831905419411197
firstReactRender36214905125
getState2770819417383
initialActions01000
loadScripts11201049118752052985
setupStore1343011711354
uiStartup201418002524439051875
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 42 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

sahar-fehri
sahar-fehri previously approved these changes Mar 25, 2025
sahar-fehri
sahar-fehri previously approved these changes Mar 25, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [3433980]
Page Load Metrics (5287 ± 3324 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint169423423512969043315
domContentLoaded156822787488068033267
load174723593528769233324
domInteractive2657112716680
backgroundConnect651162426274132
firstReactRender28170913818
getState241200235255122
initialActions01000
loadScripts116522240423567453239
setupStore942212111555
uiStartup205525364758270193370
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 42 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@zone-live zone-live changed the title chore: disable buttons for solana chore: disable buttons for non-evm account Mar 25, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [0608851]
Page Load Metrics (2737 ± 1067 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint27511784253521961054
domContentLoaded14831138124572070994
load151712193273722221067
domInteractive268340136
backgroundConnect15801295247119
firstReactRender18165774924
getState546212112259
initialActions01000
loadScripts1081979418461834881
setupStore9349788842
uiStartup174417084427433901628
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 42 Bytes (0.00%)
  • common: 141 Bytes (0.00%)

@zone-live zone-live added this pull request to the merge queue Mar 25, 2025
Merged via the queue into main with commit 230e316 Mar 25, 2025
107 checks passed
@zone-live zone-live deleted the SOL-225-disable-buttons-for-solana branch March 25, 2025 14:04
@github-actions github-actions bot locked and limited conversation to collaborators Mar 25, 2025
@metamaskbot metamaskbot added the release-12.16.0 Issue or pull request that will be included in release 12.16.0 label Mar 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.16.0 Issue or pull request that will be included in release 12.16.0 team-solana PRs from the Solana snap team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants