feat: enable account syncing for MV2 #31141

mathieuartu · 2025-03-20T11:47:50Z

Description

This PR enables account syncing for MV2.

It also:

fixes user storage related E2E tests so that they don't rely on async describe statements, because those were making CI ignore the this.timeout overrides. We need those overrides as MV2 tests take a while for account syncing and user storage related operations.
Adds new test utils for user storage:
- Wait until a certain number of accounts have been synced
- Wait until a user storage network event happened a certain number of times

MV2 E2E test drive results:

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/IDENTITY-56

Manual testing steps

Load the build in Firefox
Import or create an SRP
Add accounts and rename them
Uninstall / Reinstall
Verify that the previously created accounts are synced

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2025-03-20T11:48:03Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

This reverts commit b7426c7.

…cribe

metamaskbot · 2025-03-21T11:12:16Z

Builds ready [96e1714]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (2541 ± 329 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	496	3706	2305	725	348
		domContentLoaded	1602	3389	2148	457	220
		load	1728	4132	2541	685	329
		domInteractive	25	186	62	44	21
		backgroundConnect	93	1088	385	261	125
		firstReactRender	26	285	89	58	28
		getState	10	576	148	122	59
		initialActions	0	1	0	0	0
		loadScripts	1168	2138	1527	263	126
		setupStore	10	291	80	63	30
		uiStartup	2022	9951	4097	1797	863

Bundle size diffs [🚀 Bundle size reduced!]

background: -148 Bytes (-0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

test/e2e/tests/notifications/enable-notifications-with-accounts-sync.spec.ts

test/e2e/tests/identity/account-syncing/new-user-sync.spec.ts

test/e2e/tests/identity/account-syncing/importing-private-key-account.spec.ts

seaona

LGTM! Thank you for the prompt fix 😍

metamaskbot · 2025-03-21T12:30:16Z

Builds ready [2a67321]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (2628 ± 362 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	597	4039	2334	857	411
		domContentLoaded	1644	3783	2315	508	244
		load	1814	4517	2628	755	362
		domInteractive	29	207	70	55	26
		backgroundConnect	26	1680	290	376	181
		firstReactRender	22	136	72	36	17
		getState	16	558	145	164	79
		initialActions	0	1	0	0	0
		loadScripts	1198	2300	1680	309	148
		setupStore	10	321	71	84	40
		uiStartup	2159	11910	4017	2373	1139

Bundle size diffs [🚀 Bundle size reduced!]

background: -148 Bytes (-0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

test/e2e/tests/identity/account-syncing/onboarding-with-opt-out.spec.ts

metamaskbot · 2025-03-21T14:19:07Z

Builds ready [32e6368]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (3701 ± 1625 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1722	13396	3432	3144	1509
		domContentLoaded	1635	12390	3127	2951	1417
		load	1731	13957	3701	3384	1625
		domInteractive	21	526	96	119	57
		backgroundConnect	99	1631	549	460	221
		firstReactRender	27	309	108	62	30
		getState	30	1476	272	342	164
		initialActions	0	2	0	1	0
		loadScripts	1197	11111	2435	2737	1314
		setupStore	13	541	134	140	67
		uiStartup	2074	23088	6193	5128	2463

Bundle size diffs [🚀 Bundle size reduced!]

background: -148 Bytes (-0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2025-03-25T08:11:46Z

Builds ready [46d44fa]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (3503 ± 1662 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1496	15073	3326	3403	1634
		domContentLoaded	1427	14950	3078	3326	1597
		load	1501	15067	3503	3462	1662
		domInteractive	24	890	91	186	89
		backgroundConnect	50	1454	390	342	164
		firstReactRender	28	223	87	49	24
		getState	24	739	230	197	94
		initialActions	0	2	0	1	0
		loadScripts	1049	14556	2450	3218	1545
		setupStore	9	456	115	116	56
		uiStartup	1751	15415	5694	4455	2139

Bundle size diffs [🚀 Bundle size reduced!]

background: -148 Bytes (-0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2025-03-25T08:49:46Z

Builds ready [9167b4f]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (3358 ± 1222 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1731	12727	3082	2326	1117
		domContentLoaded	1627	12180	2712	2216	1064
		load	1745	13744	3358	2545	1222
		domInteractive	28	443	79	98	47
		backgroundConnect	124	1786	600	516	248
		firstReactRender	22	454	115	98	47
		getState	34	1183	271	276	132
		initialActions	0	1	0	0	0
		loadScripts	1181	10395	2004	1943	933
		setupStore	11	987	141	212	102
		uiStartup	2137	18131	5905	4065	1952

Bundle size diffs [🚀 Bundle size reduced!]

background: -148 Bytes (-0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2025-03-25T09:54:14Z

Builds ready [12f4820]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (2893 ± 333 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1779	3807	2585	559	269
		domContentLoaded	1634	3518	2282	482	231
		load	1861	4356	2893	694	333
		domInteractive	26	144	50	25	12
		backgroundConnect	123	1280	573	313	150
		firstReactRender	33	256	101	56	27
		getState	39	765	279	185	89
		initialActions	0	1	0	0	0
		loadScripts	1209	2411	1591	327	157
		setupStore	13	511	147	112	54
		uiStartup	2718	10491	5817	2636	1266

Bundle size diffs [🚀 Bundle size reduced!]

background: -148 Bytes (-0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

seaona

LGTM! Thanks for the improvements 🙏

cmd-ob · 2025-03-25T13:03:41Z

Looks great @mathieuartu. I really like the new waits.

mirceanis

I love the new test setups

mathieuartu added 6 commits March 19, 2025 10:01

feat: enable account syncing on firefox

0802a35

test: (temp) run firefox e2e ci

0f85129

test: move timeout directly in the it statement

253babc

test: extend test duration

51ab942

fix: skip 1 account sync e2e for Firefox

866e0b5

test: ci e2e

d3b4f2a

mathieuartu self-assigned this Mar 20, 2025

metamaskbot added the team-identity label Mar 20, 2025

mathieuartu added 9 commits March 20, 2025 14:28

test: add delay after adding account

71539b2

test: add delays for all tests after adding accounts

3b6c9d8

test: try removing nested describe statements

b7426c7

Revert "test: try removing nested describe statements"

ada9c42

This reverts commit b7426c7.

fix: refactor account sync e2e tests so that they don't use async des…

230d4ac

…cribe

Merge branch 'main' into feat/account-sync-mv2

18e2bc8

fix: notifications import

00ef7da

fix: increase account sync notifications e2e test timeout

3a1c445

fix: increase timeouts for account sync e2e tests

96e1714

mathieuartu marked this pull request as ready for review March 21, 2025 11:30

mathieuartu requested review from a team as code owners March 21, 2025 11:30

fix: revert config.yml temp changes

2a67321

seaona reviewed Mar 21, 2025

View reviewed changes

test/e2e/tests/notifications/enable-notifications-with-accounts-sync.spec.ts Outdated Show resolved Hide resolved

seaona reviewed Mar 21, 2025

View reviewed changes

test/e2e/tests/identity/account-syncing/new-user-sync.spec.ts Outdated Show resolved Hide resolved

seaona reviewed Mar 21, 2025

View reviewed changes

test/e2e/tests/identity/account-syncing/importing-private-key-account.spec.ts Show resolved Hide resolved

seaona previously approved these changes Mar 21, 2025

View reviewed changes

mathieuartu changed the title ~~test: account sync mv2 re-enablement CI side effects~~ feat: enable account syncing for MV2 Mar 21, 2025

mirceanis previously approved these changes Mar 21, 2025

View reviewed changes

fix: move this.timeout statement to the top of the test

32e6368

mathieuartu dismissed stale reviews from mirceanis and seaona via 32e6368 March 21, 2025 13:36

mirceanis previously approved these changes Mar 21, 2025

View reviewed changes

davidmurdoch reviewed Mar 21, 2025

View reviewed changes

test/e2e/tests/identity/account-syncing/onboarding-with-opt-out.spec.ts Outdated Show resolved Hide resolved

fix: remove delay and wait for accounts to be synced

60cf491

mathieuartu dismissed mirceanis’s stale review via 60cf491 March 24, 2025 20:48

mathieuartu added 4 commits March 24, 2025 21:48

test: ci test drive for mv2

2ea604d

test: refactor test util

1f00626

fix: refactor test util

46d44fa

fix: refactor test util

9167b4f

fix: revert config.yml

12f4820

seaona approved these changes Mar 25, 2025

View reviewed changes

cmd-ob approved these changes Mar 25, 2025

View reviewed changes

mirceanis approved these changes Mar 25, 2025

View reviewed changes

mathieuartu added this pull request to the merge queue Mar 25, 2025

Merged via the queue into main with commit 07050c0 Mar 25, 2025
113 checks passed

mathieuartu deleted the feat/account-sync-mv2 branch March 25, 2025 14:12

github-actions bot locked and limited conversation to collaborators Mar 25, 2025

metamaskbot added the release-12.16.0 Issue or pull request that will be included in release 12.16.0 label Mar 25, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: enable account syncing for MV2 #31141

feat: enable account syncing for MV2 #31141

mathieuartu commented Mar 20, 2025 •

edited

Loading

github-actions bot commented Mar 20, 2025

metamaskbot commented Mar 21, 2025

seaona left a comment

metamaskbot commented Mar 21, 2025

metamaskbot commented Mar 21, 2025

metamaskbot commented Mar 25, 2025

metamaskbot commented Mar 25, 2025

metamaskbot commented Mar 25, 2025

seaona left a comment

cmd-ob commented Mar 25, 2025

mirceanis left a comment

feat: enable account syncing for MV2 #31141

feat: enable account syncing for MV2 #31141

Conversation

mathieuartu commented Mar 20, 2025 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Mar 20, 2025

metamaskbot commented Mar 21, 2025

seaona left a comment

Choose a reason for hiding this comment

metamaskbot commented Mar 21, 2025

metamaskbot commented Mar 21, 2025

metamaskbot commented Mar 25, 2025

metamaskbot commented Mar 25, 2025

metamaskbot commented Mar 25, 2025

seaona left a comment

Choose a reason for hiding this comment

cmd-ob commented Mar 25, 2025

mirceanis left a comment

Choose a reason for hiding this comment

mathieuartu commented Mar 20, 2025 •

edited

Loading