-
Notifications
You must be signed in to change notification settings - Fork 5.2k
fix: Updated styles for connections menu #31112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+30
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Builds ready [0d852b9]
Page Load Metrics (3385 ± 2560 ms)
Bundle size diffs
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Builds ready [fce0749]
Page Load Metrics (4025 ± 2821 ms)
Bundle size diffs
|
Builds ready [084beda]
Page Load Metrics (2674 ± 1079 ms)
Bundle size diffs
|
✨ Files requiring CODEOWNER review ✨🖥️ @MetaMask/wallet-ux
|
Builds ready [d523c25]
UI Startup Metrics (1189 ± 58 ms)
Bundle size diffs
|
vinnyhoward
previously approved these changes
Apr 1, 2025
Builds ready [fdd42fb]
UI Startup Metrics (1207 ± 62 ms)
Bundle size diffs
|
vinnyhoward
previously approved these changes
Apr 9, 2025
darkwing
reviewed
Apr 9, 2025
ui/components/multichain/connected-site-popover/connected-site-popover.tsx
Outdated
Show resolved
Hide resolved
Builds ready [2de519f]
UI Startup Metrics (1227 ± 57 ms)
|
Builds ready [55e662e]
UI Startup Metrics (1214 ± 61 ms)
|
Builds ready [c50591d]
UI Startup Metrics (1231 ± 52 ms)
|
vinnyhoward
approved these changes
Apr 10, 2025
gambinish
approved these changes
Apr 10, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
INVALID-PR-TEMPLATE
PR's body doesn't match template
release-12.18.0
Issue or pull request that will be included in release 12.18.0
team-wallet-ux
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to fix the design issues in Connections Menu
Related issues
Fixes: 4381
Manual testing steps
REMOVE_GNS=1 yarn start
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist