Skip to content

fix: Updated styles for connections menu #31112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Apr 15, 2025
Merged

Conversation

NidhiKJha
Copy link
Member

This PR is to fix the design issues in Connections Menu

Related issues

Fixes: 4381

Manual testing steps

  1. Run extension with REMOVE_GNS=1 yarn start
  • Hover behavior
  • Overlapping menus behavior - - will be handled in a separate PR because it needs header update
  • Menu vertical position
  • Text styling
  • Connection menu links
  • Text size for network link
  • Network modal title and sections - will be handled in a separate PR, it needs network menu update

Screenshots/Recordings

Before

After

Screenshot 2025-03-19 at 7 23 15 PM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@NidhiKJha NidhiKJha requested a review from a team as a code owner March 19, 2025 13:53
@metamaskbot metamaskbot added team-wallet-ux INVALID-PR-TEMPLATE PR's body doesn't match template labels Mar 19, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [0d852b9]
Page Load Metrics (3385 ± 2560 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint39226523320153872587
domContentLoaded156926407322453302559
load159926544338553322560
domInteractive26462719345
backgroundConnect1148416215574
firstReactRender18181684220
getState6320759244
initialActions01000
loadScripts111725105262651622478
setupStore899393014
uiStartup177626913418253342561
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 324 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [fce0749]
Page Load Metrics (4025 ± 2821 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint156626351393858892828
domContentLoaded149526236379158832825
load155526370402558762821
domInteractive251032123235113
backgroundConnect2463725120297
firstReactRender16151674622
getState863212616177
initialActions01000
loadScripts110725712316357412757
setupStore8217607034
uiStartup177326617546859642864
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 324 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [084beda]
Page Load Metrics (2674 ± 1079 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint157912144254822201066
domContentLoaded154811841238221841049
load158512356267422471079
domInteractive26138522713
backgroundConnect4057830016077
firstReactRender26181904622
getState3045214011455
initialActions01000
loadScripts11331072718412045982
setupStore113609610651
uiStartup190314176439227551323
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 324 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@metamaskbot
Copy link
Collaborator

metamaskbot commented Mar 30, 2025

✨ Files requiring CODEOWNER review ✨

🖥️ @MetaMask/wallet-ux

  • ui/components/multichain/connected-site-menu/index.scss
  • ui/components/multichain/connected-site-popover/connected-site-popover.tsx

@metamaskbot
Copy link
Collaborator

Builds ready [d523c25]
UI Startup Metrics (1189 ± 58 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1189106614035812231299
load10389421215511215986
domContentLoaded1032937120751940987
domInteractive16132941626
firstPaint7291651218408237977
backgroundConnect10614213910
firstReactRender18135441821
getState10434768
initialActions001001
loadScripts81870898951843893
setupStore8538478
WebpackHomeuiStartup951836126678960978
load80561395064839905
domContentLoaded79959894164834901
domInteractive15124461333
firstPaint45957924337830856
backgroundConnect16105281539
firstReactRender14123141326
getState6414178
initialActions001001
loadScripts79758892764833900
setupStore7515289
FirefoxBrowserifyHomeuiStartup13621169187013613901743
load12211028170312812521531
domContentLoaded12211028170212812521530
domInteractive9741245299098
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect23177392439
firstReactRender23187972329
getState6419278
initialActions001001
loadScripts11991012168012712311502
setupStore8490968
WebpackHomeuiStartup10308461641170931962
load8997411489151837931
domContentLoaded8987411489151837931
domInteractive116322362915795
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect221491112636
firstReactRender20173632026
getState114881389
initialActions001001
loadScripts8797281458147825949
setupStore10563989
Bundle size diffs
  • background: 0 Bytes (0%)
  • ui: 324 Bytes (0%)
  • common: 0 Bytes (0%)

vinnyhoward
vinnyhoward previously approved these changes Apr 1, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [fdd42fb]
UI Startup Metrics (1207 ± 62 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1207108314726212461299
load1057923132868923995
domContentLoaded1051916132469920993
domInteractive17136891527
firstPaint768791175400269987
backgroundConnect96334910
firstReactRender21145481942
getState11436768
initialActions001001
loadScripts802668106467847893
setupStore8520378
WebpackHomeuiStartup21761754258119223382433
load16961297198815118071900
domContentLoaded16901292196415118011894
domInteractive171266121456
firstPaint171685787223492
backgroundConnect321390164369
firstReactRender192553721186391
getState1433263289
initialActions812793735
loadScripts16801285193614917921875
setupStore416313753067
FirefoxBrowserifyHomeuiStartup14001172191915614651758
load12591059176214713251598
domContentLoaded12591059176214713251598
domInteractive10838207329298
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2615228222747
firstReactRender22195242327
getState7427478
initialActions002001
loadScripts12341043173614113021570
setupStore6413268
WebpackHomeuiStartup15171330215214815731846
load13091150192214213531624
domContentLoaded13091150192214213531624
domInteractive9036176239097
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect25194862742
firstReactRender34294853845
getState8430579
initialActions002111
loadScripts12861131189514213321600
setupStore8529389
Bundle size diffs
  • background: 0 Bytes (0%)
  • ui: 324 Bytes (0%)
  • common: 0 Bytes (0%)

vinnyhoward
vinnyhoward previously approved these changes Apr 9, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [2de519f]
UI Startup Metrics (1227 ± 57 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1227111314105712621317
load10789751245511120989
domContentLoaded10729711237511115987
domInteractive17136571630
firstPaint72781114943019781
backgroundConnect96222910
firstReactRender20145262136
getState12545868
initialActions001001
loadScripts82572797050859899
setupStore7514278
WebpackHomeuiStartup21671736261017122812450
load17161352214914617982014
domContentLoaded17111347214414517942005
domInteractive171278121452
firstPaint158633766128093
backgroundConnect3411277353961
firstReactRender168523681106094
getState1933134379
initialActions316135
loadScripts17011337213914117881973
setupStore2162443369
FirefoxBrowserifyHomeuiStartup13911206171310814551612
load12431082159210313071442
domContentLoaded12431082159210313071442
domInteractive10738269339197
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect271767112952
firstReactRender22193832327
getState8436579
initialActions001001
loadScripts12171059157610412821425
setupStore7440567
WebpackHomeuiStartup16201381229116917102011
load13871180206415214701710
domContentLoaded13861180206415214701710
domInteractive9640171239198
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2819238222936
firstReactRender38297274153
getState1543104289
initialActions102111
loadScripts13601156203914714461625
setupStore9531489

@metamaskbot
Copy link
Collaborator

Builds ready [55e662e]
UI Startup Metrics (1214 ± 61 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1214109813976112501323
load10659631210571153995
domContentLoaded10599571205571154991
domInteractive16136281528
firstPaint7241321189419250992
backgroundConnect96494910
firstReactRender18143532023
getState135921179
initialActions001001
loadScripts81369394957855908
setupStore7516278
WebpackHomeuiStartup22101803270517723332412
load17491348213714918102056
domContentLoaded17411345212614518062019
domInteractive171267111453
firstPaint170647138323879
backgroundConnect4011334523657
firstReactRender171533551126090
getState2243054659
initialActions317147
loadScripts17291342209013618001967
setupStore24625038368
FirefoxBrowserifyHomeuiStartup13501173180312114041620
load12151027168811812601469
domContentLoaded12141027168711812601469
domInteractive10637349438896
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2416213202334
firstReactRender21184832126
getState7421279
initialActions002001
loadScripts11921010167111712411444
setupStore842632667
WebpackHomeuiStartup15191362186311015841740
load13091170162510013711489
domContentLoaded13081170162510013711489
domInteractive9236231258694
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect24184042534
firstReactRender35285553747
getState9434689
initialActions102111
loadScripts1286114716059913421471
setupStore7548489

@metamaskbot
Copy link
Collaborator

Builds ready [c50591d]
UI Startup Metrics (1231 ± 52 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1231113113465212731330
load10769731187501123975
domContentLoaded10709681176501117982
domInteractive18136591733
firstPaint72380118542422980
backgroundConnect7449479
firstReactRender19153932024
getState14534878
initialActions001001
loadScripts82472691648860909
setupStore8522379
WebpackHomeuiStartup21831729251217423172448
load17301350223715817892008
domContentLoaded17241341223315717842001
domInteractive171265101547
firstPaint157673314822090
backgroundConnect289235243357
firstReactRender161533691036291
getState1743183179
initialActions316146
loadScripts17161340223014917821963
setupStore23719030358
FirefoxBrowserifyHomeuiStartup13411150178411814101600
load11991034166411412621436
domContentLoaded11991034166411412621435
domInteractive10138235329098
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect20138592038
firstReactRender22186252227
getState7448579
initialActions002001
loadScripts11811008165011512491412
setupStore1031982767
WebpackHomeuiStartup15241324193613116131792
load13141154165611413871575
domContentLoaded13141153165611413871574
domInteractive10152352398897
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect20144572140
firstReactRender35286563647
getState9550679
initialActions001011
loadScripts12961140163611313721555
setupStore1152792789

@NidhiKJha NidhiKJha added this pull request to the merge queue Apr 15, 2025
Merged via the queue into main with commit b99e729 Apr 15, 2025
166 checks passed
@NidhiKJha NidhiKJha deleted the fix-connections-menu-dqa branch April 15, 2025 15:08
@github-actions github-actions bot locked and limited conversation to collaborators Apr 15, 2025
@metamaskbot metamaskbot added the release-12.18.0 Issue or pull request that will be included in release 12.18.0 label Apr 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template release-12.18.0 Issue or pull request that will be included in release 12.18.0 team-wallet-ux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants