Skip to content

feat: reject pending confirmations for origin when permissions are revoked for it #31074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 19, 2025

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Mar 18, 2025

Description

reject pending confirmations for origin when permissions are revoked for it

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/4443

Manual testing steps

  1. Enable EVM multichain locally
  2. Go to test dapp and create a confirmation
  3. Revoke permissions, check that pending confirmation is rejected

Screenshots/Recordings

Screen.Recording.2025-03-18.at.7.13.37.PM.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jpuri jpuri added the team-confirmations Push issues to confirmations team label Mar 18, 2025
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@jpuri jpuri enabled auto-merge March 18, 2025 14:08
@metamaskbot
Copy link
Collaborator

Builds ready [802a085]
Page Load Metrics (4251 ± 2098 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint169920519402443272078
domContentLoaded158620421373842962063
load163120549425143682098
domInteractive2790512319192
backgroundConnect781292472372178
firstReactRender2155611311053
getState23737245228110
initialActions00000
loadScripts115619374298341261981
setupStore1132312111354
uiStartup199121092643251432469
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 73 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@jpuri jpuri added this pull request to the merge queue Mar 19, 2025
Merged via the queue into main with commit d8476fb Mar 19, 2025
76 checks passed
@jpuri jpuri deleted the revoke_permission_fix branch March 19, 2025 08:56
@github-actions github-actions bot locked and limited conversation to collaborators Mar 19, 2025
@metamaskbot metamaskbot added the release-12.16.0 Issue or pull request that will be included in release 12.16.0 label Mar 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.16.0 Issue or pull request that will be included in release 12.16.0 team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants