Skip to content

fix(#14716): fix send invalid hex data #31040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Mar 20, 2025
Merged

fix(#14716): fix send invalid hex data #31040

merged 8 commits into from
Mar 20, 2025

Conversation

GustavoRSSilva
Copy link
Contributor

@GustavoRSSilva GustavoRSSilva commented Mar 17, 2025

Description

At the moment it is possible to try to send invlid ehx data, just to be blocked on the next step, prevent to move the screen with invalid hex data

Open in GitHub Codespaces

Related issues

Fixes: #14716

Manual testing steps

  1. Go to sent page
  2. add hex data
  3. Try to send invalid hex data

Screenshots/Recordings

Before

After

Screenshot 2025-03-17 at 10 51 26
Screenshot 2025-03-17 at 10 51 33

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@GustavoRSSilva GustavoRSSilva requested review from a team as code owners March 17, 2025 10:58
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-swaps-and-bridge For issues with Swaps or Bridging label Mar 17, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [cea0d21]
Page Load Metrics (4909 ± 1938 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint47814813416237211787
domContentLoaded173314562447639041875
load177714838490940361938
domInteractive291969284482231
backgroundConnect501171428367176
firstReactRender17270937234
getState2763418518689
initialActions01000
loadScripts127014088379538491848
setupStore1148910012158
uiStartup204015865660943192074
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 612 Bytes (0.01%)
  • common: 532 Bytes (0.00%)

Copy link
Contributor

@vinnyhoward vinnyhoward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@GustavoRSSilva GustavoRSSilva added this pull request to the merge queue Mar 20, 2025
Merged via the queue into main with commit b1ea09b Mar 20, 2025
76 checks passed
@GustavoRSSilva GustavoRSSilva deleted the fix-send-hexdata branch March 20, 2025 21:29
@github-actions github-actions bot locked and limited conversation to collaborators Mar 20, 2025
@metamaskbot metamaskbot added the release-12.16.0 Issue or pull request that will be included in release 12.16.0 label Mar 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.16.0 Issue or pull request that will be included in release 12.16.0 team-swaps-and-bridge For issues with Swaps or Bridging
Projects
None yet
5 participants