feat: allows pasting external addresses for crosschain bridges #30995

ghgoodreau · 2025-03-13T21:28:54Z

Description

• If user has no Solana account: no external account pasting option
• If user has Solana account: user can select dropdown any Solana accounts they have, and otherwise paste in an external account for dest account

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/MMS-2103

Manual testing steps

Create an EVM <-> SOL bridge (either direction)
In the account picker, paste in an external account
Notice that you can select the external account

Screenshots/Recordings

Before

After

Screen.Recording.2025-03-18.at.1.33.24.PM.mov

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2025-03-13T21:29:05Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2025-03-13T22:05:33Z

Builds ready [a895d3c]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (4262 ± 1809 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1817	16859	4022	3644	1750
		domContentLoaded	1718	16361	3711	3539	1700
		load	1860	17092	4262	3768	1809
		domInteractive	28	1472	194	341	164
		backgroundConnect	91	1699	508	410	197
		firstReactRender	28	173	91	40	19
		getState	28	629	232	174	84
		initialActions	0	1	0	0	0
		loadScripts	1297	15076	2962	3302	1585
		setupStore	14	380	110	96	46
		uiStartup	2422	17559	6345	4302	2066

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 971 Bytes (0.01%)
common: 45 Bytes (0.00%)

metamaskbot · 2025-03-13T23:33:14Z

Builds ready [0338d57]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (4489 ± 1927 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	506	17151	4016	4023	1932
		domContentLoaded	1601	16543	3739	3893	1870
		load	1688	17641	4489	4014	1927
		domInteractive	27	1133	147	255	122
		backgroundConnect	89	1790	687	438	210
		firstReactRender	19	567	164	120	57
		getState	25	929	390	251	121
		initialActions	0	1	0	0	0
		loadScripts	1212	15109	2972	3671	1763
		setupStore	10	537	191	136	65
		uiStartup	1966	21146	7446	4752	2282

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 971 Bytes (0.01%)
common: 45 Bytes (0.00%)

…account

metamaskbot · 2025-03-18T20:45:52Z

Builds ready [5b9e54b]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (2753 ± 984 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1692	9986	2528	1728	830
		domContentLoaded	1573	9287	2305	1613	775
		load	1710	11558	2753	2049	984
		domInteractive	27	245	52	50	24
		backgroundConnect	137	1938	432	388	186
		firstReactRender	37	298	95	56	27
		getState	42	1141	203	233	112
		initialActions	0	1	0	0	0
		loadScripts	1134	8103	1712	1471	706
		setupStore	19	377	87	95	46
		uiStartup	2233	22667	5261	4828	2318

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 3.69 KiB (0.05%)
common: 45 Bytes (0.00%)

ui/pages/bridge/prepare/components/destination-account-picker.tsx

metamaskbot · 2025-03-19T00:11:35Z

Builds ready [89b03bb]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (2616 ± 395 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	812	5333	2265	828	398
		domContentLoaded	1621	5200	2190	852	409
		load	1707	5325	2616	823	395
		domInteractive	26	202	60	50	24
		backgroundConnect	93	846	394	192	92
		firstReactRender	21	203	97	45	21
		getState	12	478	226	145	70
		initialActions	0	1	0	0	0
		loadScripts	1188	3721	1572	633	304
		setupStore	10	392	136	107	52
		uiStartup	2100	8293	4795	1667	800

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 3.69 KiB (0.05%)
common: 45 Bytes (0.00%)

shared/types/bridge.ts

ui/pages/bridge/prepare/components/destination-selected-account-list-item.tsx

ui/pages/bridge/prepare/components/external-account-list-item.tsx

metamaskbot · 2025-03-19T18:38:08Z

Builds ready [fd172ee]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (3959 ± 1850 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	331	14798	3635	3893	1869
		domContentLoaded	1509	14476	3554	3728	1790
		load	1577	14844	3959	3854	1850
		domInteractive	24	5017	327	1080	518
		backgroundConnect	74	1067	391	312	150
		firstReactRender	22	212	85	51	24
		getState	13	924	192	234	112
		initialActions	0	1	0	0	0
		loadScripts	1104	13863	2880	3556	1708
		setupStore	10	381	102	106	51
		uiStartup	1842	19606	5889	4814	2311

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 3.68 KiB (0.05%)
common: 45 Bytes (0.00%)

metamaskbot · 2025-03-19T19:46:19Z

Builds ready [84a8f23]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (2705 ± 473 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1624	5195	2455	825	396
		domContentLoaded	1545	4371	2118	650	312
		load	1635	5791	2705	985	473
		domInteractive	27	296	82	71	34
		backgroundConnect	99	1218	576	356	171
		firstReactRender	41	173	104	38	18
		getState	38	635	235	168	81
		initialActions	0	0	0	0	0
		loadScripts	1148	2888	1455	390	187
		setupStore	14	327	122	88	42
		uiStartup	2264	16481	5781	3425	1645

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 3.68 KiB (0.05%)
common: 45 Bytes (0.00%)

Copilot

Pull Request Overview

This PR adds functionality to support pasting external addresses for crosschain bridges, allowing users with a Solana account to either select from their accounts or paste an external account.

Introduces a new ExternalAccountListItem component to render external accounts.
Adds types for ExternalAccount and a union type DestinationAccount.
Updates the destination account picker and selected account list item components to support both internal and external accounts, and adjusts the account hook accordingly.

Reviewed Changes

Copilot reviewed 5 out of 7 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
ui/pages/bridge/prepare/components/external-account-list-item.tsx	New component to display external account details
ui/pages/bridge/prepare/types.ts	Introduces ExternalAccount and DestinationAccount types
ui/pages/bridge/prepare/components/destination-account-picker.tsx	Integrates external account creation and selection logic
ui/pages/bridge/prepare/components/destination-selected-account-list-item.tsx	Adjusts display logic based on account type
ui/pages/bridge/hooks/useDestinationAccount.ts	Updates state type to DestinationAccount (state destructuring issue)

Files not reviewed (2)

app/_locales/en/messages.json: Language not supported
app/_locales/en_GB/messages.json: Language not supported

Comments suppressed due to low confidence (1)

ui/pages/bridge/hooks/useDestinationAccount.ts:19

The state initialization is missing a destructuring assignment. Please update it to '[selectedDestinationAccount, setSelectedDestinationAccount] = useState<DestinationAccount | null>(null);' to properly capture and use the state.

useState<DestinationAccount | null>(null);

feat: allows pasting external addresses and autoselecting them

a895d3c

metamaskbot added the team-swaps-and-bridge For issues with Swaps or Bridging label Mar 13, 2025

fix: fix lint, add localization to en_GB file

0338d57

ghgoodreau added 4 commits March 17, 2025 14:13

fix: shared type, fix lint error

0cbf2a3

fix: types

6e564ec

feat: adds externalaccountlistitem instead of autoselecting external …

c9eb348

…account

fix: types

d5b2a58

ghgoodreau changed the title ~~feat: allows pasting external addresses and autoselecting them~~ feat: allows pasting external addresses for crosschain bridges Mar 18, 2025

ghgoodreau added 2 commits March 18, 2025 13:57

chore: fixes import lint

a429e2d

Merge branch 'main' into mms-2103-external-accts

5b9e54b

ghgoodreau marked this pull request as ready for review March 18, 2025 20:39

ghgoodreau requested a review from a team as a code owner March 18, 2025 20:39

Merge branch 'main' into mms-2103-external-accts

3bfc344

GustavoRSSilva reviewed Mar 18, 2025

View reviewed changes

ui/pages/bridge/prepare/components/destination-account-picker.tsx Outdated Show resolved Hide resolved

GustavoRSSilva previously approved these changes Mar 18, 2025

View reviewed changes

chore: export DestinationAccount type

7709b3a

ghgoodreau dismissed GustavoRSSilva’s stale review via 7709b3a March 18, 2025 23:32

Merge branch 'main' into mms-2103-external-accts

89b03bb

GustavoRSSilva previously approved these changes Mar 19, 2025

View reviewed changes

micaelae reviewed Mar 19, 2025

View reviewed changes

shared/types/bridge.ts Outdated Show resolved Hide resolved

micaelae reviewed Mar 19, 2025

View reviewed changes

shared/types/bridge.ts Outdated Show resolved Hide resolved

micaelae reviewed Mar 19, 2025

View reviewed changes

ui/pages/bridge/prepare/components/destination-selected-account-list-item.tsx Outdated Show resolved Hide resolved

micaelae reviewed Mar 19, 2025

View reviewed changes

ui/pages/bridge/prepare/components/external-account-list-item.tsx Outdated Show resolved Hide resolved

micaelae reviewed Mar 19, 2025

View reviewed changes

ui/pages/bridge/prepare/components/external-account-list-item.tsx Outdated Show resolved Hide resolved

chore: address comments

d270b59

ghgoodreau dismissed GustavoRSSilva’s stale review via d270b59 March 19, 2025 17:38

ghgoodreau added 2 commits March 19, 2025 12:44

fix: import

a7e5576

fix: lint

fd172ee

Merge branch 'main' into mms-2103-external-accts

84a8f23

ghgoodreau enabled auto-merge March 19, 2025 20:13

ghgoodreau requested review from micaelae and GustavoRSSilva March 19, 2025 21:07

GustavoRSSilva approved these changes Mar 19, 2025

View reviewed changes

micaelae requested a review from Copilot March 19, 2025 22:03

Copilot AI reviewed Mar 19, 2025

View reviewed changes

micaelae approved these changes Mar 19, 2025

View reviewed changes

ghgoodreau added this pull request to the merge queue Mar 19, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 19, 2025

ghgoodreau added this pull request to the merge queue Mar 19, 2025

Merged via the queue into main with commit 5fa926d Mar 19, 2025
77 checks passed

ghgoodreau deleted the mms-2103-external-accts branch March 19, 2025 23:45

github-actions bot locked and limited conversation to collaborators Mar 19, 2025

metamaskbot added the release-12.16.0 Issue or pull request that will be included in release 12.16.0 label Mar 19, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: allows pasting external addresses for crosschain bridges #30995

feat: allows pasting external addresses for crosschain bridges #30995

ghgoodreau commented Mar 13, 2025 •

edited

Loading

github-actions bot commented Mar 13, 2025

metamaskbot commented Mar 13, 2025

metamaskbot commented Mar 13, 2025

metamaskbot commented Mar 18, 2025

metamaskbot commented Mar 19, 2025

metamaskbot commented Mar 19, 2025

metamaskbot commented Mar 19, 2025

Copilot AI left a comment

feat: allows pasting external addresses for crosschain bridges #30995

feat: allows pasting external addresses for crosschain bridges #30995

Conversation

ghgoodreau commented Mar 13, 2025 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Mar 13, 2025

metamaskbot commented Mar 13, 2025

metamaskbot commented Mar 13, 2025

metamaskbot commented Mar 18, 2025

metamaskbot commented Mar 19, 2025

metamaskbot commented Mar 19, 2025

metamaskbot commented Mar 19, 2025

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

ghgoodreau commented Mar 13, 2025 •

edited

Loading