feat: mms-1876 swap pre populated #30929

GustavoRSSilva · 2025-03-12T11:46:51Z

Description

Set a default token populated when going to the swap page

Related issues

Fixes:

Manual testing steps

Go to the swap page
Check token populated

Screenshots/Recordings

Before

After

Screen.Recording.2025-03-12.at.11.44.16.mov

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2025-03-12T11:47:09Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2025-03-12T21:42:38Z

Builds ready [8c6052c]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (2031 ± 149 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1663	2600	1991	247	119
		domContentLoaded	1635	2403	1876	175	84
		load	1664	2892	2031	311	149
		domInteractive	25	73	36	13	6
		backgroundConnect	11	594	150	165	79
		firstReactRender	15	153	51	39	19
		getState	6	410	72	104	50
		initialActions	0	1	0	0	0
		loadScripts	1204	1823	1428	129	62
		setupStore	8	189	35	49	23
		uiStartup	1847	5410	2696	961	461

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 170 Bytes (0.00%)
common: 2.27 KiB (0.02%)

micaelae · 2025-03-12T22:05:04Z

ui/pages/swaps/prepare-swap-page/prepare-swap-page.js

@@ -754,6 +755,15 @@ export default function PrepareSwapPage({
    }
  }, [showQuotesLoadingAnimation]);

+  // Set the default destination token for the swap
+  useEffect(() => {
+    if (!selectedToToken?.address && DEFAULT_TO_TOKEN_BY_NETWORK[chainId]) {


Can you add a condition here to skip pre-populating the toToken if the default token === fromToken?

Repro steps:

From homepage, go to asset details page for the default token (i.e, USDC on ethereum)

Click Swap from there

See that the Swap page has USDC -> USDC filled in, which is an invalid route

updating it.

Thanks @micaelae , I refactored the PR, to use a hook, not only we need to take that edge case, but always return one of the main from and to pair.

…mask-extension into mms-1876-swap-prepopulated

metamaskbot · 2025-03-13T11:24:16Z

Builds ready [dc6fd5e]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (2200 ± 191 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	448	2732	2042	483	232
		domContentLoaded	1691	2757	2088	307	148
		load	1716	3045	2200	398	191
		domInteractive	27	191	54	40	19
		backgroundConnect	17	621	119	159	76
		firstReactRender	15	123	44	30	15
		getState	6	176	50	52	25
		initialActions	0	1	0	0	0
		loadScripts	1253	2074	1570	230	110
		setupStore	8	89	33	30	14
		uiStartup	1978	4885	2759	863	414

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 1.67 KiB (0.02%)
common: 2.27 KiB (0.02%)

metamaskbot · 2025-03-13T15:30:11Z

Builds ready [b28ecff]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (5090 ± 2687 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	470	15974	4003	4022	1931
		domContentLoaded	1758	22132	4743	5586	2682
		load	1876	22220	5090	5595	2687
		domInteractive	27	1199	162	309	148
		backgroundConnect	94	934	342	238	114
		firstReactRender	25	153	71	36	17
		getState	23	423	162	123	59
		initialActions	0	1	0	0	0
		loadScripts	1328	21033	4068	5447	2616
		setupStore	12	247	86	76	37
		uiStartup	2190	22417	6674	5607	2692

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 1.67 KiB (0.02%)
common: 2.27 KiB (0.02%)

metamaskbot · 2025-03-13T16:51:37Z

Builds ready [bdd3c6c]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (4027 ± 2571 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	431	26913	3406	5459	2621
		domContentLoaded	1752	26796	3672	5387	2587
		load	1868	26834	4027	5354	2571
		domInteractive	27	724	94	152	73
		backgroundConnect	44	1147	361	317	152
		firstReactRender	21	134	78	36	17
		getState	10	776	180	180	87
		initialActions	0	1	0	0	0
		loadScripts	1322	26286	3000	5373	2580
		setupStore	11	415	84	98	47
		uiStartup	2408	27062	5470	5321	2555

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 1.67 KiB (0.02%)
common: 2.27 KiB (0.02%)

metamaskbot · 2025-03-13T18:15:33Z

Builds ready [11a2614]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (2967 ± 728 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1765	7732	2734	1354	650
		domContentLoaded	1666	7198	2468	1229	590
		load	1786	8452	2967	1516	728
		domInteractive	27	267	73	64	31
		backgroundConnect	135	1050	459	279	134
		firstReactRender	55	158	93	29	14
		getState	58	721	246	183	88
		initialActions	0	1	0	0	0
		loadScripts	1243	5828	1789	986	473
		setupStore	31	324	114	81	39
		uiStartup	2609	11088	4789	2214	1063

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 1.67 KiB (0.02%)
common: 2.27 KiB (0.02%)

feat: mms-1876 swap pre populated

8edda19

GustavoRSSilva requested a review from a team as a code owner March 12, 2025 11:46

metamaskbot added the team-swaps-and-bridge For issues with Swaps or Bridging label Mar 12, 2025

GustavoRSSilva added 2 commits March 12, 2025 11:48

Merge branch 'main' into mms-1876-swap-prepopulated

a7389bc

Merge branch 'main' into mms-1876-swap-prepopulated

8c6052c

ghgoodreau previously approved these changes Mar 12, 2025

View reviewed changes

micaelae reviewed Mar 12, 2025

View reviewed changes

GustavoRSSilva added 2 commits March 13, 2025 10:49

mms-1876: swap default pair

b75e9d7

Merge branch 'mms-1876-swap-prepopulated' of github.com:MetaMask/meta…

dc6fd5e

…mask-extension into mms-1876-swap-prepopulated

GustavoRSSilva dismissed ghgoodreau’s stale review via dc6fd5e March 13, 2025 10:50

mms-1876: swap default pair

b28ecff

GustavoRSSilva requested review from micaelae and ghgoodreau March 13, 2025 14:56

GustavoRSSilva added 2 commits March 13, 2025 16:12

Merge branch 'main' into mms-1876-swap-prepopulated

bdd3c6c

Merge branch 'main' into mms-1876-swap-prepopulated

111a3ea

ghgoodreau approved these changes Mar 13, 2025

View reviewed changes

GustavoRSSilva enabled auto-merge March 13, 2025 16:57

micaelae approved these changes Mar 13, 2025

View reviewed changes

Merge branch 'main' into mms-1876-swap-prepopulated

11a2614

GustavoRSSilva added this pull request to the merge queue Mar 13, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 13, 2025

GustavoRSSilva added this pull request to the merge queue Mar 13, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 13, 2025

GustavoRSSilva added this pull request to the merge queue Mar 13, 2025

Merged via the queue into main with commit 8eadf35 Mar 13, 2025
76 checks passed

GustavoRSSilva deleted the mms-1876-swap-prepopulated branch March 13, 2025 22:50

github-actions bot locked and limited conversation to collaborators Mar 13, 2025

metamaskbot added the release-12.16.0 Issue or pull request that will be included in release 12.16.0 label Mar 13, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: mms-1876 swap pre populated #30929

feat: mms-1876 swap pre populated #30929

GustavoRSSilva commented Mar 12, 2025 •

edited by github-actions bot

Loading

github-actions bot commented Mar 12, 2025

metamaskbot commented Mar 12, 2025

micaelae Mar 12, 2025

GustavoRSSilva Mar 12, 2025

GustavoRSSilva Mar 13, 2025

metamaskbot commented Mar 13, 2025

metamaskbot commented Mar 13, 2025

metamaskbot commented Mar 13, 2025

metamaskbot commented Mar 13, 2025

feat: mms-1876 swap pre populated #30929

feat: mms-1876 swap pre populated #30929

Conversation

GustavoRSSilva commented Mar 12, 2025 • edited by github-actions bot Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Mar 12, 2025

metamaskbot commented Mar 12, 2025

micaelae Mar 12, 2025

Choose a reason for hiding this comment

GustavoRSSilva Mar 12, 2025

Choose a reason for hiding this comment

GustavoRSSilva Mar 13, 2025

Choose a reason for hiding this comment

metamaskbot commented Mar 13, 2025

metamaskbot commented Mar 13, 2025

metamaskbot commented Mar 13, 2025

metamaskbot commented Mar 13, 2025

GustavoRSSilva commented Mar 12, 2025 •

edited by github-actions bot

Loading