Skip to content

style: Update tabs color, hover and animations #30907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 28, 2025
Merged

Conversation

amandaye0h
Copy link
Contributor

Description

This PR modifies the tab colors to improve the visual hierarchy of the page. It adds a hover effect and animations to make the transitions smoother.

Related issues

None

Manual testing steps

  1. Open MetaMask
  2. Hover and click on tabs

Screenshots/Recordings

Before

Screen.Recording.2025-03-11.at.10.10.32.PM.mov

After

Screen.Recording.2025-03-11.at.10.10.57.PM.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@amandaye0h amandaye0h requested a review from a team as a code owner March 11, 2025 14:18
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@amandaye0h
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@metamaskbot
Copy link
Collaborator

Builds ready [9aa545c]
Page Load Metrics (1954 ± 100 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint17192522195020699
domContentLoaded16962495190219795
load171925821954209100
domInteractive269138188
backgroundConnect18225614421
firstReactRender1679352211
getState7117202412
initialActions00000
loadScripts12801944145316680
setupStore869242110
uiStartup198130262280293141
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

vinnyhoward
vinnyhoward previously approved these changes Mar 13, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [964189c]
Page Load Metrics (3719 ± 2289 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint164924232344948222315
domContentLoaded154924119314548462327
load169624188371947672289
domInteractive23309596531
backgroundConnect761872580432208
firstReactRender222681186230
getState3188028020598
initialActions01000
loadScripts110223688250748742340
setupStore1238316412058
uiStartup234124325715752462519
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@metamaskbot
Copy link
Collaborator

✨ Files requiring CODEOWNER review ✨

🖥️ @MetaMask/wallet-ux

  • ui/components/multichain/account-overview/index.scss

@gambinish gambinish requested a review from vinnyhoward March 28, 2025 20:18
Copy link
Contributor

@vinnyhoward vinnyhoward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM!

@metamaskbot
Copy link
Collaborator

Builds ready [d7b10b5]
UI Startup Metrics (1193 ± 62 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1193107813896212341308
load1041926118260926987
domContentLoaded1035921117961941987
domInteractive16133641626
firstPaint756731168404245966
backgroundConnect107717910
firstReactRender18144241924
getState10426668
initialActions001001
loadScripts82271996559863922
setupStore7413278
WebpackHomeuiStartup930787124674947969
load78860293267830902
domContentLoaded78158492568825891
domInteractive15125771334
firstPaint46974930336823884
backgroundConnect17105691545
firstReactRender14122731324
getState6415278
initialActions001001
loadScripts77957491568823881
setupStore7517279
FirefoxBrowserifyHomeuiStartup13761174202716413901816
load12391063187715912621654
domContentLoaded12381062187715912611654
domInteractive9844181239197
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect23175862532
firstReactRender22194742231
getState6418278
initialActions001001
loadScripts12161045185115812341625
setupStore7419367
WebpackHomeuiStartup9958401511184895973
load8707271311160794889
domContentLoaded8707251311160793888
domInteractive114402052416096
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect221493142464
firstReactRender19164231925
getState104731379
initialActions001001
loadScripts8537161285156778870
setupStore8478779
Bundle size diffs
  • background: 0 Bytes (0%)
  • ui: 0 Bytes (0%)
  • common: 0 Bytes (0%)

@gambinish gambinish added this pull request to the merge queue Mar 28, 2025
Merged via the queue into main with commit 11a9d98 Mar 28, 2025
147 checks passed
@gambinish gambinish deleted the tabs-styling-update branch March 28, 2025 21:27
@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2025
@metamaskbot metamaskbot added the release-12.17.0 Issue or pull request that will be included in release 12.17.0 label Mar 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.17.0 Issue or pull request that will be included in release 12.17.0 team-assets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants