Skip to content

feat: bump assets-controllers to v55.0.1 and add PV to NFT tab #30903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 27 commits into from
Mar 24, 2025

Conversation

sahar-fehri
Copy link
Contributor

@sahar-fehri sahar-fehri commented Mar 11, 2025

Description

PR to add network filter to NFT tab.
This core PR MetaMask/core#5448 should be released before updating this one.

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Choose Ethereum mainnet
  2. Click on NFTs tab
  3. You should see network filter + your detected NFTs on Ethereum mainnet and linea (if you have any)
  4. Switch between networks and try importing manually your NFTs on networks that are not (Ethereum/linea)
  5. Make sure you see your NFTs correctly

Screenshots/Recordings

Before

After

Screen.Recording.2025-03-19.at.10.02.41.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@sahar-fehri
Copy link
Contributor Author

@metamaskbot update-policies

@metamaskbot
Copy link
Collaborator

Policies updated.
👀 Please review the diff for suspicious new powers.

🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

@sahar-fehri
Copy link
Contributor Author

@metamaskbot update-policies

@metamaskbot
Copy link
Collaborator

No policy changes

@sahar-fehri
Copy link
Contributor Author

@metamaskbot update-policies

@metamaskbot
Copy link
Collaborator

No policy changes

Copy link

socket-security bot commented Mar 17, 2025

New and updated dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/[email protected]55.0.1 None +2 2.99 MB metamaskbot
npm/@metamask/[email protected] None 0 99.3 kB metamaskbot

View full report↗︎

@sahar-fehri
Copy link
Contributor Author

@metamaskbot update-policies

@metamaskbot
Copy link
Collaborator

No policy changes

@sahar-fehri sahar-fehri changed the title feat: add PV to NFT tab feat: bump assets-controllers to v54 and add PV to NFT tab Mar 18, 2025
@sahar-fehri sahar-fehri added the DO-NOT-MERGE Pull requests that should not be merged label Mar 19, 2025
@sahar-fehri sahar-fehri dismissed stale reviews from Prithpal-Sooriya and NidhiKJha via d58c4c7 March 20, 2025 14:23
@sahar-fehri sahar-fehri changed the title feat: bump assets-controllers to v54 and add PV to NFT tab feat: bump assets-controllers to v55.0.1 and add PV to NFT tab Mar 20, 2025
@sahar-fehri
Copy link
Contributor Author

@metamaskbot update-policies

@metamaskbot
Copy link
Collaborator

No policy changes

@sahar-fehri sahar-fehri removed the DO-NOT-MERGE Pull requests that should not be merged label Mar 20, 2025
@sahar-fehri
Copy link
Contributor Author

@metamaskbot update-policies

@sahar-fehri sahar-fehri mentioned this pull request Mar 20, 2025
7 tasks
@metamaskbot
Copy link
Collaborator

No policy changes

@sahar-fehri sahar-fehri requested review from a team as code owners March 20, 2025 15:22
@sahar-fehri
Copy link
Contributor Author

@metamaskbot update-policies

@metamaskbot
Copy link
Collaborator

No policy changes

@metamaskbot
Copy link
Collaborator

Builds ready [1408f7e]
Page Load Metrics (3460 ± 892 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint20901008430921654794
domContentLoaded1928814526791281615
load21071120934601859892
domInteractive30275726330
backgroundConnect1642857784573275
firstReactRender313571548641
getState4971131219895
initialActions01000
loadScripts141553221880803386
setupStore1547416412761
uiStartup256614041653127481320
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 26 Bytes (0.00%)
  • ui: 1.62 KiB (0.02%)
  • common: 8.89 KiB (0.09%)

@sahar-fehri sahar-fehri added this pull request to the merge queue Mar 24, 2025
Merged via the queue into main with commit d310f9a Mar 24, 2025
76 checks passed
@sahar-fehri sahar-fehri deleted the feat/explicitly-send-chainIds-to-detectNFts branch March 24, 2025 15:44
@github-actions github-actions bot locked and limited conversation to collaborators Mar 24, 2025
@metamaskbot metamaskbot added the release-12.16.0 Issue or pull request that will be included in release 12.16.0 label Mar 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.16.0 Issue or pull request that will be included in release 12.16.0 team-assets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants