feat: Update blockaid friction modal copy #30809

pedronfigueiredo · 2025-03-06T10:43:13Z

Description

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/4328

Manual testing steps

Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2025-03-06T10:43:27Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2025-03-06T11:41:45Z

Builds ready [89119a6]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1520 ± 45 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1352	1684	1523	92	44
		domContentLoaded	1344	1660	1489	87	42
		load	1352	1689	1520	94	45
		domInteractive	23	79	34	17	8
		backgroundConnect	8	92	34	23	11
		firstReactRender	14	63	30	19	9
		getState	5	41	11	10	5
		initialActions	0	1	0	0	0
		loadScripts	957	1233	1109	74	36
		setupStore	7	45	12	10	5
		uiStartup	1560	1945	1726	100	48

metamaskbot · 2025-03-11T14:03:02Z

Builds ready [ab56d88]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1679 ± 62 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1439	2026	1679	129	62
		domContentLoaded	1431	1952	1651	124	59
		load	1440	2028	1679	129	62
		domInteractive	25	113	39	23	11
		backgroundConnect	10	78	31	20	10
		firstReactRender	15	71	36	22	11
		getState	4	18	9	3	2
		initialActions	0	1	0	0	0
		loadScripts	1045	1508	1229	106	51
		setupStore	8	57	16	16	8
		uiStartup	1657	2304	1898	148	71

metamaskbot · 2025-03-12T11:10:59Z

Builds ready [12aeb23]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (2028 ± 133 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	504	2672	1934	412	198
		domContentLoaded	1692	2429	1952	196	94
		load	1705	2802	2028	276	133
		domInteractive	25	102	41	19	9
		backgroundConnect	10	385	77	87	42
		firstReactRender	15	90	46	25	12
		getState	6	189	34	42	20
		initialActions	0	1	0	0	0
		loadScripts	1274	1850	1491	151	73
		setupStore	8	67	16	15	7
		uiStartup	1939	4322	2388	568	273

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 1.02 KiB (0.01%)
common: 867 Bytes (0.01%)

metamaskbot · 2025-03-13T11:17:35Z

Builds ready [a8137b0]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (2219 ± 121 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1822	2764	2184	217	104
		domContentLoaded	1793	2519	2082	174	84
		load	1826	2912	2219	253	121
		domInteractive	29	162	58	38	18
		backgroundConnect	25	558	140	131	63
		firstReactRender	16	145	50	36	17
		getState	14	224	65	56	27
		initialActions	0	1	0	0	0
		loadScripts	1371	1954	1585	143	69
		setupStore	9	64	27	20	10
		uiStartup	2049	4563	2811	617	296

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 1.02 KiB (0.01%)
common: 867 Bytes (0.01%)

digiwand · 2025-03-13T20:14:02Z

ui/components/app/alert-system/alert-modal/alert-modal.tsx

  return (
    <Text textAlign={TextAlign.Center} variant={TextVariant.bodyMd}>
-      {t('blockaidAlertInfo')}
+      {copy}


do we have tests for this UI?

vinistevam · 2025-03-14T08:14:16Z

ui/components/app/alert-system/alert-modal/alert-modal.tsx

+  const { securityAlertResponse } = currentConfirmation;
+
+  let copy;
+  switch (securityAlertResponse?.reason) {


@SayaGT Should this description, based on the security alert reason, also be reflected in the Alert System on mobile?

yes please! @vinistevam

Nice! I just created https://github.com/MetaMask/mobile-planning/issues/2169 .

metamaskbot · 2025-03-18T18:14:57Z

Builds ready [f87faf5]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (4327 ± 3110 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1930	32085	4151	6431	3088
		domContentLoaded	1757	31807	3920	6415	3080
		load	1959	32422	4327	6477	3110
		domInteractive	30	1192	141	249	119
		backgroundConnect	108	938	412	255	122
		firstReactRender	27	242	97	53	25
		getState	16	709	189	176	85
		initialActions	0	1	0	0	0
		loadScripts	1280	30189	3175	6204	2979
		setupStore	13	350	112	110	53
		uiStartup	2328	34098	6427	6756	3244

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 1.02 KiB (0.01%)
common: 867 Bytes (0.01%)

pedronfigueiredo added the team-confirmations Push issues to confirmations team label Mar 6, 2025

pedronfigueiredo self-assigned this Mar 6, 2025

digiwand previously approved these changes Mar 8, 2025

View reviewed changes

pedronfigueiredo dismissed digiwand’s stale review via ab56d88 March 11, 2025 13:25

pedronfigueiredo force-pushed the pnf/4328 branch from ab56d88 to 6e98abb Compare March 12, 2025 10:15

pedronfigueiredo force-pushed the pnf/4328 branch from 12aeb23 to a8137b0 Compare March 13, 2025 10:28

digiwand reviewed Mar 13, 2025

View reviewed changes

digiwand previously approved these changes Mar 13, 2025

View reviewed changes

OGPoyraz previously approved these changes Mar 14, 2025

View reviewed changes

vinistevam reviewed Mar 14, 2025

View reviewed changes

vinistevam previously approved these changes Mar 14, 2025

View reviewed changes

pedronfigueiredo dismissed stale reviews from vinistevam, OGPoyraz, and digiwand via 7264b8e March 18, 2025 14:06

vinistevam approved these changes Mar 18, 2025

View reviewed changes

pedronfigueiredo added 7 commits March 18, 2025 17:37

feat: Update blockaid friction modal copy

37d3834

feat: Update blockaid friction modal copy

72364da

Add variable descriptions based on flagged reason

665fde2

feat: Update blockaid friction modal copy

a0a318d

feat: Update blockaid friction modal copy

5c84e54

wip

a38248a

wip

f87faf5

pedronfigueiredo force-pushed the pnf/4328 branch from 329eb20 to f87faf5 Compare March 18, 2025 17:37

OGPoyraz approved these changes Mar 19, 2025

View reviewed changes

pedronfigueiredo added this pull request to the merge queue Mar 19, 2025

Merged via the queue into main with commit 268b397 Mar 19, 2025
76 checks passed

pedronfigueiredo deleted the pnf/4328 branch March 19, 2025 10:09

github-actions bot locked and limited conversation to collaborators Mar 19, 2025

metamaskbot added the release-12.16.0 Issue or pull request that will be included in release 12.16.0 label Mar 19, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Update blockaid friction modal copy #30809

feat: Update blockaid friction modal copy #30809

pedronfigueiredo commented Mar 6, 2025 •

edited by github-actions bot

Loading

github-actions bot commented Mar 6, 2025

metamaskbot commented Mar 6, 2025

metamaskbot commented Mar 11, 2025

metamaskbot commented Mar 12, 2025

metamaskbot commented Mar 13, 2025

digiwand Mar 13, 2025

vinistevam Mar 14, 2025

pedronfigueiredo Mar 18, 2025

vinistevam Mar 14, 2025

SayaGT Mar 18, 2025

vinistevam Mar 18, 2025

metamaskbot commented Mar 18, 2025

feat: Update blockaid friction modal copy #30809

feat: Update blockaid friction modal copy #30809

Conversation

pedronfigueiredo commented Mar 6, 2025 • edited by github-actions bot Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Mar 6, 2025

metamaskbot commented Mar 6, 2025

metamaskbot commented Mar 11, 2025

metamaskbot commented Mar 12, 2025

metamaskbot commented Mar 13, 2025

digiwand Mar 13, 2025

Choose a reason for hiding this comment

vinistevam Mar 14, 2025

Choose a reason for hiding this comment

pedronfigueiredo Mar 18, 2025

Choose a reason for hiding this comment

vinistevam Mar 14, 2025

Choose a reason for hiding this comment

SayaGT Mar 18, 2025

Choose a reason for hiding this comment

vinistevam Mar 18, 2025

Choose a reason for hiding this comment

metamaskbot commented Mar 18, 2025

pedronfigueiredo commented Mar 6, 2025 •

edited by github-actions bot

Loading