Skip to content

fix: mms-2049 solana slipagge #30760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 5, 2025
Merged

Conversation

GustavoRSSilva
Copy link
Contributor

@GustavoRSSilva GustavoRSSilva commented Mar 5, 2025

Description

Fetch quotes without slippage for solana swaps

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page swap as solana
  2. Check for quotes with solana

Screenshots/Recordings

Before

https://bridge.api.cx.metamask.io/getQuote?walletAddress=4CT8Uuah9FCv37NfkKZaTmaJXsC9KWd7cE2btFgChmvV&destWalletAddress=4CT8Uuah9FCv37NfkKZaTmaJXsC9KWd7cE2btFgChmvV&srcChainId=1151111081099710&destChainId=1151111081099710&srcTokenAddress=0x0000000000000000000000000000000000000000&destTokenAddress=6p6xgHyF7AeE6TZkSmFsko444wqoP15icUSqi2jfGiPN&srcTokenAmount=1000000000&insufficientBal=false&resetApproval=false

After

https://bridge.api.cx.metamask.io/getQuote?walletAddress=CpAUey2QhZqsrbBGpeYDm56Dk1tENLpdAzdpWdNYHxXB&destWalletAddress=CpAUey2QhZqsrbBGpeYDm56Dk1tENLpdAzdpWdNYHxXB&srcChainId=1151111081099710&destChainId=1151111081099710&srcTokenAddress=0x0000000000000000000000000000000000000000&destTokenAddress=EPjFWdd5AufqSSqeM2qN1xzybapC8G4wEGGkZwyTDt1v&srcTokenAmount=100000000&insufficientBal=false&resetApproval=false

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@GustavoRSSilva GustavoRSSilva requested a review from a team as a code owner March 5, 2025 00:28
Copy link
Contributor

github-actions bot commented Mar 5, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-swaps-and-bridge For issues with Swaps or Bridging label Mar 5, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [b3ece7a]
Page Load Metrics (1785 ± 53 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint16362008179211354
domContentLoaded16171968176310952
load16271996178511153
domInteractive21108452210
backgroundConnect105826168
firstReactRender147524168
getState46712168
initialActions01000
loadScripts1195146613139043
setupStore861242110
uiStartup18422302203313163
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@GustavoRSSilva GustavoRSSilva added this pull request to the merge queue Mar 5, 2025
Merged via the queue into main with commit c6c8710 Mar 5, 2025
78 checks passed
@GustavoRSSilva GustavoRSSilva deleted the fix-mms-2049-solana-slippage branch March 5, 2025 08:27
@github-actions github-actions bot locked and limited conversation to collaborators Mar 5, 2025
@metamaskbot metamaskbot added the release-12.15.0 Issue or pull request that will be included in release 12.15.0 label Mar 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.15.0 Issue or pull request that will be included in release 12.15.0 team-swaps-and-bridge For issues with Swaps or Bridging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants