Skip to content

fix: use networkClientId if included in transaction #30758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 5, 2025

Conversation

micaelae
Copy link
Member

@micaelae micaelae commented Mar 4, 2025

Description

Changes

  • use networkClientId for transaction submission if included in request options
  • include networkClientId in bridge transactions
  • Reset bridge quotes when fetching fails to remove potentially expired or invalid payloads

Open in GitHub Codespaces

Related issues

Fixes: #30683

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@metamaskbot metamaskbot added the team-swaps-and-bridge For issues with Swaps or Bridging label Mar 4, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [f48e249]
Page Load Metrics (1743 ± 67 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint15232127174614168
domContentLoaded15122079171313163
load15242130174314067
domInteractive28140482713
backgroundConnect1275352110
firstReactRender1577362311
getState55712157
initialActions01000
loadScripts10991624128212560
setupStore86017168
uiStartup17342380196814971
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 73 Bytes (0.00%)
  • ui: 101 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@micaelae micaelae marked this pull request as ready for review March 5, 2025 20:26
@micaelae micaelae requested a review from a team as a code owner March 5, 2025 20:26
@metamaskbot
Copy link
Collaborator

Builds ready [78f7357]
Page Load Metrics (1984 ± 127 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint38123761818528253
domContentLoaded151723391947261125
load154023731984264127
domInteractive177340136
backgroundConnect1277362311
firstReactRender1678422412
getState5191314220
initialActions01000
loadScripts111218261478227109
setupStore96418178
uiStartup174726932274291140
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 73 Bytes (0.00%)
  • ui: 101 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@micaelae micaelae added this pull request to the merge queue Mar 5, 2025
Merged via the queue into main with commit 9e735cd Mar 5, 2025
75 checks passed
@micaelae micaelae deleted the fix-tx-submitted-to-wrong-network branch March 5, 2025 21:48
@github-actions github-actions bot locked and limited conversation to collaborators Mar 5, 2025
@metamaskbot metamaskbot added the release-12.15.0 Issue or pull request that will be included in release 12.15.0 label Mar 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.15.0 Issue or pull request that will be included in release 12.15.0 team-swaps-and-bridge For issues with Swaps or Bridging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Bridging from a non-selected network can result in a botched app state
5 participants