Skip to content

fix: fixes bridging label showing for solana swap #30756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 5, 2025

Conversation

ghgoodreau
Copy link
Contributor

@ghgoodreau ghgoodreau commented Mar 4, 2025

Description

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to the swap experience with a Solana account.
  2. Generate a swap quote by filling out all necessary information.
  3. The Bridge label should be absent from the Quote card.

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

github-actions bot commented Mar 4, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@ghgoodreau ghgoodreau added the team-swaps-and-bridge For issues with Swaps or Bridging label Mar 4, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [0eaa9b5]
Page Load Metrics (1753 ± 80 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint27322081675362174
domContentLoaded14802115172416680
load15052129175316780
domInteractive247136126
backgroundConnect117236189
firstReactRender1474292110
getState55917168
initialActions01000
loadScripts10961609128713364
setupStore86019188
uiStartup16622425199719694
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 40 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@ghgoodreau ghgoodreau marked this pull request as ready for review March 5, 2025 00:08
@ghgoodreau ghgoodreau requested a review from a team as a code owner March 5, 2025 00:08
@ghgoodreau ghgoodreau added this pull request to the merge queue Mar 5, 2025
Merged via the queue into main with commit 8de0984 Mar 5, 2025
100 of 101 checks passed
@ghgoodreau ghgoodreau deleted the MMS-2037-sol-swap-quote-shows-bridge-label branch March 5, 2025 16:02
@github-actions github-actions bot locked and limited conversation to collaborators Mar 5, 2025
@metamaskbot metamaskbot added the release-12.15.0 Issue or pull request that will be included in release 12.15.0 label Mar 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.15.0 Issue or pull request that will be included in release 12.15.0 team-swaps-and-bridge For issues with Swaps or Bridging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants