Skip to content

fix: fetch quotes when dest asset is native #30749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 5, 2025

Conversation

micaelae
Copy link
Member

@micaelae micaelae commented Mar 4, 2025

Description

This fixes the bug in which quotes are not fetched when the destination is a native asset. This was due to the token address being empty, which was causing validation to fail

Open in GitHub Codespaces

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/MMS-2033

Manual testing steps

  1. Go to Bridge page (EVM or solana)
  2. Select native asset for both src and dest
  3. Quotes should be fetched

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@metamaskbot metamaskbot added the team-swaps-and-bridge For issues with Swaps or Bridging label Mar 4, 2025
@micaelae micaelae marked this pull request as ready for review March 4, 2025 18:08
@micaelae micaelae requested a review from a team as a code owner March 4, 2025 18:08
@metamaskbot
Copy link
Collaborator

Builds ready [e63723c]
Page Load Metrics (1703 ± 49 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint50519561648282135
domContentLoaded14871908167810048
load15331957170310349
domInteractive269145199
backgroundConnect95827188
firstReactRender1474412512
getState5549105
initialActions01000
loadScripts1099151112539947
setupStore866212110
uiStartup17492186195810450
Bundle size diffs [🚀 Bundle size reduced!]
  • background: 0 Bytes (0.00%)
  • ui: 156 Bytes (0.00%)
  • common: -52 Bytes (-0.00%)

@micaelae micaelae added this pull request to the merge queue Mar 5, 2025
Merged via the queue into main with commit bb66894 Mar 5, 2025
75 checks passed
@micaelae micaelae deleted the mms2033-native-dest-asset-fix branch March 5, 2025 21:11
@github-actions github-actions bot locked and limited conversation to collaborators Mar 5, 2025
@metamaskbot metamaskbot added the release-12.15.0 Issue or pull request that will be included in release 12.15.0 label Mar 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.15.0 Issue or pull request that will be included in release 12.15.0 team-swaps-and-bridge For issues with Swaps or Bridging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants