feat: Show rending confirmation alert on permission page when switching network #30725

jpuri · 2025-03-04T13:22:41Z

Description

Show rending confirmation alert on permission page when switching network

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/4329

Manual testing steps

Enable EVM multichain locally using env variable EVM_MULTICHAIN_ENABLED
Submit a confirmation
Switch network ensure user does not have permission on the network
Check that alert appears on grant permission modal and pending confirmations are deleted as user confirms the warning

Screenshots/Recordings

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2025-03-04T13:22:56Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2025-03-05T16:15:20Z

Builds ready [acb13bc]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1790 ± 84 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	301	2072	1657	456	219
		domContentLoaded	1460	2054	1769	177	85
		load	1514	2071	1790	175	84
		domInteractive	24	100	44	21	10
		backgroundConnect	11	53	22	11	5
		firstReactRender	15	72	39	22	11
		getState	6	57	24	20	10
		initialActions	0	1	0	0	0
		loadScripts	1084	1581	1324	155	75
		setupStore	7	60	17	15	7
		uiStartup	1708	2394	2039	190	91

metamaskbot · 2025-03-06T12:13:24Z

Builds ready [18bb57f]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1706 ± 81 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	316	2108	1646	348	167
		domContentLoaded	1452	2016	1672	152	73
		load	1463	2092	1706	169	81
		domInteractive	26	99	48	24	12
		backgroundConnect	11	79	38	23	11
		firstReactRender	14	72	25	18	8
		getState	5	60	14	15	7
		initialActions	0	1	0	0	0
		loadScripts	1047	1529	1252	126	60
		setupStore	7	86	23	24	12
		uiStartup	1700	2735	1987	282	135

metamaskbot · 2025-03-07T13:38:05Z

Builds ready [3d7e45a]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1666 ± 51 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1478	1886	1670	110	53
		domContentLoaded	1464	1869	1643	96	46
		load	1482	1894	1666	106	51
		domInteractive	26	103	41	18	9
		backgroundConnect	11	68	33	20	10
		firstReactRender	15	69	25	16	8
		getState	4	51	12	13	6
		initialActions	0	1	0	0	0
		loadScripts	1039	1393	1219	84	40
		setupStore	8	73	21	20	10
		uiStartup	1655	2175	1897	138	66

metamaskbot · 2025-03-07T17:38:24Z

Builds ready [9d00a4e]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (2047 ± 169 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1628	2634	2018	286	137
		domContentLoaded	1617	2431	1922	213	102
		load	1630	2981	2047	352	169
		domInteractive	26	117	41	23	11
		backgroundConnect	14	710	130	175	84
		firstReactRender	18	157	51	38	18
		getState	6	240	58	60	29
		initialActions	0	1	0	0	0
		loadScripts	1203	1831	1462	160	77
		setupStore	8	113	26	26	12
		uiStartup	1836	7703	2757	1299	624

metamaskbot · 2025-03-07T18:42:17Z

Builds ready [d919418]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1735 ± 76 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	362	2057	1591	415	199
		domContentLoaded	1521	2113	1685	146	70
		load	1533	2127	1735	159	76
		domInteractive	24	127	36	25	12
		backgroundConnect	11	181	54	50	24
		firstReactRender	13	69	31	20	10
		getState	4	90	20	22	11
		initialActions	0	1	0	0	0
		loadScripts	1153	1630	1282	115	55
		setupStore	7	53	17	16	8
		uiStartup	1719	2726	2034	268	129

…work.

metamaskbot · 2025-03-13T12:17:46Z

Builds ready [6e0cf45]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (3024 ± 399 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1816	4989	2732	663	318
		domContentLoaded	1776	4015	2434	476	228
		load	1819	5378	3024	831	399
		domInteractive	28	175	76	45	21
		backgroundConnect	78	1560	589	433	208
		firstReactRender	43	528	138	115	55
		getState	11	680	243	181	87
		initialActions	0	1	0	0	0
		loadScripts	1339	2235	1736	217	104
		setupStore	10	586	158	148	71
		uiStartup	1991	12032	5693	2689	1291

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 147 Bytes (0.00%)
ui: 2.48 KiB (0.03%)
common: 0 Bytes (0.00%)

metamaskbot · 2025-03-14T07:05:22Z

Builds ready [db223a9]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (3368 ± 1399 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1760	12747	3159	2801	1345
		domContentLoaded	1669	11819	2890	2626	1261
		load	1788	13254	3368	2914	1399
		domInteractive	26	319	69	74	35
		backgroundConnect	97	1184	440	306	147
		firstReactRender	42	180	86	42	20
		getState	36	697	228	193	92
		initialActions	0	1	0	0	0
		loadScripts	1253	10860	2287	2506	1204
		setupStore	19	426	115	112	54
		uiStartup	2328	19117	5081	3952	1898

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 147 Bytes (0.00%)
ui: 2.48 KiB (0.03%)
common: 0 Bytes (0.00%)

metamaskbot · 2025-03-18T14:28:40Z

Builds ready [02aa314]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1999 ± 258 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	370	3251	1896	560	269
		domContentLoaded	1467	3072	1865	399	191
		load	1510	3498	1999	537	258
		domInteractive	26	96	44	20	9
		backgroundConnect	10	815	150	197	95
		firstReactRender	16	185	52	39	19
		getState	4	315	61	83	40
		initialActions	0	1	0	0	0
		loadScripts	1037	1900	1344	215	103
		setupStore	8	269	39	59	28
		uiStartup	1660	8637	2760	1638	787

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 147 Bytes (0.00%)
ui: 2.48 KiB (0.03%)
common: 0 Bytes (0.00%)

metamaskbot · 2025-03-19T10:54:42Z

Builds ready [ba8f173]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (4219 ± 1832 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	420	10728	3161	2746	1319
		domContentLoaded	1482	13141	3633	3422	1643
		load	1671	13778	4219	3816	1832
		domInteractive	25	4636	335	992	476
		backgroundConnect	108	3065	571	636	306
		firstReactRender	41	190	91	40	19
		getState	41	2404	337	511	245
		initialActions	0	2	0	0	0
		loadScripts	1092	10249	2774	2811	1350
		setupStore	17	513	141	130	62
		uiStartup	2157	22692	6628	5365	2576

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 147 Bytes (0.00%)
ui: 2.48 KiB (0.03%)
common: 0 Bytes (0.00%)

metamaskbot · 2025-03-20T10:17:10Z

Builds ready [2321ca1]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (4332 ± 1831 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	701	19307	3871	3927	1886
		domContentLoaded	1919	19233	3839	3911	1878
		load	2002	19329	4332	3812	1831
		domInteractive	26	724	125	158	76
		backgroundConnect	73	1107	489	346	166
		firstReactRender	24	322	110	74	35
		getState	31	757	213	185	89
		initialActions	0	1	0	0	0
		loadScripts	1278	18801	2887	3751	1801
		setupStore	12	618	139	142	68
		uiStartup	2281	19668	6922	4093	1965

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 147 Bytes (0.00%)
ui: 2.48 KiB (0.03%)
common: 0 Bytes (0.00%)

metamaskbot · 2025-03-20T15:52:49Z

Builds ready [6054dfb]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (3033 ± 464 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	376	5831	2606	1159	556
		domContentLoaded	1710	5609	2465	902	433
		load	1871	5897	3033	966	464
		domInteractive	27	538	98	121	58
		backgroundConnect	164	959	554	248	119
		firstReactRender	52	174	100	29	14
		getState	70	556	232	129	62
		initialActions	0	1	0	0	0
		loadScripts	1225	4531	1685	714	343
		setupStore	23	388	135	89	43
		uiStartup	2751	10970	5546	2131	1023

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 147 Bytes (0.00%)
ui: 2.48 KiB (0.03%)
common: 0 Bytes (0.00%)

metamaskbot added the team-confirmations Push issues to confirmations team label Mar 4, 2025

jpuri force-pushed the switch_network_approval branch 5 times, most recently from d5840f8 to 97ef600 Compare March 5, 2025 15:07

jpuri force-pushed the add_permissions branch 2 times, most recently from 1ce262b to a44b849 Compare March 5, 2025 15:27

jpuri marked this pull request as ready for review March 5, 2025 15:28

jpuri requested a review from a team as a code owner March 5, 2025 15:28

jpuri force-pushed the add_permissions branch from a44b849 to acb13bc Compare March 5, 2025 15:40

jpuri force-pushed the switch_network_approval branch from 1aa7809 to d42103d Compare March 7, 2025 13:02

jpuri force-pushed the add_permissions branch from 18bb57f to 3d7e45a Compare March 7, 2025 13:02

jpuri force-pushed the switch_network_approval branch from d42103d to d2d7db9 Compare March 7, 2025 13:41

jpuri force-pushed the add_permissions branch from 3d7e45a to 7135d1b Compare March 7, 2025 13:47

jpuri force-pushed the add_permissions branch from d919418 to 5c966fb Compare March 13, 2025 10:41

Base automatically changed from switch_network_approval to main March 13, 2025 11:16

Show rending confirmation alert on permission page when switching net…

ac1bb1d

…work.

jpuri force-pushed the add_permissions branch from 5c966fb to ac1bb1d Compare March 13, 2025 11:39

update

6e0cf45

jpuri enabled auto-merge March 13, 2025 12:06

jpuri added 2 commits March 13, 2025 22:07

Merge branch 'main' into add_permissions

64a6e80

Merge branch 'main' into add_permissions

db223a9

Merge branch 'main' into add_permissions

02aa314

OGPoyraz approved these changes Mar 19, 2025

View reviewed changes

Merge branch 'main' into add_permissions

ba8f173

Merge branch 'main' into add_permissions

2321ca1

Merge branch 'main' into add_permissions

6054dfb

pedronfigueiredo approved these changes Mar 21, 2025

View reviewed changes

jpuri added this pull request to the merge queue Mar 21, 2025

Merged via the queue into main with commit b6da134 Mar 21, 2025
77 checks passed

jpuri deleted the add_permissions branch March 21, 2025 10:33

github-actions bot locked and limited conversation to collaborators Mar 21, 2025

metamaskbot added the release-12.16.0 Issue or pull request that will be included in release 12.16.0 label Mar 21, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Show rending confirmation alert on permission page when switching network #30725

feat: Show rending confirmation alert on permission page when switching network #30725

jpuri commented Mar 4, 2025 •

edited

Loading

github-actions bot commented Mar 4, 2025

metamaskbot commented Mar 5, 2025

metamaskbot commented Mar 6, 2025

metamaskbot commented Mar 7, 2025

metamaskbot commented Mar 7, 2025

metamaskbot commented Mar 7, 2025

metamaskbot commented Mar 13, 2025

metamaskbot commented Mar 14, 2025

metamaskbot commented Mar 18, 2025

metamaskbot commented Mar 19, 2025

metamaskbot commented Mar 20, 2025

metamaskbot commented Mar 20, 2025

feat: Show rending confirmation alert on permission page when switching network #30725

feat: Show rending confirmation alert on permission page when switching network #30725

Conversation

jpuri commented Mar 4, 2025 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Mar 4, 2025

metamaskbot commented Mar 5, 2025

metamaskbot commented Mar 6, 2025

metamaskbot commented Mar 7, 2025

metamaskbot commented Mar 7, 2025

metamaskbot commented Mar 7, 2025

metamaskbot commented Mar 13, 2025

metamaskbot commented Mar 14, 2025

metamaskbot commented Mar 18, 2025

metamaskbot commented Mar 19, 2025

metamaskbot commented Mar 20, 2025

metamaskbot commented Mar 20, 2025

jpuri commented Mar 4, 2025 •

edited

Loading