Skip to content

fix: code-fence multichain network selector #30722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 5, 2025

Conversation

gantunesr
Copy link
Member

@gantunesr gantunesr commented Mar 4, 2025

Description

Open in GitHub Codespaces

This change adds a multichain code fence to the getMultichainNetworkConfigurationsByChainId selector so the UI is not exposed to non-EVM network data from the multichain-network-controller

Related issues

Fixes: #30710

Manual testing steps

  1. Build the extension Flask wallet and set the addSolanaAccount to true
  2. You should see the Solana network in the network picker and use a Solana account
  3. Remove the extension
  4. Build the extension MetaMask wallet and set the addSolanaAccount to true
  5. You should not see the Solana network in the network picker

Screenshots/Recordings

Before

Check issue #30710

After

...

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@gantunesr gantunesr marked this pull request as ready for review March 5, 2025 14:26
@metamaskbot
Copy link
Collaborator

Builds ready [4d2b915]
Page Load Metrics (1716 ± 123 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint31722871625374180
domContentLoaded141622721683250120
load142723181716256123
domInteractive24121462813
backgroundConnect8117372613
firstReactRender1473382311
getState57417199
initialActions01000
loadScripts10051706127020196
setupStore7461184
uiStartup158926471941308148
Bundle size diffs [🚀 Bundle size reduced!]
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: -191 Bytes (-0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [58acef8]
Page Load Metrics (1557 ± 96 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint13902280156320096
domContentLoaded13682206152818689
load13762279155720096
domInteractive2379392110
backgroundConnect893292311
firstReactRender1370272010
getState45114157
initialActions01000
loadScripts9941701113715474
setupStore75315147
uiStartup158226651770245117
Bundle size diffs [🚀 Bundle size reduced!]
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: -191 Bytes (-0.00%)

Copy link
Contributor

@ccharly ccharly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM + Tested.

@ccharly ccharly changed the title chore: code-fence multichain network selector fix: code-fence multichain network selector Mar 5, 2025
@ccharly ccharly changed the title fix: code-fence multichain network selector fix: code-fence multichain network selector Mar 5, 2025
@gantunesr gantunesr added this pull request to the merge queue Mar 5, 2025
Merged via the queue into main with commit 77f59b1 Mar 5, 2025
80 checks passed
@gantunesr gantunesr deleted the gar/chore/codefence-network-selector branch March 5, 2025 18:10
@github-actions github-actions bot locked and limited conversation to collaborators Mar 5, 2025
@metamaskbot metamaskbot added the release-12.15.0 Issue or pull request that will be included in release 12.15.0 label Mar 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.15.0 Issue or pull request that will be included in release 12.15.0 team-accounts
Projects
None yet
4 participants