-
Notifications
You must be signed in to change notification settings - Fork 5.2k
fix: snap acount creation view position #30721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Builds ready [2711e06]
Page Load Metrics (1657 ± 48 ms)
Bundle size diffs
|
Builds ready [ee3c270]
Page Load Metrics (1621 ± 44 ms)
Bundle size diffs
|
aganglada
approved these changes
Mar 4, 2025
vinnyhoward
approved these changes
Mar 4, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
release-12.15.0
Issue or pull request that will be included in release 12.15.0
team-solana
PRs from the Solana snap team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Small fix, its needed for the positioning of the create account view that was being overwritten by the parent confirmations element. This caused the view to appear at the bottom of the screen when the extension is in expand mode.
Related issues
Fixes: The snap create account view appearing at the bottom of the screen.
Manual testing steps
Screenshots/Recordings
Before
Appeared at the bottom of the screen.
After
Pre-merge author checklist
Pre-merge reviewer checklist