chore(runway): cherry-pick fix: cp-12.14.0 replace 3D beta mascot with 2D version #30717
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![runway-github[bot]](https://avatars.githubusercontent.com/in/86225?s=60&v=4){kind=small}
…h 2D version (#30686) ## **Description** Issue: The Beta 3D asset isn't ready yet Solution: Replace all instances of the 3D asset for Beta with the 2D counterpart temporarily until we get the asset [](https://codespaces.new/MetaMask/metamask-extension/pull/30686?quickstart=1) ## **Related issues** Fixes: [#30665](#30665) ## **Manual testing steps** 1. Run `yarn start --build-type beta` 2. Confirm that the 2D beta logo is visible in the following flows 3. Swap Quote flow 4. Create Wallet flow 5. Login ## **Screenshots/Recordings** `ui/pages/onboarding-flow/welcome/welcome.js` | Before | After | |:---:|:---:| ||| `ui/pages/swaps/awaiting-swap/awaiting-swap.js` | Before | After | |:---:|:---:| ||| `ui/pages/swaps/loading-swaps-quotes/loading-swaps-quotes.js` | Before | After | |:---:|:---:| ||| `ui/pages/swaps/mascot-background-animation/mascot-background-animation.js` | Before | After | |:---:|:---:| ||| `ui/pages/unlock-page/unlock-page.component.js` | Before | After | |:---:|:---:| ||| ### **Before** NA ### **After** NA ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [x] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [x] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
](https://codespaces.new/MetaMask/metamask-extension/pull/30686?quickstart=1){kind=link}
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue: The Beta 3D asset isn't ready yet
Solution: Replace all instances of the 3D asset for Beta with the 2D
counterpart temporarily until we get the asset
Related issues
Fixes:
#30665
Manual testing steps
yarn start --build-type betaScreenshots/Recordings
ui/pages/onboarding-flow/welcome/welcome.js|
|
|
ui/pages/swaps/awaiting-swap/awaiting-swap.js|
|
|
ui/pages/swaps/loading-swaps-quotes/loading-swaps-quotes.js|
|
|
ui/pages/swaps/mascot-background-animation/mascot-background-animation.js|
|
|
ui/pages/unlock-page/unlock-page.component.js|
|
|
Before
NA
After
NA
Pre-merge author checklist
Docs and MetaMask
Extension Coding
Standards.
if applicable
guidelines).
Not required for external contributors.
Pre-merge reviewer checklist
app, test code being changed).
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots. a601157