feat: When switching network alert the user and get approval if there are pending requests from origin. #30674

jpuri · 2025-03-03T10:43:53Z

Description

When switching network alert the user and get approval if there are pending requests from origin.

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/4269
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/4327

Manual testing steps

Enable EVM multichain locally using env variable EVM_MULTICHAIN_ENABLED
Submit a confirmation
Switch network - ensure a warning appears and pending confirmations are deleted as user confirms the warning

Screenshots/Recordings

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2025-03-03T10:44:08Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2025-03-04T14:19:48Z

Builds ready [0505bc5]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1612 ± 54 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	181	1890	1477	418	201
		domContentLoaded	1372	1811	1577	107	52
		load	1381	1892	1612	112	54
		domInteractive	23	75	39	17	8
		backgroundConnect	10	99	37	25	12
		firstReactRender	14	73	35	22	11
		getState	4	56	12	14	7
		initialActions	0	1	0	0	0
		loadScripts	972	1385	1173	97	47
		setupStore	7	46	11	9	4
		uiStartup	1566	2173	1831	134	65

app/scripts/lib/rpc-method-middleware/handlers/ethereum-chain-utils.js

test/e2e/snaps/test-snap-update-component.spec.js

app/scripts/lib/rpc-method-middleware/handlers/ethereum-chain-utils.js

jpuri · 2025-03-05T14:45:22Z

ui/pages/confirmations/confirmation/alerts/useUpdateEthereumChainAlerts.test.ts

@@ -6,7 +6,7 @@ import { getMockPersonalSignConfirmState } from '../../../../../test/data/confir
 import { renderHookWithProvider } from '../../../../../test/lib/render-helpers';
 import * as AlertActions from '../../../../ducks/confirm-alerts/confirm-alerts';



These files are renamed as its used for all add/switch flows.

metamaskbot · 2025-03-05T16:04:27Z

Builds ready [7351c5c]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1715 ± 81 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	243	2058	1627	350	168
		domContentLoaded	1431	2065	1689	170	82
		load	1444	2078	1715	168	81
		domInteractive	20	84	39	20	10
		backgroundConnect	12	79	28	16	8
		firstReactRender	15	67	31	19	9
		getState	4	52	14	13	6
		initialActions	0	1	0	0	0
		loadScripts	1067	1647	1255	148	71
		setupStore	7	61	24	21	10
		uiStartup	1650	2404	1954	204	98

metamaskbot · 2025-03-06T12:13:35Z

Builds ready [1aa7809]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (2269 ± 340 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	298	3987	1960	933	448
		domContentLoaded	1431	3950	2222	688	330
		load	1471	4020	2269	708	340
		domInteractive	26	288	96	69	33
		backgroundConnect	7	437	53	91	44
		firstReactRender	15	74	42	23	11
		getState	5	68	30	22	11
		initialActions	0	1	0	0	0
		loadScripts	1072	3106	1719	562	270
		setupStore	8	62	20	14	7
		uiStartup	1615	4624	2600	822	395

The base branch was changed.

metamaskbot · 2025-03-07T13:36:50Z

Builds ready [d42103d]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1632 ± 61 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1440	1923	1633	131	63
		domContentLoaded	1424	1874	1607	131	63
		load	1443	1907	1632	127	61
		domInteractive	22	89	34	17	8
		backgroundConnect	11	54	25	13	6
		firstReactRender	14	73	36	24	11
		getState	5	54	10	11	5
		initialActions	0	1	0	0	0
		loadScripts	1040	1456	1199	121	58
		setupStore	7	58	17	17	8
		uiStartup	1604	2187	1855	153	74

…ending requests from origin.

…k-extension into switch_network_approval

metamaskbot · 2025-03-07T15:15:28Z

Builds ready [70e4136]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1903 ± 153 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1612	2699	1888	288	138
		domContentLoaded	1597	2277	1822	209	100
		load	1611	2862	1903	320	153
		domInteractive	25	100	35	16	8
		backgroundConnect	12	477	75	108	52
		firstReactRender	15	97	46	25	12
		getState	4	212	34	49	23
		initialActions	0	0	0	0	0
		loadScripts	1191	1727	1385	168	81
		setupStore	8	65	16	16	7
		uiStartup	1826	4166	2253	559	269

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 744 Bytes (0.01%)
ui: 109 Bytes (0.00%)
common: 247 Bytes (0.00%)

jpuri added the team-confirmations Push issues to confirmations team label Mar 3, 2025

jpuri requested a review from a team as a code owner March 3, 2025 10:43

jpuri requested a review from a team as a code owner March 4, 2025 13:46

OGPoyraz previously approved these changes Mar 5, 2025

View reviewed changes

app/scripts/lib/rpc-method-middleware/handlers/ethereum-chain-utils.js Show resolved Hide resolved

test/e2e/snaps/test-snap-update-component.spec.js Outdated Show resolved Hide resolved

OGPoyraz reviewed Mar 5, 2025

View reviewed changes

app/scripts/lib/rpc-method-middleware/handlers/ethereum-chain-utils.js Outdated Show resolved Hide resolved

jpuri force-pushed the switch_network_approval branch 2 times, most recently from 5739a10 to a124990 Compare March 5, 2025 14:43

jpuri commented Mar 5, 2025

View reviewed changes

jpuri force-pushed the switch_network_approval branch 3 times, most recently from d5840f8 to 97ef600 Compare March 5, 2025 15:07

jpuri force-pushed the switch_network_approval branch from 1aa7809 to d42103d Compare March 7, 2025 13:02

Base automatically changed from add_network_alert to main March 7, 2025 13:30

When switching network alert the user and get approval if there are p…

d2d7db9

…ending requests from origin.

jpuri force-pushed the switch_network_approval branch from d42103d to d2d7db9 Compare March 7, 2025 13:41

jpuri requested a review from OGPoyraz March 7, 2025 13:41

update

5cbd4bd

OGPoyraz previously approved these changes Mar 7, 2025

View reviewed changes

update

a83e8ce

jpuri dismissed OGPoyraz’s stale review via a83e8ce March 7, 2025 13:45

jpuri added 4 commits March 7, 2025 19:20

Merge branch 'main' into switch_network_approval

ec6c8bc

update

b0e4489

Merge branch 'switch_network_approval' of github.com:MetaMask/metamas…

7f6131f

…k-extension into switch_network_approval

update

70e4136

jpuri requested a review from OGPoyraz March 7, 2025 17:00

pedronfigueiredo approved these changes Mar 13, 2025

View reviewed changes

OGPoyraz approved these changes Mar 13, 2025

View reviewed changes

jpuri added this pull request to the merge queue Mar 13, 2025

Merged via the queue into main with commit aecb306 Mar 13, 2025
74 checks passed

jpuri deleted the switch_network_approval branch March 13, 2025 11:16

github-actions bot locked and limited conversation to collaborators Mar 13, 2025

metamaskbot added the release-12.15.0 Issue or pull request that will be included in release 12.15.0 label Mar 13, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: When switching network alert the user and get approval if there are pending requests from origin. #30674

feat: When switching network alert the user and get approval if there are pending requests from origin. #30674

jpuri commented Mar 3, 2025

github-actions bot commented Mar 3, 2025

metamaskbot commented Mar 4, 2025

jpuri Mar 5, 2025

metamaskbot commented Mar 5, 2025

metamaskbot commented Mar 6, 2025

metamaskbot commented Mar 7, 2025

metamaskbot commented Mar 7, 2025

		@@ -6,7 +6,7 @@ import { getMockPersonalSignConfirmState } from '../../../../../test/data/confir
		import { renderHookWithProvider } from '../../../../../test/lib/render-helpers';
		import * as AlertActions from '../../../../ducks/confirm-alerts/confirm-alerts';

feat: When switching network alert the user and get approval if there are pending requests from origin. #30674

feat: When switching network alert the user and get approval if there are pending requests from origin. #30674

Conversation

jpuri commented Mar 3, 2025

Description

Related issues

Manual testing steps

Screenshots/Recordings

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Mar 3, 2025

metamaskbot commented Mar 4, 2025

jpuri Mar 5, 2025

Choose a reason for hiding this comment

metamaskbot commented Mar 5, 2025

metamaskbot commented Mar 6, 2025

metamaskbot commented Mar 7, 2025

metamaskbot commented Mar 7, 2025