feat: Add clear functionality to SRP import error banner #30673

PatrykLucka · 2025-03-03T10:42:54Z

Description

Adds an option to clear the SRP input and error message, so user can easily paste another SRP.

Related issues

Manual testing steps

Go to Import SRP page
Paste SRP that has been already imported (you can try to import the same SRP 2nd time)
Error message should appear with a "Clear" option

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2025-03-03T10:43:09Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2025-03-03T11:17:39Z

Builds ready [4339c06]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1937 ± 79 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	449	2415	1864	366	176
		domContentLoaded	1694	2336	1905	160	77
		load	1711	2357	1937	164	79
		domInteractive	28	139	53	29	14
		backgroundConnect	11	79	33	21	10
		firstReactRender	17	93	32	24	11
		getState	6	70	24	22	11
		initialActions	0	1	0	0	0
		loadScripts	1254	1796	1435	141	68
		setupStore	9	71	24	23	11
		uiStartup	1990	2737	2235	209	100

metamaskbot · 2025-03-07T11:53:34Z

Builds ready [61b6755]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1666 ± 107 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	514	1995	1511	352	169
		domContentLoaded	1439	2406	1642	224	108
		load	1449	2413	1666	222	107
		domInteractive	24	107	40	22	11
		backgroundConnect	9	63	21	17	8
		firstReactRender	14	70	22	15	7
		getState	4	60	13	16	8
		initialActions	0	1	0	0	0
		loadScripts	1059	1831	1234	182	88
		setupStore	7	50	21	18	9
		uiStartup	1660	2631	1895	237	114

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

ui/components/multichain/multi-srp/import-srp/import-srp.tsx

metamaskbot · 2025-03-31T14:22:04Z

✨ Files requiring CODEOWNER review ✨

🖥️ @MetaMask/wallet-ux

ui/components/multichain/multi-srp/import-srp/import-srp.test.tsx
ui/components/multichain/multi-srp/import-srp/import-srp.tsx

darkwing · 2025-03-31T15:27:57Z

I think the failing tests are a result of requiring a rebase

metamaskbot · 2025-04-01T09:47:08Z

Builds ready [35226af]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

UI Startup Metrics (1193 ± 67 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1193	1070	1381	67	1236	1328
			load	1040	912	1219	64	934	989
			domContentLoaded	1033	896	1215	65	935	985
			domInteractive	16	12	33	4	15	27
			firstPaint	731	156	1220	403	267	974
			backgroundConnect	10	6	50	7	9	10
			firstReactRender	19	13	52	6	20	33
			getState	10	4	29	7	6	7
			initialActions	0	0	1	0	0	1
			loadScripts	818	684	1005	64	853	947
			setupStore	8	5	23	3	7	9
	Webpack	Home	uiStartup	1016	892	1380	77	971	996
			load	862	604	1045	61	880	942
			domContentLoaded	856	593	1041	60	876	945
			domInteractive	15	12	40	7	14	35
			firstPaint	355	57	1028	338	831	93
			backgroundConnect	18	13	51	8	16	41
			firstReactRender	16	12	42	5	16	28
			getState	5	3	17	3	5	7
			initialActions	0	0	1	0	0	0
			loadScripts	853	582	1040	60	875	943
			setupStore	8	4	22	3	8	9
Firefox	Browserify	Home	uiStartup	1366	1174	1892	155	1384	1787
			load	1230	1029	1750	151	1262	1649
			domContentLoaded	1230	1029	1750	151	1262	1649
			domInteractive	100	41	198	24	90	97
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	23	16	43	6	25	35
			firstReactRender	22	19	48	5	24	31
			getState	7	4	20	2	7	8
			initialActions	0	0	1	0	0	1
			loadScripts	1209	1011	1731	148	1234	1604
			setupStore	6	4	24	3	6	7
	Webpack	Home	uiStartup	949	815	1371	151	867	983
			load	831	710	1190	135	777	891
			domContentLoaded	831	710	1190	135	777	891
			domInteractive	113	48	233	23	158	98
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	19	13	77	10	21	36
			firstReactRender	18	16	25	2	18	23
			getState	9	4	65	11	7	9
			initialActions	0	0	1	0	0	1
			loadScripts	815	697	1164	131	763	872
			setupStore	8	5	54	6	7	8

Bundle size diffs

background: 0 Bytes (0%)
ui: 0 Bytes (0%)
common: 0 Bytes (0%)

metamaskbot · 2025-04-01T10:29:30Z

Builds ready [22d849a]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

UI Startup Metrics (1172 ± 57 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1172	1061	1392	57	1208	1274
			load	1020	929	1190	50	956	993
			domContentLoaded	1013	916	1187	51	955	993
			domInteractive	16	12	40	5	15	27
			firstPaint	764	129	1126	384	270	993
			backgroundConnect	13	6	137	16	9	10
			firstReactRender	20	13	59	7	20	36
			getState	11	5	31	7	6	8
			initialActions	0	0	2	0	0	1
			loadScripts	795	693	972	52	828	883
			setupStore	8	5	19	2	7	8
	Webpack	Home	uiStartup	1006	796	1224	77	968	994
			load	850	617	965	64	898	947
			domContentLoaded	845	610	962	63	894	942
			domInteractive	15	12	48	7	14	35
			firstPaint	339	54	947	331	838	933
			backgroundConnect	17	13	41	7	16	39
			firstReactRender	16	12	33	5	16	29
			getState	5	3	19	3	5	6
			initialActions	0	0	1	0	0	1
			loadScripts	842	607	960	63	892	940
			setupStore	8	4	24	3	7	9
Firefox	Browserify	Home	uiStartup	1353	1200	1986	142	1379	1706
			load	1220	1061	1833	135	1251	1536
			domContentLoaded	1220	1061	1832	135	1250	1535
			domInteractive	104	36	184	26	87	98
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	22	16	62	6	23	33
			firstReactRender	22	18	34	4	24	30
			getState	6	4	21	3	7	8
			initialActions	0	0	1	0	0	1
			loadScripts	1199	1043	1800	132	1226	1498
			setupStore	6	4	25	3	6	8
	Webpack	Home	uiStartup	976	801	1572	198	878	976
			load	851	702	1355	172	783	896
			domContentLoaded	850	702	1355	172	783	895
			domInteractive	115	47	187	20	134	92
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	23	13	106	19	21	79
			firstReactRender	18	16	28	2	19	22
			getState	8	4	62	7	7	9
			initialActions	0	0	1	0	0	1
			loadScripts	834	689	1337	169	770	880
			setupStore	10	5	84	15	7	8

Bundle size diffs

background: 0 Bytes (0%)
ui: 0 Bytes (0%)
common: 0 Bytes (0%)

PatrykLucka self-assigned this Mar 3, 2025

metamaskbot added the team-mmi PRs from the MMI team label Mar 3, 2025

Base automatically changed from feat/multi-srp-import-srp to main March 5, 2025 14:15

PatrykLucka force-pushed the add-clear-to-srp-input-error branch from 4339c06 to 61b6755 Compare March 7, 2025 11:18

PatrykLucka marked this pull request as ready for review March 7, 2025 11:31

PatrykLucka requested a review from a team as a code owner March 7, 2025 11:31

shane-t previously approved these changes Mar 28, 2025

View reviewed changes

darkwing reviewed Mar 31, 2025

View reviewed changes

ui/components/multichain/multi-srp/import-srp/import-srp.tsx Outdated Show resolved Hide resolved

PatrykLucka dismissed shane-t’s stale review via 72cb09b March 31, 2025 14:20

feat: add clearing SRP input and error message

2a32f3c

PatrykLucka force-pushed the add-clear-to-srp-input-error branch 2 times, most recently from 35226af to bf730e9 Compare April 1, 2025 09:46

chore: localize 'Clear' text

22d849a

PatrykLucka force-pushed the add-clear-to-srp-input-error branch from bf730e9 to 22d849a Compare April 1, 2025 09:54

PatrykLucka requested a review from darkwing April 1, 2025 12:07

darkwing approved these changes Apr 2, 2025

View reviewed changes

shane-t approved these changes Apr 2, 2025

View reviewed changes

PatrykLucka added this pull request to the merge queue Apr 2, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 2, 2025

PatrykLucka added this pull request to the merge queue Apr 3, 2025

Merged via the queue into main with commit 103a3ec Apr 3, 2025
147 checks passed

PatrykLucka deleted the add-clear-to-srp-input-error branch April 3, 2025 10:26

github-actions bot locked and limited conversation to collaborators Apr 3, 2025

metamaskbot added the release-12.17.0 Issue or pull request that will be included in release 12.17.0 label Apr 3, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Add clear functionality to SRP import error banner #30673

feat: Add clear functionality to SRP import error banner #30673

PatrykLucka commented Mar 3, 2025 •

edited

Loading

github-actions bot commented Mar 3, 2025

metamaskbot commented Mar 3, 2025

metamaskbot commented Mar 7, 2025

metamaskbot commented Mar 31, 2025

darkwing commented Mar 31, 2025

metamaskbot commented Apr 1, 2025

metamaskbot commented Apr 1, 2025

feat: Add clear functionality to SRP import error banner #30673

feat: Add clear functionality to SRP import error banner #30673

Conversation

PatrykLucka commented Mar 3, 2025 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Mar 3, 2025

metamaskbot commented Mar 3, 2025

metamaskbot commented Mar 7, 2025

metamaskbot commented Mar 31, 2025

✨ Files requiring CODEOWNER review ✨

darkwing commented Mar 31, 2025

metamaskbot commented Apr 1, 2025

metamaskbot commented Apr 1, 2025

PatrykLucka commented Mar 3, 2025 •

edited

Loading