-
Notifications
You must be signed in to change notification settings - Fork 5.2k
fix: mms-2001 first step bridge #30644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
const destSymbol = step?.destAsset?.symbol; | ||
if (!destSymbol) { | ||
return null; | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we change the Step
type as well? If these subfields are all marked with ?
, then at least we can get type safety to catch these things before they hit production.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Builds ready [3ca4864]
Page Load Metrics (2035 ± 188 ms)
Bundle size diffs
|
Builds ready [01f598e]
Page Load Metrics (1730 ± 58 ms)
Bundle size diffs
|
Description
Fix the first step of the transaction details when arriving in linea
Related issues
Fixes: Transaction details for a bridge transaction
Manual testing steps
Screenshots/Recordings
Pre-merge author checklist
Pre-merge reviewer checklist