Skip to content

fix: mms-2001 first step bridge #30644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 28, 2025
Merged

fix: mms-2001 first step bridge #30644

merged 5 commits into from
Feb 28, 2025

Conversation

GustavoRSSilva
Copy link
Contributor

@GustavoRSSilva GustavoRSSilva commented Feb 28, 2025

Description

Fix the first step of the transaction details when arriving in linea

Open in GitHub Codespaces

Related issues

Fixes: Transaction details for a bridge transaction

Manual testing steps

  1. Go to bridge page
  2. Create a bridge
  3. Check status

Screenshots/Recordings

Screenshot 2025-02-28 at 16 07 47 Screenshot 2025-02-28 at 16 14 11

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@GustavoRSSilva GustavoRSSilva requested a review from a team as a code owner February 28, 2025 16:21
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Comment on lines 61 to 65
const destSymbol = step?.destAsset?.symbol;
if (!destSymbol) {
return null;
}

Copy link
Contributor

@infiniteflower infiniteflower Feb 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we change the Step type as well? If these subfields are all marked with ?, then at least we can get type safety to catch these things before they hit production.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point; from my observations, both srcAsset and destAssert are built asynchronous, meaning you can still be fetching them when entering the page. Updates the types

In the following image, the srcAsset was being loaded.

Screenshot 2025-02-28 at 19 02 28

@metamaskbot
Copy link
Collaborator

Builds ready [3ca4864]
Page Load Metrics (2035 ± 188 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint45429541814513246
domContentLoaded161231541995382183
load163431842035391188
domInteractive21273565828
backgroundConnect1295402613
firstReactRender1596362311
getState6104262813
initialActions01000
loadScripts115025691514339163
setupStore791252512
uiStartup191340162354519249
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 131 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@ghgoodreau ghgoodreau added team-bridge DEPRECATED: Use team-swaps-and-bridge team-swaps DEPRECATED: Use team-swaps-and-bridge labels Feb 28, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [01f598e]
Page Load Metrics (1730 ± 58 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint14612047173112660
domContentLoaded14511957169811153
load14632007173012058
domInteractive26128453115
backgroundConnect1183352110
firstReactRender1575362311
getState46117189
initialActions00000
loadScripts1038149112589747
setupStore75314126
uiStartup16422214196813464
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 104 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@bfullam bfullam added the team-swaps-and-bridge For issues with Swaps or Bridging label Feb 28, 2025
@bfullam bfullam added this pull request to the merge queue Feb 28, 2025
Merged via the queue into main with commit 5196562 Feb 28, 2025
81 of 82 checks passed
@bfullam bfullam deleted the mms-2001-first-step-bridge branch February 28, 2025 22:24
@github-actions github-actions bot locked and limited conversation to collaborators Feb 28, 2025
@metamaskbot metamaskbot added the release-12.15.0 Issue or pull request that will be included in release 12.15.0 label Feb 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.15.0 Issue or pull request that will be included in release 12.15.0 team-bridge DEPRECATED: Use team-swaps-and-bridge team-swaps DEPRECATED: Use team-swaps-and-bridge team-swaps-and-bridge For issues with Swaps or Bridging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants