Skip to content

feat: convert non-evm amounts to fiat #30568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 26, 2025
Merged

Conversation

micaelae
Copy link
Member

@micaelae micaelae commented Feb 25, 2025

Description

This enables looking up non-evm exchange rate data for converting token amounts

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Select non-evm account
  2. Open bridge experience and select token
  3. Enter an amount
  4. Converted amount should appear under input field

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@micaelae micaelae added team-bridge DEPRECATED: Use team-swaps-and-bridge team-swaps DEPRECATED: Use team-swaps-and-bridge labels Feb 25, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [5493811]
Page Load Metrics (1603 ± 46 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint39918201561284136
domContentLoaded1409178415839546
load1427180616039646
domInteractive17205544321
backgroundConnect94323115
firstReactRender1480312412
getState45818209
initialActions01000
loadScripts1006139411929847
setupStore65717188
uiStartup16232109182012158
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 806 Bytes (0.01%)
  • common: 511 Bytes (0.00%)

@micaelae micaelae changed the title feat: show non-evm amounts in selected currency feat: show non-evm amounts in fiat Feb 25, 2025
@micaelae micaelae changed the title feat: show non-evm amounts in fiat feat: convert non-evm amounts in fiat Feb 25, 2025
@micaelae micaelae changed the title feat: convert non-evm amounts in fiat feat: convert non-evm amounts to fiat Feb 25, 2025
@micaelae micaelae force-pushed the mms1868-sol-exchange-rates branch from 5493811 to ba2f108 Compare February 26, 2025 00:19
@metamaskbot
Copy link
Collaborator

Builds ready [ba2f108]
Page Load Metrics (1794 ± 71 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint16162210179714871
domContentLoaded16082191175914469
load16172201179414771
domInteractive20115472412
backgroundConnect11102342813
firstReactRender1471322211
getState46617199
initialActions01000
loadScripts11721697132512962
setupStore77513147
uiStartup18342536202717484
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 806 Bytes (0.01%)
  • common: 511 Bytes (0.00%)

@micaelae micaelae marked this pull request as ready for review February 26, 2025 03:33
@micaelae micaelae requested a review from a team as a code owner February 26, 2025 03:33
@metamaskbot
Copy link
Collaborator

Builds ready [374aa05]
Page Load Metrics (1749 ± 85 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint14922193174917785
domContentLoaded14832086171916579
load14922194174917885
domInteractive26102482311
backgroundConnect10124312713
firstReactRender1473292010
getState4126162713
initialActions01000
loadScripts10731624128314268
setupStore768262311
uiStartup175227542001243117
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 806 Bytes (0.01%)
  • common: 525 Bytes (0.01%)

@micaelae micaelae added this pull request to the merge queue Feb 26, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 26, 2025
@micaelae micaelae added this pull request to the merge queue Feb 26, 2025
Merged via the queue into main with commit e743cad Feb 26, 2025
79 checks passed
@micaelae micaelae deleted the mms1868-sol-exchange-rates branch February 26, 2025 18:54
@github-actions github-actions bot locked and limited conversation to collaborators Feb 26, 2025
@metamaskbot metamaskbot added the release-12.14.0 Issue or pull request that will be included in release 12.14.0 label Feb 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.14.0 Issue or pull request that will be included in release 12.14.0 team-bridge DEPRECATED: Use team-swaps-and-bridge team-swaps DEPRECATED: Use team-swaps-and-bridge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants