Skip to content

fix: Hide non-zero hex data alert for contract deployment confirmations #30474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 24, 2025

Conversation

pedronfigueiredo
Copy link
Contributor

@pedronfigueiredo pedronfigueiredo commented Feb 20, 2025

Description

Previously, the non-zero hex data alert could be visible by the user if another alert was triggered for contract deployments. This PR hides it for this case.

Open in GitHub Codespaces

Related issues

Fixes: #30359

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@pedronfigueiredo pedronfigueiredo added the team-confirmations Push issues to confirmations team label Feb 20, 2025
@pedronfigueiredo pedronfigueiredo self-assigned this Feb 20, 2025
@pedronfigueiredo pedronfigueiredo requested a review from a team as a code owner February 20, 2025 18:27
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [8b405f5]
Page Load Metrics (1710 ± 79 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint14812361172317584
domContentLoaded14142306168117082
load14792312171016479
domInteractive259741178
backgroundConnect96633199
firstReactRender1587402813
getState580192110
initialActions01000
loadScripts10101744124414369
setupStore773202010
uiStartup166826831981220105
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 209 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

isSendingHexData && isInteractingWithNonContractAddress;
isSendingHexData &&
isInteractingWithNonContractAddress &&
!isContractDeploymentTx;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look perfect, but be nice to have test coverage also.

@metamaskbot
Copy link
Collaborator

Builds ready [d9ce305]
Page Load Metrics (1767 ± 76 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint15072055176915575
domContentLoaded14962043173815976
load15172069176715876
domInteractive267840157
backgroundConnect1174322211
firstReactRender1480432512
getState46311126
initialActions01000
loadScripts10801580129414168
setupStore76522209
uiStartup18082368203915775
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 226 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@pedronfigueiredo pedronfigueiredo added this pull request to the merge queue Feb 24, 2025
Merged via the queue into main with commit f4c3889 Feb 24, 2025
79 checks passed
@pedronfigueiredo pedronfigueiredo deleted the pnf/30359 branch February 24, 2025 17:03
@github-actions github-actions bot locked and limited conversation to collaborators Feb 24, 2025
@metamaskbot metamaskbot added the release-12.14.0 Issue or pull request that will be included in release 12.14.0 label Feb 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.14.0 Issue or pull request that will be included in release 12.14.0 team-confirmations Push issues to confirmations team
Projects
None yet
4 participants