feat: Integrate SPL tokens and rates from multichainAssetsRates #30389

sahar-fehri · 2025-02-18T11:38:43Z

Description

This PR
1- Integrate SPL tokens into token list.
2- Integrates the new MultichainAssetsRatesController to be used instead of the of ratesController.

Related issues

Solana Effort

Manual testing steps

clone snaps repo: git clone [email protected]:MetaMask/snap-solana-wallet.git
Add .env to /packages/snap (ask around for this)
yarn && yarn start -> go to localhost:3000

In separate terminal, for extension:

checkout this branch
yarn && yarn start:flask or yarn && yarn webpack --watch --type flask
Go to localhost:3000 and install snap
Settings -> Experimental -> toggle Enable "Add a new Solana account (Beta)"
Add the Solana Account (you may need to refresh extension)

You should see Solana tokens populating the token list!

Sort controls should be functional

Screenshots/Recordings

Screen.Recording.2025-02-14.at.3.33.58.PM.mov

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2025-02-18T11:38:57Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

…k-extension into feat/spl-token-rates-v3

metamaskbot · 2025-02-19T02:42:55Z

Builds ready [08d5b4b]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1757 ± 74 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1447	2002	1755	155	74
		domContentLoaded	1437	1989	1731	150	72
		load	1446	2008	1757	155	74
		domInteractive	22	103	50	25	12
		backgroundConnect	10	67	28	18	9
		firstReactRender	14	81	40	26	13
		getState	4	61	17	19	9
		initialActions	0	1	0	0	0
		loadScripts	1016	1493	1266	139	67
		setupStore	7	62	14	14	7
		uiStartup	1697	2303	2000	170	82

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 3.09 KiB (0.04%)
common: 240 Bytes (0.00%)

GuillaumeRx · 2025-02-24T11:09:24Z

Can we also rename the PR ? This is not only related to solana, this is integrating the rates for all the multichain accounts.

metamaskbot · 2025-02-24T11:33:31Z

Builds ready [ff49d70]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1571 ± 99 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1305	2000	1557	206	99
		domContentLoaded	1299	1992	1533	208	100
		load	1307	2010	1571	206	99
		domInteractive	24	116	37	24	12
		backgroundConnect	10	102	41	23	11
		firstReactRender	13	75	33	23	11
		getState	5	55	15	16	8
		initialActions	0	1	0	0	0
		loadScripts	933	1477	1127	160	77
		setupStore	7	69	14	17	8
		uiStartup	1477	2227	1773	227	109

Bundle size diffs [🚀 Bundle size reduced!]

background: 0 Bytes (0.00%)
ui: 7.74 KiB (0.10%)
common: -4.85 KiB (-0.06%)

metamaskbot · 2025-02-24T12:07:22Z

Builds ready [1de7ab4]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1659 ± 89 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1359	1982	1646	179	86
		domContentLoaded	1349	1972	1622	175	84
		load	1359	1984	1659	185	89
		domInteractive	23	209	63	56	27
		backgroundConnect	10	87	36	27	13
		firstReactRender	14	75	24	19	9
		getState	5	79	20	22	10
		initialActions	0	1	0	0	0
		loadScripts	985	1449	1199	133	64
		setupStore	7	68	20	21	10
		uiStartup	1586	2177	1887	188	90

Bundle size diffs [🚀 Bundle size reduced!]

background: 0 Bytes (0.00%)
ui: 7.74 KiB (0.10%)
common: -4.85 KiB (-0.06%)

metamaskbot · 2025-02-24T15:36:03Z

Builds ready [8b7e0d9]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1641 ± 95 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	237	2135	1568	359	173
		domContentLoaded	1394	2077	1607	184	88
		load	1413	2143	1641	197	95
		domInteractive	25	61	34	11	5
		backgroundConnect	11	98	38	26	12
		firstReactRender	14	68	26	19	9
		getState	4	71	22	25	12
		initialActions	0	1	0	0	0
		loadScripts	985	1537	1176	146	70
		setupStore	7	72	18	21	10
		uiStartup	1651	2431	1882	221	106

Bundle size diffs [🚀 Bundle size reduced!]

background: 0 Bytes (0.00%)
ui: 7.74 KiB (0.10%)
common: -4.88 KiB (-0.06%)

metamaskbot · 2025-02-24T16:52:43Z

Builds ready [bc9c47c]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1691 ± 75 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	381	2209	1615	322	155
		domContentLoaded	1440	2139	1655	150	72
		load	1455	2212	1691	156	75
		domInteractive	26	65	38	9	5
		backgroundConnect	12	82	42	24	12
		firstReactRender	14	73	32	22	10
		getState	5	20	10	4	2
		initialActions	0	1	0	0	0
		loadScripts	1008	1691	1214	142	68
		setupStore	7	74	25	23	11
		uiStartup	1708	2453	1919	163	78

Bundle size diffs [🚀 Bundle size reduced!]

background: 0 Bytes (0.00%)
ui: 7.74 KiB (0.10%)
common: -4.88 KiB (-0.06%)

gambinish and others added 13 commits February 18, 2025 12:33

feat: Integrate SPL tokens

90e39b5

chore: Cleanup token-list

c31dafc

chore: Remove some hard coded values

fa12cf8

chore: Cleanup

b0e5203

chore: Remove hardcoded assetId

3fb2ff5

chore: Handle native token

bdd6eb5

fix: Dont render network text when percent change is undefined

d2629e1

fix: Render token balance in primary display cell

f4c0201

fix: Replace fallback

f47d98c

chore: Remove parsedAssetId util in favor of common metamask util

1b28ad4

fix: Cleanup

709f551

chore: Integrate token rates

0f93bb1

fix: fix currentChain selector

ca0a3c8

metamaskbot added the team-assets label Feb 18, 2025

sahar-fehri changed the title ~~Feat/spl token rates v3~~ feat: spl token rates v3 Feb 18, 2025

sahar-fehri changed the title ~~feat: spl token rates v3~~ feat: spl token rates integration Feb 18, 2025

sahar-fehri added 7 commits February 18, 2025 12:43

fix: fix path

74545f2

fix: fix lint

ca594a4

fix: fix

728780e

fix: fix snap id

de10f52

fix: refactor getTokenBalancesEvm to take address as arg

da9c3e4

fix: fix mock

e240ae7

fix: fix mock

fd94fc2

gambinish mentioned this pull request Feb 18, 2025

feat: AssetList SPL token support #30345

Closed

7 tasks

gambinish added 2 commits February 18, 2025 17:57

fix: Hardcode multichain cached balance when cached balance is zero

89ab322

Merge branch 'feat/spl-token-rates-v3' of github.com:MetaMask/metamas…

08d5b4b

…k-extension into feat/spl-token-rates-v3

gambinish and others added 2 commits February 18, 2025 18:43

chore: Cleanup

ccfb092

Merge branch 'main' into feat/spl-token-rates-v3

244bec2

fix: small refactor

1de7ab4

sahar-fehri changed the title ~~feat: spl token rates integration~~ feat: Integrate SPL tokens and rates from multichainAssetsRates Feb 24, 2025

GuillaumeRx previously approved these changes Feb 24, 2025

View reviewed changes

aganglada previously approved these changes Feb 24, 2025

View reviewed changes

pedronfigueiredo previously approved these changes Feb 24, 2025

View reviewed changes

jonybur previously approved these changes Feb 24, 2025

View reviewed changes

salimtb mentioned this pull request Feb 24, 2025

chore: assets controller package update #30526

Merged

7 tasks

fix: fix merge conflicts

8b7e0d9

sahar-fehri dismissed stale reviews from jonybur, pedronfigueiredo, aganglada, and GuillaumeRx via 8b7e0d9 February 24, 2025 14:59

zone-live approved these changes Feb 24, 2025

View reviewed changes

GuillaumeRx approved these changes Feb 24, 2025

View reviewed changes

pedronfigueiredo approved these changes Feb 24, 2025

View reviewed changes

Merge branch 'main' into feat/spl-token-rates-v3

bc9c47c

aganglada approved these changes Feb 24, 2025

View reviewed changes

NidhiKJha approved these changes Feb 24, 2025

View reviewed changes

jonybur approved these changes Feb 24, 2025

View reviewed changes

sahar-fehri added this pull request to the merge queue Feb 24, 2025

Merged via the queue into main with commit ffe7ec5 Feb 24, 2025
79 checks passed

sahar-fehri deleted the feat/spl-token-rates-v3 branch February 24, 2025 17:47

github-actions bot locked and limited conversation to collaborators Feb 24, 2025

metamaskbot added the release-12.14.0 Issue or pull request that will be included in release 12.14.0 label Feb 24, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Integrate SPL tokens and rates from multichainAssetsRates #30389

feat: Integrate SPL tokens and rates from multichainAssetsRates #30389

sahar-fehri commented Feb 18, 2025 •

edited

Loading

github-actions bot commented Feb 18, 2025

metamaskbot commented Feb 19, 2025

GuillaumeRx commented Feb 24, 2025

metamaskbot commented Feb 24, 2025

metamaskbot commented Feb 24, 2025

metamaskbot commented Feb 24, 2025

metamaskbot commented Feb 24, 2025

feat: Integrate SPL tokens and rates from multichainAssetsRates #30389

feat: Integrate SPL tokens and rates from multichainAssetsRates #30389

Conversation

sahar-fehri commented Feb 18, 2025 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Feb 18, 2025

metamaskbot commented Feb 19, 2025

GuillaumeRx commented Feb 24, 2025

metamaskbot commented Feb 24, 2025

metamaskbot commented Feb 24, 2025

metamaskbot commented Feb 24, 2025

metamaskbot commented Feb 24, 2025

sahar-fehri commented Feb 18, 2025 •

edited

Loading