feat: Fix plan 835 Hid request dialog keep on prompting up during pagination. #30384

dawnseeker8 · 2025-02-18T10:40:31Z

This PR is relative to solve the plan 835

This PR including following change:

in actions.js file, change connectHardware method signature to has extra loadHid boolean parameter to see whether we need to load HID request prompt up.
change connect-hardware/index.js to and pass loadHid = true parameter value to above actions.
change connect-hardware/account-list.js and all pagination feature relative functions to pass loadHid = false to disable HID request popup apear.

Description

Related issues

Fixes: https://github.com/MetaMask/accounts-planning/issues/835

Manual testing steps

This test requires a Ledger hardware device with more than 5 accounts:

Add hardware wallet
Connect to Ledger device
Verify 5 Ledger accounts are displayed
Click Next
Verify the HID popup is not displayed each time the user clicks Next button

Screenshots/Recordings

Before

The following popup is displayed after each "Next" action

After

The popup is not displayed repeatedly

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2025-02-18T10:40:44Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2025-02-18T11:17:00Z

Builds ready [2dcab12]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1832 ± 91 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1478	2222	1837	193	93
		domContentLoaded	1472	2198	1797	188	90
		load	1477	2216	1832	189	91
		domInteractive	28	143	55	33	16
		backgroundConnect	9	200	39	43	20
		firstReactRender	15	78	37	25	12
		getState	4	68	20	20	10
		initialActions	0	1	0	0	0
		loadScripts	1066	1628	1319	159	76
		setupStore	8	58	24	20	10
		uiStartup	1744	2660	2089	222	106

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 17 Bytes (0.00%)
common: 5 Bytes (0.00%)

metamaskbot · 2025-02-19T01:41:31Z

Builds ready [cf89481]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1654 ± 42 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	457	1858	1591	277	133
		domContentLoaded	1468	1847	1630	90	43
		load	1520	1857	1654	88	42
		domInteractive	25	78	38	18	9
		backgroundConnect	9	71	28	21	10
		firstReactRender	14	75	40	25	12
		getState	5	56	11	14	7
		initialActions	0	0	0	0	0
		loadScripts	1005	1337	1178	86	41
		setupStore	6	60	14	15	7
		uiStartup	1718	2087	1886	99	48

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 17 Bytes (0.00%)
common: 5 Bytes (0.00%)

metamaskbot · 2025-03-06T13:16:45Z

Builds ready [d5a8a67]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1954 ± 101 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	285	2584	1785	538	258
		domContentLoaded	1627	2501	1920	217	104
		load	1639	2507	1954	211	101
		domInteractive	24	139	50	31	15
		backgroundConnect	12	84	43	25	12
		firstReactRender	17	86	52	24	12
		getState	6	53	14	11	5
		initialActions	0	0	0	0	0
		loadScripts	1217	1893	1436	177	85
		setupStore	8	70	17	16	8
		uiStartup	1881	2829	2227	236	113

ui/pages/create-account/connect-hardware/index.js

ui/store/actions.ts

… all possible cases.

metamaskbot · 2025-03-07T14:34:44Z

Builds ready [1359e03]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (2033 ± 127 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	247	2764	1761	629	302
		domContentLoaded	1603	2715	1997	268	129
		load	1667	2741	2033	264	127
		domInteractive	22	127	54	30	14
		backgroundConnect	9	84	43	22	10
		firstReactRender	15	77	40	21	10
		getState	8	62	22	17	8
		initialActions	0	1	0	0	0
		loadScripts	1196	2122	1516	232	111
		setupStore	9	56	20	15	7
		uiStartup	1836	3146	2312	310	149

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 17 Bytes (0.00%)
common: 5 Bytes (0.00%)

metamaskbot · 2025-03-10T10:43:34Z

Builds ready [a438e07]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1585 ± 33 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	526	1694	1537	242	116
		domContentLoaded	1441	1676	1567	71	34
		load	1463	1696	1585	68	33
		domInteractive	22	68	37	17	8
		backgroundConnect	8	58	28	17	8
		firstReactRender	14	70	42	25	12
		getState	4	46	12	12	6
		initialActions	0	0	0	0	0
		loadScripts	1026	1267	1161	63	30
		setupStore	7	50	12	11	5
		uiStartup	1615	1958	1783	81	39

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 17 Bytes (0.00%)
common: 5 Bytes (0.00%)

ui/pages/create-account/connect-hardware/account-list.js

ui/pages/create-account/connect-hardware/index.js

ui/pages/create-account/connect-hardware/index.test.tsx

metamaskbot · 2025-03-13T05:16:56Z

Builds ready [1900595]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (2215 ± 184 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1809	2834	2189	336	161
		domContentLoaded	1758	2573	2087	237	114
		load	1808	3028	2215	383	184
		domInteractive	26	138	49	33	16
		backgroundConnect	9	675	131	175	84
		firstReactRender	15	135	41	34	16
		getState	7	270	61	66	31
		initialActions	0	1	0	0	0
		loadScripts	1316	1951	1574	165	79
		setupStore	9	68	22	20	10
		uiStartup	2013	4990	2746	883	424

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 17 Bytes (0.00%)
common: 5 Bytes (0.00%)

vivek-consensys · 2025-03-13T10:30:56Z

Tested on Chrome and working as expected. HID popup is not displayed when switching different pages on the account list or when switching HD paths. See below:
Private Zenhub Video

metamaskbot · 2025-03-14T05:17:07Z

Builds ready [567ef59]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (4752 ± 2268 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1902	21121	4496	4782	2296
		domContentLoaded	1789	21004	4237	4800	2305
		load	1922	21026	4752	4723	2268
		domInteractive	25	490	105	126	60
		backgroundConnect	29	1719	495	450	216
		firstReactRender	24	179	86	48	23
		getState	29	616	205	160	77
		initialActions	0	1	0	0	0
		loadScripts	1357	20549	3538	4760	2286
		setupStore	10	436	114	118	57
		uiStartup	2251	21226	6816	4820	2314

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 17 Bytes (0.00%)
common: 5 Bytes (0.00%)

ui/pages/create-account/connect-hardware/__snapshots__/index.test.tsx.snap

…est.tsx.snap Co-authored-by: Michele Esposito <[email protected]>

metamaskbot · 2025-03-18T15:41:57Z

Builds ready [a0600d4]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (3805 ± 1897 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1737	20342	3551	3951	1897
		domContentLoaded	1581	19423	3155	3803	1826
		load	1729	20444	3805	3951	1897
		domInteractive	27	258	95	71	34
		backgroundConnect	126	1436	613	341	164
		firstReactRender	20	207	108	41	20
		getState	34	593	266	163	78
		initialActions	0	1	0	0	0
		loadScripts	1151	17953	2421	3599	1728
		setupStore	10	336	139	96	46
		uiStartup	2034	21991	6596	4222	2027

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 17 Bytes (0.00%)
common: 5 Bytes (0.00%)

feat: First draft fix for HID request keep promping up.

506915a

metamaskbot added the team-hardware-wallets label Feb 18, 2025

dawnseeker8 added the hardware-ledger label Feb 18, 2025

Merge branch 'main' into feat/plan-836-ledger-hid-prompt-up-issue

2dcab12

dawnseeker8 changed the title ~~feat: First draft fix for HID request keep promping up.~~ feat: Fix plan 835 Hid request dialog keep on prompting up during pagination. Feb 18, 2025

dawnseeker8 marked this pull request as ready for review February 19, 2025 01:06

Merge branch 'main' into feat/plan-836-ledger-hid-prompt-up-issue

cf89481

dawnseeker8 added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Feb 21, 2025

Merge branch 'main' into feat/plan-836-ledger-hid-prompt-up-issue

d5a8a67

gantunesr reviewed Mar 6, 2025

View reviewed changes

ui/pages/create-account/connect-hardware/index.js Show resolved Hide resolved

ui/store/actions.ts Show resolved Hide resolved

fix: add unit tests to test connectHardware, mock HID connection with…

1359e03

… all possible cases.

Fix: unit tests to cover the getPage() method.

a438e07

dawnseeker8 requested a review from gantunesr March 10, 2025 10:45

Merge branch 'main' into feat/plan-836-ledger-hid-prompt-up-issue

14a74d6

dawnseeker8 commented Mar 11, 2025

View reviewed changes

ui/pages/create-account/connect-hardware/account-list.js Show resolved Hide resolved

dawnseeker8 commented Mar 11, 2025

View reviewed changes

ui/pages/create-account/connect-hardware/index.js Show resolved Hide resolved

dawnseeker8 commented Mar 11, 2025

View reviewed changes

ui/pages/create-account/connect-hardware/index.test.tsx Show resolved Hide resolved

dawnseeker8 and others added 3 commits March 11, 2025 16:32

fix: refactor the unit test description.

26b2b62

fix: Remove unused comments.

064f3c3

Merge branch 'main' into feat/plan-836-ledger-hid-prompt-up-issue

29d8173

gantunesr previously approved these changes Mar 12, 2025

View reviewed changes

Merge branch 'main' into feat/plan-836-ledger-hid-prompt-up-issue

1900595

Merge branch 'main' into feat/plan-836-ledger-hid-prompt-up-issue

567ef59

dawnseeker8 requested a review from gantunesr March 14, 2025 04:37

gantunesr previously approved these changes Mar 17, 2025

View reviewed changes

gabo76555 approved these changes Mar 17, 2025

View reviewed changes

mikesposito reviewed Mar 18, 2025

View reviewed changes

ui/pages/create-account/connect-hardware/__snapshots__/index.test.tsx.snap Show resolved Hide resolved

Update ui/pages/create-account/connect-hardware/__snapshots__/index.t…

6be0307

…est.tsx.snap Co-authored-by: Michele Esposito <[email protected]>

dawnseeker8 dismissed gantunesr’s stale review via 6be0307 March 18, 2025 12:44

dawnseeker8 requested review from mikesposito and gantunesr March 18, 2025 12:45

gantunesr previously approved these changes Mar 18, 2025

View reviewed changes

dawnseeker8 and others added 2 commits March 18, 2025 14:46

Merge branch 'main' into feat/plan-836-ledger-hid-prompt-up-issue

40caace

fix: update latest snapshot after rebase to fix unit tests.

a0600d4

dawnseeker8 dismissed gantunesr’s stale review via a0600d4 March 18, 2025 15:02

dawnseeker8 requested a review from gantunesr March 18, 2025 15:02

gantunesr approved these changes Mar 18, 2025

View reviewed changes

mikesposito approved these changes Mar 19, 2025

View reviewed changes

github-project-automation bot moved this from Needs dev review to Review finalised - Ready to be merged in PR review queue Mar 19, 2025

dawnseeker8 added this pull request to the merge queue Mar 19, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 19, 2025

Akaryatrh added this pull request to the merge queue Mar 19, 2025

Merged via the queue into main with commit 9576f7c Mar 19, 2025
76 checks passed

Akaryatrh deleted the feat/plan-836-ledger-hid-prompt-up-issue branch March 19, 2025 16:14

github-project-automation bot moved this from Review finalised - Ready to be merged to Merged, Closed or Archived in PR review queue Mar 19, 2025

github-actions bot locked and limited conversation to collaborators Mar 19, 2025

github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Mar 19, 2025

metamaskbot added the release-12.16.0 Issue or pull request that will be included in release 12.16.0 label Mar 19, 2025

angelcheung22 added the Sev2-normal Normal severity; minor loss of service or inconvenience. label Apr 2, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Fix plan 835 Hid request dialog keep on prompting up during pagination. #30384

feat: Fix plan 835 Hid request dialog keep on prompting up during pagination. #30384

dawnseeker8 commented Feb 18, 2025 •

edited by Montoya

Loading

github-actions bot commented Feb 18, 2025

metamaskbot commented Feb 18, 2025

metamaskbot commented Feb 19, 2025

metamaskbot commented Mar 6, 2025

metamaskbot commented Mar 7, 2025

metamaskbot commented Mar 10, 2025

metamaskbot commented Mar 13, 2025

vivek-consensys commented Mar 13, 2025

metamaskbot commented Mar 14, 2025

metamaskbot commented Mar 18, 2025

feat: Fix plan 835 Hid request dialog keep on prompting up during pagination. #30384

feat: Fix plan 835 Hid request dialog keep on prompting up during pagination. #30384

Conversation

dawnseeker8 commented Feb 18, 2025 • edited by Montoya Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Feb 18, 2025

metamaskbot commented Feb 18, 2025

metamaskbot commented Feb 19, 2025

metamaskbot commented Mar 6, 2025

metamaskbot commented Mar 7, 2025

metamaskbot commented Mar 10, 2025

metamaskbot commented Mar 13, 2025

vivek-consensys commented Mar 13, 2025

metamaskbot commented Mar 14, 2025

metamaskbot commented Mar 18, 2025

dawnseeker8 commented Feb 18, 2025 •

edited by Montoya

Loading